Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Павел Крюков" <kryukov@frtk.ru>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] Include <string.h> to dis-asm.h to get strchr declaration
Date: Mon, 14 Jan 2019 21:45:00 -0000	[thread overview]
Message-ID: <1da4814ae31a668a24b80e162f5941a3@polymtl.ca> (raw)
In-Reply-To: <CADip9ga4rPr6NiNzPBcEZCEwacMmGaNkvU-ZnmDw2L21qmXv2Q@mail.gmail.com>

On 2019-01-11 04:47, Павел Крюков wrote:
> Include <string.h> to dis-asm.h to get strchr declaration
> 
> include/Changelog:
> 2019-01-11  Pavel I. Kryukov  <kryukov@frtk.ru>
> 
>         * dis-asm.h: include <string.h>
> 
> diff --git a/include/dis-asm.h b/include/dis-asm.h
> index 77b9e61..02c7214 100644
> --- a/include/dis-asm.h
> +++ b/include/dis-asm.h
> @@ -32,6 +32,7 @@ extern "C" {
>  #endif
> 
>  #include <stdio.h>
> +#include <string.h>
>  #include "bfd.h"
> 
>    typedef int (*fprintf_ftype) (void *, const char*, ...)
> ATTRIBUTE_FPTR_PRINTF_2;

[Adding binutils@ in CC.]

I took the liberty of pushing this patch which touches code in include/, 
since it seemed obvious enough to me.

Simon


  reply	other threads:[~2019-01-14 21:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11  9:47 Павел Крюков
2019-01-14 21:45 ` Simon Marchi [this message]
     [not found]   ` <ba2125e4-19e6-9a94-e6c4-4d7472c91121@redhat.com>
2019-01-15 14:14     ` Simon Marchi
2019-01-15 17:50       ` John Baldwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1da4814ae31a668a24b80e162f5941a3@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kryukov@frtk.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox