From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 84A57385DC0A for ; Thu, 23 Apr 2020 20:25:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 84A57385DC0A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-BVqQZpNEMWOVpKMMyyBtYw-1; Thu, 23 Apr 2020 16:25:36 -0400 X-MC-Unique: BVqQZpNEMWOVpKMMyyBtYw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7BD1F835B49; Thu, 23 Apr 2020 20:25:35 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-112-48.phx2.redhat.com [10.3.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4404F6084D; Thu, 23 Apr 2020 20:25:35 +0000 (UTC) Subject: Re: [PATCH 0/4] Automatic detection of test name problems To: Andrew Burgess References: From: Keith Seitz Cc: gdb-patches@sourceware.org Message-ID: <1d98e66e-35d1-4314-6d33-a7bbd608ee34@redhat.com> Date: Thu, 23 Apr 2020 13:25:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2020 20:25:52 -0000 On 4/23/20 10:53 AM, Andrew Burgess wrote: > So, this series extends our testing framework so that Dejagnu will now > produce two new result types, these are: > > # of paths in test names > # of duplicate test names [snip] > I'll merge the first patch in this series (the > gdb.btrace/multi-inferior.exp fix) relatively soon as obvious. > > Feedback and thoughts welcome. This has been a constant source of annoyance and is long overdue. Bravo! I've looked over the series, sending queries as required. Overall, my only general comment is, "Why didn't *I* think of this?!?" Otherwise LGTM. Going one step further (maybe you've already considered this), maybe we can [bug Sergio to?] add something to the buildbot so that when it detects duplicates or pathnames, it emails the list as for regressions? Keith