From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110186 invoked by alias); 6 Oct 2016 01:01:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110173 invoked by uid 89); 6 Oct 2016 01:01:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:466 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 01:01:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB9F19E61D; Thu, 6 Oct 2016 01:01:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u96118pB031061; Wed, 5 Oct 2016 21:01:09 -0400 Subject: Re: [RFA 05/22] Turn wchar iterator into a class To: Tom Tromey , gdb-patches@sourceware.org References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-6-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <1d85eac0-b088-4c3e-c36b-c4e60ce5c992@redhat.com> Date: Thu, 06 Oct 2016 01:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474949330-4307-6-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00097.txt.bz2 On 09/27/2016 05:08 AM, Tom Tromey wrote: > This changes wchar_iterator from charset.c into a real C++ class, then > updates the users to use the class. This lets us remove some cleanups > in favor of the class' destructor. LGTM, assuming changed to use m_. > + > + /* The input string. This is updated as convert characters. */ While at it, looks like a typo here? "... as we convert ..." ? Thanks, Pedro Alves