From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57234 invoked by alias); 5 Jun 2018 23:31:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57225 invoked by uid 89); 5 Jun 2018 23:31:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jun 2018 23:31:34 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w55NVR6G027670 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 5 Jun 2018 19:31:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 6E5AC1E5AF; Tue, 5 Jun 2018 19:31:27 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E697E1E0A9; Tue, 5 Jun 2018 19:31:25 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 Jun 2018 23:31:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [RFA 2/6] Change representation of psymbol to flush out accessors In-Reply-To: <874lig4zby.fsf@tromey.com> References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-3-tom@tromey.com> <15d0da9f-93fa-5d23-ce4e-43d5befe48e7@redhat.com> <871sdm5smj.fsf@tromey.com> <7fa5ee6be895cd708b6cf646b1dbbff4@polymtl.ca> <874lig4zby.fsf@tromey.com> Message-ID: <1d7c5d58dbab0faa2b66cce2f755341b@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 5 Jun 2018 23:31:27 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00132.txt.bz2 On 2018-06-05 18:56, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I wanted for a while to convert all these macros to static > inline > Simon> functions, it just hasn't been high on the todo list. Since > you're > Simon> adding new code, would you mind making them static inline > functions > Simon> instead of macros (if you agree with the idea, of course)? > > How about just getting rid of them entirely and referring to the > members > directly? IMO the macros don't add any value, and I suppose functions > wouldn't really, either, with the exception of one for computing the > address. This could be the only method. > > Tom I am fine with that too. Simon