From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 70N5J26J6md+8SAAWB0awg (envelope-from ) for ; Mon, 31 Mar 2025 08:24:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b2dbG65m; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fJAN8BGI; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b2dbG65m; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fJAN8BGI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8C1A51E0C3; Mon, 31 Mar 2025 08:24:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F41B1E05C for ; Mon, 31 Mar 2025 08:24:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A74793857432 for ; Mon, 31 Mar 2025 12:24:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A74793857432 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b2dbG65m; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fJAN8BGI; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b2dbG65m; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fJAN8BGI Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 55BCA385840C for ; Mon, 31 Mar 2025 12:23:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55BCA385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 55BCA385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743423820; cv=none; b=Lec7oawp2Fn/36XwCM1RqHRxNv0/Wn57WGcauXcxxn0iBrVfSG9PzyWJfDZhQ+EIrF6DDMHGQ5SFplqTEJX13Hg7mnwlpkgp14Zv8nCTJY070zsgXCNPSXpC/EOwnRYq7WQfqtV2F5QMjJ0LpB+P473e+sMQV+EThdTiZvD9Xh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743423820; c=relaxed/simple; bh=lSfUwcAQuXrhegkCFOTYRCjnE1nbml+mws3F/IIRBt4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=N1HQ8Aoy7G3bnLSUdVr6pN5caeLDCJRB1Qst2QQCWfam1nE8Li9+EFlHIdDrFMBNhSznbTRv99ZNJJeHHECQ5TWnSUDAxuSMOUqWt7heqDe1406+yNB9BMrpLlpgHlmefIhdbzvGWBG2CHmp5x4xc2m5rDuZEn9xtsHFa3LZ1qM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55BCA385840C Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6F28821190; Mon, 31 Mar 2025 12:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743423819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a1xb4mojJUOAkkxGP8fMCSoQKfO0a/AHmnam0FK/Ps4=; b=b2dbG65msR0z0TxNnqi/T6igzoRhWVDZy6ZiNJetYl14bAAy+NIMHvToXe7Euq7WhHwSnD ZePk4kwks6Qui5iSPgBYagzlmvvGHGTJC2qrW4QoG5BcnB6X62wEI0K4eyCJwqdK4BhXrE 8a6qY0IMMUaqBMXcqEI4+dhk74X94AI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743423819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a1xb4mojJUOAkkxGP8fMCSoQKfO0a/AHmnam0FK/Ps4=; b=fJAN8BGIinXip0GWAyx8wQCaSS5dPxpx4Z3vKzkNKY1MF/7Sx7bh+W/kbpWoCk1Kyw9gp2 IzH1lV4upFAQBACQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743423819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a1xb4mojJUOAkkxGP8fMCSoQKfO0a/AHmnam0FK/Ps4=; b=b2dbG65msR0z0TxNnqi/T6igzoRhWVDZy6ZiNJetYl14bAAy+NIMHvToXe7Euq7WhHwSnD ZePk4kwks6Qui5iSPgBYagzlmvvGHGTJC2qrW4QoG5BcnB6X62wEI0K4eyCJwqdK4BhXrE 8a6qY0IMMUaqBMXcqEI4+dhk74X94AI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743423819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a1xb4mojJUOAkkxGP8fMCSoQKfO0a/AHmnam0FK/Ps4=; b=fJAN8BGIinXip0GWAyx8wQCaSS5dPxpx4Z3vKzkNKY1MF/7Sx7bh+W/kbpWoCk1Kyw9gp2 IzH1lV4upFAQBACQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 44C6F139A1; Mon, 31 Mar 2025 12:23:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +/n+DkuJ6mfOCwAAD6G6ig (envelope-from ); Mon, 31 Mar 2025 12:23:39 +0000 Message-ID: <1d68bef7-5917-438f-a6ee-58ce73b2fbfd@suse.de> Date: Mon, 31 Mar 2025 14:23:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport/common-inferior.c: Fix mingw build To: Lancelot SIX , gdb-patches@sourceware.org Cc: aburgess@redhat.com References: <20250331111358.200153-1-lancelot.six@amd.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20250331111358.200153-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:email, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/31/25 13:13, Lancelot SIX wrote: > A recent change (512ca2fca4b "gdb: split up > construct_inferior_arguments") introduced a build failure for mingw: > > CXX common-inferior.o > .../gdb/gdbsupport/common-inferior.cc: In function ‘std::string escape_characters(const char*, const char*)’: > .../gdb/gdbsupport/common-inferior.cc:62:20: error: ‘argv’ was not declared in this scope; did you mean ‘arg’? > 62 | if (strpbrk (argv[i], special)) > | ^~~~ > | arg > .../gdb/gdbsupport/common-inferior.cc:62:25: error: ‘i’ was not declared in this scope > 62 | if (strpbrk (argv[i], special)) > | ^ > > This patch fixes that. > Hi Lancelot, thanks for fixing this. I've reproduced the problem, and verified that the patch fixes it. I've looked at the patch introducing the problem, and I agree with the fix. Approved-By: Tom de Vries FWIW, there's a pre-existing style issue here, the strpbrk should be explicitly tested against nullptr, but I noticed the same issue in another file, so I propose that we leave this patch as is, and that I follow up with a patch taking care of that issue in both files. Thanks, - Tom > Change-Id: I07ade607bc4516627b433085b07d9d198d8e4b4a > --- > gdbsupport/common-inferior.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbsupport/common-inferior.cc b/gdbsupport/common-inferior.cc > index 4b868294062..e544780bd4b 100644 > --- a/gdbsupport/common-inferior.cc > +++ b/gdbsupport/common-inferior.cc > @@ -59,7 +59,7 @@ escape_characters (const char *arg, const char *special) > #ifdef __MINGW32__ > bool quoted = false; > > - if (strpbrk (argv[i], special)) > + if (strpbrk (arg, special)) > { > quoted = true; > result += quote; > > base-commit: 7109ea04ac79f641c48b6a1e6a2f3fc38a83c2ed