[PATCH] Remove an instance of MAX_REGISTER_SIZE from record-full.c

Alan Hayward
2017-06-12T09:34:32Z

In record_full_exec_insn use cooked_read_value instead of creating
a temp buffer.

Code to remove MAX_REGISTER_SIZE from uses of record_full_core_regbuf
will be in a different patch (I'm debugging some issues with it).

Tested on a --enable-targets=all build with board files unix and
native-gdbserver.

Ok to commit?

Alan.

2017-06-12 Alan Hayward <alan.hayward@arm.com>

* gdb/record-full.c (record_full_exec_insn): Use
regcache->cooked_read_value.

diff --git a/gdb/record-full.c b/gdb/record-full.c
index 31ff558d2a633cff71d3e6082e42f5d6fb88bcf1..2f09e2fc316d7d3073de035f961f7c3bf9d3002c 100644
--- a/gdb/record-full.c
+++ b/gdb/record-full.c
@@ -698,7 +698,7 @@ record_full_exec_insn (struct regcache *regcache,
{
case record_full_reg: /* reg */
{
- gdb_byte reg[MAX_REGISTER_SIZE];
+ struct value *value;

if (record_debug > 1)
fprintf_unfiltered (gdb_stdlog,
@@ -707,10 +707,13 @@ record_full_exec_insn (struct regcache *regcache,
host_address_to_string (entry),
entry->u.reg.num);

- regcache_cooked_read (regcache, entry->u.reg.num, reg);
- regcache_cooked_write (regcache, entry->u.reg.num,
- record_full_get_loc (entry));
- memcpy (record_full_get_loc (entry), reg, entry->u.reg.len);
+ value = regcache->cooked_read_value (entry->u.reg.num);
+ gdb_assert (value != NULL);
+ regcache->cooked_write (entry->u.reg.num, record_full_get_loc (entry));
+ memcpy (record_full_get_loc (entry), value_contents_all (value),
+ entry->u.reg.len);
+ release_value (value);
+ value_free (value);
}
break;