From: Simon Marchi <simon.marchi@polymtl.ca>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH] Implement struct type_stack with a vector
Date: Tue, 28 Aug 2018 15:26:00 -0000 [thread overview]
Message-ID: <1d1540932f6e57e430393e9e6d02335b@polymtl.ca> (raw)
In-Reply-To: <20180827184820.2ed97736@pinnacle.lan>
On 2018-08-27 21:48, Kevin Buettner wrote:
> On Mon, 27 Aug 2018 17:12:04 -0400
> Simon Marchi <simon.marchi@ericsson.com> wrote:
>
>> This patch changes the home-made stack implementation with a vector,
>> which makes it a bit more concise and readable.
>>
>> Regtested on the buildbot.
>>
>> gdb/ChangeLog:
>>
>> * parser-defs.h (struct type_stack) <elements>: Change type to
>> std::vector<union type_stack_elt>.
>> <depth, size>: Remove.
>> * parse.c (parse_exp_in_context_1): Adjust.
>> (type_stack_reserve): Remove.
>> (check_type_stack_depth): Remove.
>> (insert_into_type_stack): Adjust to std::vector.
>> (insert_type): Likewise.
>> (push_type): Likewise.
>> (push_type_int): Likewise.
>> (insert_type_address_space): Likewise.
>> (pop_type): Likewise.
>> (pop_type_int): Likewise.
>> (pop_typelist): Likewise.
>> (pop_type_stack): Likewise.
>> (append_type_stack): Likewise.
>> (push_type_stack): Likewise.
>> (get_type_stack): Likewise.
>> (type_stack_cleanup): Likewise.
>> (push_typelist): Likewise.
>> (follow_types): Likewise.
>> (_initialize_parse): Likewise.
>
> LGTM.
>
> Kevin
Thanks, I pushed it.
Simon
prev parent reply other threads:[~2018-08-28 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 21:12 Simon Marchi
2018-08-28 1:48 ` Kevin Buettner
2018-08-28 15:26 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1540932f6e57e430393e9e6d02335b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox