From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EOOtK1alu2Y1+AUAWB0awg (envelope-from ) for ; Tue, 13 Aug 2024 14:26:30 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZzcP8Tf1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8B1A01E0D0; Tue, 13 Aug 2024 14:26:30 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6679D1E08C for ; Tue, 13 Aug 2024 14:26:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E6BBD385843B for ; Tue, 13 Aug 2024 18:26:27 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 53C303858C5F for ; Tue, 13 Aug 2024 18:26:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 53C303858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 53C303858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723573569; cv=none; b=ZykzX9rU2UhMdscF8H9nGN7sCseAmbq3Z6uSIuCanl2T99BXOQMUtnkOUHd+5m6r0uaXaEOmhpmEltyI1UL/b1/RluRGE3TGizpEXQhYpdq+gVlJ7VJHLaPgSfj+miEBRnL3RhPC87o6gRA1Te/a3MkOjntj0opjBVodd4sLTDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723573569; c=relaxed/simple; bh=oU4HughpM/9yDLbXTdvM6efpJd3Z+oJ0jdXs6JWlXDE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fmxYsgj2cOK7XcGsQuziaWC/bvI96q2qbnJBCz8+Oj20z6xhBtgoFprVBbrgv1bMLqVpuSe3S6mTl/xlTJkDqoiOLf6mSfunFB6qBu5LCjKoq/2mK43FGoYypdB/kIgGU7H7wMkq3S4sDy1Qb7v5hHqvE4m33eyS69dRIMCsBNE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723573567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JVCcSR278tUyBFPzubxXr6wabTGa8mPeruhgVT4gcCo=; b=ZzcP8Tf1b3YYIwZLwMAjNrRuSWZmFC7RwfmJDTtBIGB/636Unx19jmoCnd1fK7ndkowJFI r2dXlgZSKQQJUxFBsl7Kqgl0yQLfWJ9svFUO67iwllyn7Aa1FIBB7nEBM52/lWcg8eTK0L EDTha+f/X8ctYkyg5eWGjFr8y3FhkdE= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-IS7XdY-HMzyu6yrKXibx1w-1; Tue, 13 Aug 2024 14:26:05 -0400 X-MC-Unique: IS7XdY-HMzyu6yrKXibx1w-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1fc5651e888so51578845ad.0 for ; Tue, 13 Aug 2024 11:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723573564; x=1724178364; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JVCcSR278tUyBFPzubxXr6wabTGa8mPeruhgVT4gcCo=; b=MAgEMzRvqkojLd81muca+GNautwFxqQ0S5ub+/vY1GeyV8v0wn4DUP8TNuUKN+5H+3 ca65D64WIXZ5MiTNeNtEaGRrZKz/bR+k5ALUWBWNtfvVnqu89zzaVQVzeA9hokmj1uWN U3s0FrO3dUFY4YOI1P3bUUAHeqPpyKx5BNCk9gY5eBpDjvh/B3AuJVaw9pMNIBJE2lis KE9nML9UR2mJ5xZUqd7nbrSOJCGi74droZCNsYOsihT1+/DUAlHkGdRSY/gr079SoSII ONwEyi1qTBBk+vW0P+plNIJOqBz82bnzW/L3gUh4QtWew9wXdCKcZR+ZmFV945Jta7Ja jxGw== X-Gm-Message-State: AOJu0YxIcS42yiAEB3WGZod1phl2pK8/wyHOQt/fPmx/eHaG4JZysQpW jCCAy/guePkBiys+Cheuqp5nINTIDoH+eN12vBtSgfKxRtsJkkQFrPU/k2vIdSsKDWnC7norHEq fBDgjULSzNbUq6OcVspgMUrDx6wdpOgR8l19E7BjZPhFvxLcU27doYIOT2elEY79ltus= X-Received: by 2002:a17:902:d48b:b0:1fc:692a:ba44 with SMTP id d9443c01a7336-201d6588bb0mr4833045ad.56.1723573564104; Tue, 13 Aug 2024 11:26:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlFwwKaV799dqJRk0YPc2kMxwhyR5gq9a5AbSg6TR3L2AyibHem0f8pHOOerLe+WSy2Uqxsg== X-Received: by 2002:a17:902:d48b:b0:1fc:692a:ba44 with SMTP id d9443c01a7336-201d6588bb0mr4832665ad.56.1723573563422; Tue, 13 Aug 2024 11:26:03 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201cd1cec6dsm16546775ad.282.2024.08.13.11.26.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 11:26:02 -0700 (PDT) Message-ID: <1d10c73b-0c94-46b5-a1a3-310bb48eed16@redhat.com> Date: Tue, 13 Aug 2024 15:26:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] Change message when reaching end of reverse history. To: Alex Chronopoulos Cc: "gdb-patches@sourceware.org" , Tom Tromey References: <20240802164306.252264-1-achronop@gmail.com> <9388437d-557d-45df-8513-d0a91a8e97a7@redhat.com> <23584087-2048-4904-825a-48b0f9d60ebb@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------wcdd2ZQ0lfssULJbiV1Ozhhd" Content-Language: en-US X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------wcdd2ZQ0lfssULJbiV1Ozhhd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I'm CC-ing Tom Tromey, as he's the one who usually talks about this in the list. Tom, Could you take care of this? -- Cheers, Guinevere Larsen She/Her/Hers On 8/13/24 3:18 PM, Alex Chronopoulos wrote: > Hooray \o/ > Thank you for the reviews. > I would like to push myself, how can I get write-after-approval rights? > > On Tue, Aug 13, 2024 at 2:55 PM Guinevere Larsen > wrote: > > On 8/13/24 5:52 AM, Metzger, Markus T wrote: > > Hello Alex, > > > >>> In a record session, when we move backward, GDB switches from > normal > >>> execution to simulation. Moving forward again, the emulation > continues > >>> until the end of the reverse history. When the end is reached, the > >>> execution stops, and a warning message is shown. This message > has been > >>> modified to indicate that the forward emulation has reached > the end, but > >>> the execution can continue as normal, and the recording will > also continue. > >>> > >>> Before this patch, the warning message shown in that case was > the same as > >>> in the reverse case. This meant that when the end of history > was reached in > >>> either backward or forward emulation, the same message was > displayed: > >>> > >>> "No more reverse-execution history." > >>> > >>> This message has changed for these two cases. Backward emulation: > >>> > >>> "Reached end of recorded history; stopping. > >>> Backward execution from here not possible." > >>> > >>> Forward emulation: > >>> > >>> "Reached end of recorded history; stopping. > >>> Following forward execution will be added to history." > >>> > >>> The reason for this change is that the initial message was > deceiving, for > >>> the forward case, making the user believe that forward > debugging could not > >>> continue. > >>> > >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224 > >>> --- > >> Hi! I think this is good to go in, but I would like Markus to > chime in > >> before pushing, since he mantains the other record subsystem, > so for now > >> > >> Reviewed-By: Guinevere Larsen > > OK for btrace. > > Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere > Larsen > > Do you already have write after approval rights for the repo? If > not, do > you plan to send more patches, so it makes sense to go after it? > If not, > I can push this for you :) > > -- > Cheers, > Guinevere Larsen > She/Her/Hers > > > > > Markus. > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de > > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany > Doon Silva > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928 > --------------wcdd2ZQ0lfssULJbiV1Ozhhd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
I'm CC-ing Tom Tromey, as he's the one who usually talks about this in the list. Tom, Could you take care of this?
-- 
Cheers,
Guinevere Larsen
She/Her/Hers
On 8/13/24 3:18 PM, Alex Chronopoulos wrote:
Hooray \o/
Thank you for the reviews.
I would like to push myself, how can I get write-after-approval rights?

On Tue, Aug 13, 2024 at 2:55 PM Guinevere Larsen <blarsen@redhat.com> wrote:
On 8/13/24 5:52 AM, Metzger, Markus T wrote:
> Hello Alex,
>
>>> In a record session, when we move backward, GDB switches from normal
>>> execution to simulation. Moving forward again, the emulation continues
>>> until the end of the reverse history. When the end is reached, the
>>> execution stops, and a warning message is shown. This message has been
>>> modified to indicate that the forward emulation has reached the end, but
>>> the execution can continue as normal, and the recording will also continue.
>>>
>>> Before this patch, the warning message shown in that case was the same as
>>> in the reverse case. This meant that when the end of history was reached in
>>> either backward or forward emulation, the same message was displayed:
>>>
>>> "No more reverse-execution history."
>>>
>>> This message has changed for these two cases. Backward emulation:
>>>
>>> "Reached end of recorded history; stopping.
>>> Backward execution from here not possible."
>>>
>>> Forward emulation:
>>>
>>> "Reached end of recorded history; stopping.
>>> Following forward execution will be added to history."
>>>
>>> The reason for this change is that the initial message was deceiving, for
>>> the forward case, making the user believe that forward debugging could not
>>> continue.
>>>
>>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224
>>> ---
>> Hi! I think this is good to go in, but I would like Markus to chime in
>> before pushing, since he mantains the other record subsystem, so for now
>>
>> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
> OK for btrace.

Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere
Larsen <blarsen@redhat.com>

Do you already have write after approval rights for the repo? If not, do
you plan to send more patches, so it makes sense to go after it? If not,
I can push this for you :)

--
Cheers,
Guinevere Larsen
She/Her/Hers

>
> Markus.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

--------------wcdd2ZQ0lfssULJbiV1Ozhhd--