From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KUtFJMfduGla4SwAWB0awg (envelope-from ) for ; Tue, 17 Mar 2026 00:51:19 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NfcKzCrp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8F8941E0BC; Tue, 17 Mar 2026 00:51:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 488A01E04F for ; Tue, 17 Mar 2026 00:51:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 579BE4B0A6CC for ; Tue, 17 Mar 2026 04:51:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 579BE4B0A6CC Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NfcKzCrp Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by sourceware.org (Postfix) with ESMTPS id 035774BAD152 for ; Tue, 17 Mar 2026 04:50:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 035774BAD152 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 035774BAD152 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::543 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773723052; cv=none; b=xFpYLdtIk4MKb4ZNninkicPpalSKvB97uZOKIHYv6uWIIvwcIvjjEmc1Q5xF1MJokeojxJKqfciGVShmJ844vV1gI6aAU+MfNUu2mAoWZaJFqg7hS0RbMzE9ut3L1H89Yol9NlH8zI+myqDE2gQCVQbwJFMJcawsZ1Va8gbUHkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773723052; c=relaxed/simple; bh=c33Y1QntKU/QI5hOFY6wF64lEG7OB/8JIk16uo0I1uY=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=g8oImPMMCByyvyMy3ZO7L/r41VYvv4MgxbAeZLQMK1R9rZgJaPkc2G3kib/967LE9DPMpYoeWBxrk0IewyoqftR2EaBX5TEnadgHMDn2vFsSN+7SX9XxfSbdsBqFCPdL9MbaKCZV5VmXhcvbIqYb66F4wQ4Zbd50X2R2b7bEq5I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 035774BAD152 Received: by mail-pg1-x543.google.com with SMTP id 41be03b00d2f7-c73fbdd9b53so745468a12.3 for ; Mon, 16 Mar 2026 21:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773723051; x=1774327851; darn=sourceware.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=xxjlPp6qt/KkMOwo/wvFXzSaheqyd75ENor22ILN+6E=; b=NfcKzCrptOcBQ1b1/xB19sBz92RIUcyi7xgBXhPloDfFbp+/56iQgZ/ReRDCJYa3BO xQmC1hJr9qWaDjsC/R5EG8XWIY0d4vXcIAmLFcoPkhDh01KIQ8KD0D5emsEwB3hHlIAe hd/zMqmlsWzdrJJzdf58h5omEagyI6emgmIQwFKV8lkdgpAqxqkJoRV4LbBndnadRGKe 1QdbRInvEFT9j00db++dhHCoHrm0PJt8KjPFJ0uxoMAAjwGyf+4jy98Hric7YNGtciRA 8cAdJHNlLp7s220N5PLd29rS2qsF6yhw8dLxTADjWgJ4EEzQY2jd3Jtd1Sdnw/DBS/VL ay+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773723051; x=1774327851; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xxjlPp6qt/KkMOwo/wvFXzSaheqyd75ENor22ILN+6E=; b=ebjS/DfXArQhFLbQ2O6sJ6gilcphl38ZHuusBupvdd5otCmNtWHTD6te+6QBfo7Iom IucIAN2D+LLOeK2zXtMupQvVTtl0oAXyDYKXFxsqqkUWiv11ZrVbtRTTa2baoa3Fptg/ 4D8s+qw3wHvGdSyCIvcLALmxh6uVLZRKHSzSowPQCBX8v4hAD+J0lLOUxQ0RhKbDts8t jvR8qL5D+zepsCMcgg+usBZOyx740ywcrazEhArQy+4XVfzb7hf+xeFnCW5qMbOFmC7P lwAtNb/8QBo2Dg91TzTFxERsfDg1MMKnywIse3jCiKojJ4ZVihxwEicj0CwdGlOYrkae Mq+w== X-Forwarded-Encrypted: i=1; AJvYcCV1XfhECwhbJ4hOIoKPFvAd5eGKkdlIEobwYZZaa0gW1lOmXzS+pnBW7sIiOecGxeqYq+j6jpTBRQc+tA==@sourceware.org X-Gm-Message-State: AOJu0YzSk63WBRBBlyhaQI2NjfyOv+joFgKALPijun9i8yaNNRs0ePZE 0DygLPa8c045oVgrNtsX8Uc0oZJO3B6g50mtZ+pBVH3rSPrc1qFd+fVg X-Gm-Gg: ATEYQzykhudSzPtFm5kLgbQj7E6X79Pos5248YSW0P7T1n34ICoesnXUgX7F+pFlqoR cRK8ZhZfclvFvPdlJnI2+baJeipFZlSfTkEmwtmVeUIU64c/T5uXNOXP9qjJu8AJMqXnxAjo8D3 HH1CyUBUHOZ6XI+NIuBEXKKvjiIK/yG34JUESTQmNo6Y+sUVJ8VCxqSOyP7XOtU64FMBRSqhuIz Cgqtmi8chOUG1J5tv6q+ov4LRgEARoNVJj2LVAN/pe0q5fqHdRfw73F2wnJfQbw5hh7jx3URV7d QChSLzjHVluDZAJ0lfKNYbP0IEwyoaFerYhGSEH2jJhE07S1XNVRKQy/RQ68ROYuyjbxWm2sFIF LOWyH/k1ZnIBK63huMgRJ9O7Xg726IiVgqQnxdQIPNkAvSMnqq2HzWPa8seovdrftaB72/1LlUh kXtryN7AgVC+UKsmhYaubEBhoSbWSYuOLG9lp67cmIpmM= X-Received: by 2002:a17:902:f641:b0:2b0:4eeb:f807 with SMTP id d9443c01a7336-2b04eebfb78mr78928085ad.13.1773723050769; Mon, 16 Mar 2026 21:50:50 -0700 (PDT) Received: from localhost.localdomain ([2407:c800:3620:e800:7910:9280:8105:5a2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece62bc32sm128985585ad.36.2026.03.16.21.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 21:50:50 -0700 (PDT) Message-ID: <1ca6adbf81c1e1eabeb3360d99a1e92b0f450604.camel@gmail.com> Subject: Re: [SH] Check FPSCR.PR for fldi0, fldi1 insns in simulator From: Oleg Endo To: Simon Marchi , gdb-patches@sourceware.org Date: Tue, 17 Mar 2026 13:50:48 +0900 In-Reply-To: <33b1b794-d592-45e7-9bb7-53a4a9c45607@simark.ca> References: <016918b6653a40835d2272c3c37d05b0d7e470b6.camel@gmail.com> <6eb50919-75d8-4725-9afa-e241e4cabab6@simark.ca> <9855a27b-78f6-4d4a-b0f6-04fefcaf7a49@simark.ca> <94f77e9bfecf923cfca8caa5427de7604ebe2fd7.camel@gmail.com> <33b1b794-d592-45e7-9bb7-53a4a9c45607@simark.ca> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-2.fc41) MIME-Version: 1.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 2026-03-16 at 21:19 -0400, Simon Marchi wrote: >=20 > On 2026-03-16 21:18, Oleg Endo wrote: > > On Wed, 2026-03-11 at 10:39 -0400, Simon Marchi wrote: > > >=20 > > > Ok, well since we're in "undefined behavior" territory we could argue > > > that the current sim behavior is fine. But I think the patch is stil= l > > > good, traping is a more useful behavior to catch something you don't > > > want to happen. > >=20 > > Yes, the current sim behavior is not wrong per se. But like you said, > > having it trap is more useful for sim's main purpose -- pre-verifying c= ode.=20 > >=20 > >=20 > > > > > The patch LGTM, but I am not a maintainer of the sim, so: > > > > >=20 > > > > > Reviewed-By: Simon Marchi > > > > >=20 > > > > > One note, please put the relevant information (the body of your e= mail) > > > > > into the commit log itself). > > > >=20 > > > > Yeah, sure I can expand the comment of the commit. Updated patch/c= ommit > > > > attached. > > >=20 > > > I would give it a week for Andrew or Mike to review and approve, but > > > otherwise I would feel comfortable merging it. > > >=20 > >=20 > > Alright. Last time I've checked I had write access. I can commit & pu= sh it > > myself. Just let me know. >=20 > Yes, please go ahead. >=20 >=20 Thanks. Committed & pushed as 17eb89e3c1cc6098f08e77d257468486a5c04ce4. Best regards, Oleg Endo