From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KRPLKwtedmrXOxIAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 18:36:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07Wp592r; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gbnBduLq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TSxKFijd; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=XFTrdjDV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AEE171E09B; Fri, 07 Aug 2026 18:36:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1FA9C1E09B for ; Fri, 07 Aug 2026 18:36:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC1384B9DB4E for ; Fri, 7 Aug 2026 22:36:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC1384B9DB4E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07Wp592r; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gbnBduLq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TSxKFijd; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=XFTrdjDV Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 0C9584B9DB4C for ; Fri, 7 Aug 2026 22:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C9584B9DB4C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C9584B9DB4C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786142195; cv=none; b=fcW/Je+lZ1h4UQBXXF1dcRYZyDX6yWWIwa1CRK0cZacfq/I9tX2jvYED5ZVOCzB2ssbiRl8sqvrjmqOGrySJjC4Tx0fgMex8mhVGTWIOXpPA2JPiqlQR51YR89tKue03o5o314wcczKaAUgtc9Wmguk2uPR7UQNq7Eieu5/6eBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786142195; c=relaxed/simple; bh=ulZsnCDDaBa0QILo1C2z79/MJiWrMO4LaPsF1mOeOFA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=syH4vuJ7GWDmBJrOVFRp/ppUMrqzsRdjYwIJuYNm5TTplXQtpP3h15KO5POPQNndSz+T8Hpy9NnLhNBqEHXpt1YPfbXaXuqrIkurpbb3akrGzNnC9dMeWaqQsmxDpq0MCA28oKNr0LwyXiFz/3eLEpZTi19Oaq5qInPnpTBRDiQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07Wp592r; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gbnBduLq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=TSxKFijd; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=XFTrdjDV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C9584B9DB4C Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D6D9980764; Fri, 7 Aug 2026 22:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786142190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dETE5sYHqm4gseVqXbYOk1PGulfYeZFopkGwt0Z7flg=; b=07Wp592rzTUNb9DSbA0BpqOFVfuRAaFsIzPUEL1c+cXlpv9FPGE7csptlbcBH542ZrGJk1 PatikRo3wheRKXkjqvio93cIJ1u7PGWYRIS3mBSX/0HIBlEs4tQIJkDNVlcXvgxYnw8+F+ Upzyt55xZV9N01bzSEPy390fYvvZsY8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786142190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dETE5sYHqm4gseVqXbYOk1PGulfYeZFopkGwt0Z7flg=; b=gbnBduLqJJMIRSe6odbfjnYRyr75roL9oHVmaR4f97BLPDBBx5l/0+uuAdEdj9v59zjcgw thnzTV9cz0CMeyDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1786142185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dETE5sYHqm4gseVqXbYOk1PGulfYeZFopkGwt0Z7flg=; b=TSxKFijdeEnBUB/7FPq1rCeUNxw7RHB216V/DALBZ91f0dqqjEnY5COFrJhgvlBEjZGWFc u45t63txWH4xh0MDx9Q9Zc/8QoVsFvniiql6ByncKdJQGpX6fd7gvNj0U/gMD3yOX/C8t8 eQFMZc3L2Aft8jOHo9nCayEr+f372o0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1786142185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dETE5sYHqm4gseVqXbYOk1PGulfYeZFopkGwt0Z7flg=; b=XFTrdjDVmqZ3tx2Iz+8NDjMbLIO1nlXfN/xD2UjXoSatR8ilsLjElYcrmg/wl/OhOcRsAT 26FcLtEyEZwe5DBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C036A779B6; Fri, 7 Aug 2026 22:36:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KNaOLelddmpJbwAAD6G6ig (envelope-from ); Fri, 07 Aug 2026 22:36:25 +0000 Message-ID: <1c4d78e2-087c-4848-8390-8822c5f44a65@suse.de> Date: Sat, 8 Aug 2026 00:36:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/python] Handle error in gdbpy_initialize_gdb_readline To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260807164842.3619235-1-tdevries@suse.de> <87pkztybni.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87pkztybni.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email, suse.de:mid, imap1.dmz-prg2.suse.org:helo, sourceware.org:url] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/7/26 9:26 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> if (eval_python_command (code, Py_file_input) == 0) > Tom> PyOS_ReadlineFunctionPointer = gdbpy_readline_wrapper; > Tom> + else > Tom> + { > Tom> + if (PyErr_Occurred ()) > Tom> + { > Tom> + PyErr_Print (); > Tom> + PyErr_Clear (); > > It's a bit more normal in the python layer to use gdbpy_print_stack, > since that respects user error-reporting settings. > > Tom> + warning (_("Disabling import readline failed, python-interactive" > Tom> + " command disabled")); > > CLI command names in output are normally double-quoted and displayed > using command_style. Hi Tom, thanks for the review. I've fixed these two issues in a v2 ( https://sourceware.org/pipermail/gdb-patches/2026-August/229270.html ). Thanks, - Tom