From: Pedro Alves <palves@redhat.com>
To: Philipp Rudo <prudo@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix memory leak in python.c:do_start_initialization
Date: Wed, 22 Mar 2017 18:45:00 -0000 [thread overview]
Message-ID: <1c478d49-d59a-1b58-a79e-844bd3db7fc8@redhat.com> (raw)
In-Reply-To: <20170322185224.40a2a37c@ThinkPad>
On 03/22/2017 05:52 PM, Philipp Rudo wrote:
>> OK with that change. Please push.
>
> Shall I fix it? Or do we go with your ldirname fix?
Please push in your fix first. It's small and obviously correct.
>> Perhaps better overall would be to make ldirname return a std::string
>> and eliminate these leaks "by design". It'd get rid of several
>> make_cleanup calls throughout too. I'll give that a quick try.
>
> Or maybe combining all path handling in a 'class gdbpath'. But
> make ldirname return std::string definitely is an advantage.
That'd be nice. If we do that, I think we should model the API on
C++17's filesystem::path http://en.cppreference.com/w/cpp/filesystem/path , to
ease a future transition.
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-03-22 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 13:11 Philipp Rudo
2017-03-22 13:11 ` [PATCH] Fix read after xfree in linux_nat_detach Philipp Rudo
2017-03-22 15:07 ` Pedro Alves
2017-03-22 17:17 ` Philipp Rudo
2017-03-22 17:26 ` Pedro Alves
2017-03-23 13:17 ` [PATCH v2] " Philipp Rudo
2017-03-23 13:42 ` Pedro Alves
[not found] ` <f712cd1a-cf44-44da-9bf4-3ccd407a76a0@redhat.com>
2017-04-12 8:14 ` Philipp Rudo
2017-03-22 15:19 ` [PATCH] Fix memory leak in python.c:do_start_initialization Pedro Alves
2017-03-22 17:52 ` Philipp Rudo
2017-03-22 18:45 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c478d49-d59a-1b58-a79e-844bd3db7fc8@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=prudo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox