From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4B772387086C for ; Thu, 7 May 2020 19:29:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4B772387086C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 589DA1E581; Thu, 7 May 2020 15:29:49 -0400 (EDT) Subject: Re: [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases To: Christian Biesinger , Michael Weghorn Cc: gdb-patches References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200429111638.1327262-3-m.weghorn@posteo.de> From: Simon Marchi Message-ID: <1c46b1a7-4ce9-cab0-dd16-f1f6bf8d9df3@simark.ca> Date: Thu, 7 May 2020 15:29:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2020 19:29:52 -0000 On 2020-04-29 11:45 a.m., Christian Biesinger via Gdb-patches wrote: > On Wed, Apr 29, 2020 at 10:25 AM Christian Biesinger > wrote: >> >> On Wed, Apr 29, 2020 at 6:17 AM Michael Weghorn via Gdb-patches >> wrote: >>> >>> Allow construct_inferior_arguments to handle zero args >>> and have it return a std::string, similar to how >>> stringify_argv in gdbsupport/common-utils does. >>> >>> Also, add a const qualifier for the second parameter, >>> since it is only read, not written to. >>> >>> The intention is to replace some existing uses of >>> stringify_argv by construct_inferior_arguments >>> in a subsequent step, since construct_inferior_arguments >>> properly handles special characters, while stringify_argv >>> doesn't. >> >> Can you clarify which revision your patch is against? My files look >> nothing like the ones you are patching. > > Oh, I see now that this patch applies on top of the other patch series you sent. I was also confused, normally the patch 0/N is the cover letter, not a patch to apply. Simon