From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8311 invoked by alias); 28 Sep 2017 14:19:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8272 invoked by uid 89); 28 Sep 2017 14:19:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=forgotten X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 14:19:50 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 08C76101709; Thu, 28 Sep 2017 14:19:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 08C76101709 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07C078E7B0; Thu, 28 Sep 2017 14:19:47 +0000 (UTC) Subject: Re: Fix gdb 8.1 Solaris/SPARC compilation (PR build/22206) To: Rainer Orth , Wei-min Pan References: <9f2fc29a-18a2-76c8-8e88-b7694ffe9f38@oracle.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1c43ef2e-00cb-5ede-de6e-1e25fe7e09cd@redhat.com> Date: Thu, 28 Sep 2017 14:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00864.txt.bz2 On 09/28/2017 01:40 PM, Rainer Orth wrote: > Hi Wei-min, > >> As for the issues you raised on gdb ADI support for Solaris/SPARC in the >> bug report, >> it's never intended to add that support for Solaris. While that Solaris >> provided a totally >> different ADI API was a factor, for example, Linux made the information of >> ADI block >> size available in the ELF aux record, one needed to make a syscall on >> Solaris to get that >> piece of information, it's certainly doable. It was never planned, >> however, and most likely >> will never be. > > this is extremely unfortunate, Oracle adding ADI support for one OS, but > not for its own ;-( > > However, what's worse is the way in which ADI support was added: when > you add code to a file shared between different OSes like > sparc64-tdep.c, it's your responsibility to make sure that this code at > least doesn't break other SPARC targets. Given how much of the code > there isn't actually shared (and not sharable, it seems), the approach > you've take seems wrong to me: it should have been properly factored > between shared (sparc64-tdep.c) and os-private > (e.g. sparc64-linux-tdep.c) files to avoid such breakage in the first > place. To be fair, that is the sort of issue that should have been pointed out in review. When I pushed for moving the ADI support out of the nat files and into tdep files for cross debugging, I don't think I even remembered Solaris was a thing... Not that I have anything against Solaris, to be clear. It just didn't cross my mind. To me, this indicates a few things: - It's great that the Solaris port is again seeing activity, and we should strive to make sure that SPARC changes consider it. - But also someone needs to continually keep an eye on Solaris lest it ends up forgotten and broken again. We need an official Solaris port maintainer. Any takers? :-) - It'd be desirable to have a SPARC Solaris machine build slave in the GDB buildbot, so that we can offload part of the work to bots. I wonder whether Oracle can help with this? Might be difficult with the whole Solaris situation... Thanks, Pedro Alves