From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159504-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 124918 invoked by alias); 14 Oct 2019 14:22:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 124908 invoked by uid 89); 14 Oct 2019 14:22:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 14:21:59 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x9EELpnq010802	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Mon, 14 Oct 2019 10:21:56 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9EELpnq010802
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca;	s=default; t=1571062917;	bh=bi8Js08Xpwpap7aVxRybo8/NH4kp7FuqkRYd0H6j3S0=;	h=Date:From:To:Subject:In-Reply-To:References:From;	b=Jbs1MxhHIpwbqAbAsAvl1KzCsIpvE7hzn5AnAZYzYa0GFWiH9ZX8DOHnOZC66XDTi	 pSQoQm4AvqHFMik/psNF/KKPbiYKghdeLoiYBihAQfU+ilP3/KPQv1U8aZsTKAtzKa	 /Ei4N+HQkHIRIkOszPMZo0bPQe/w2wwwnwz063zY=
Received: by simark.ca (Postfix, from userid 112)	id D51D11E79E; Mon, 14 Oct 2019 10:21:51 -0400 (EDT)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id E53341E575	for <gdb-patches@sourceware.org>; Mon, 14 Oct 2019 10:21:50 -0400 (EDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 14 Oct 2019 14:22:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: remove unused includes from dwarf2read.c
In-Reply-To: <20191013045218.3261363-1-simon.marchi@polymtl.ca>
References: <20191013045218.3261363-1-simon.marchi@polymtl.ca>
Message-ID: <1c1f820fa507243fd7a2096ec3eb2454@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.10
X-IsSubscribed: yes
X-SW-Source: 2019-10/txt/msg00336.txt.bz2

On 2019-10-13 00:52, Simon Marchi wrote:
> include-what-you-use says:
> 
> ../../../src/binutils-gdb/gdb/dwarf2read.c should remove these lines:
> - #include <ctype.h>  // lines 67-67
> - #include <sys/stat.h>  // lines 59-59
> - #include <sys/types.h>  // lines 83-83
> - #include <cmath>  // lines 88-88
> - #include <forward_list>  // lines 90-90
> - #include <set>  // lines 89-89
> - #include <unordered_set>  // lines 85-85
> - #include "completer.h"  // lines 60-60
> - #include "expression.h"  // lines 44-44
> - #include "gdbsupport/byte-vector.h"  // lines 78-78
> - #include "gdbsupport/filestuff.h"  // lines 71-71
> - #include "gdbsupport/gdb_unlinker.h"  // lines 74-74
> 
> After a quick glance, that makes sense, so this patch removes them.
> 
> Change-Id: I13cfcb2f1d747144fddba7f66b329630b79dae90

I pushed it after Tom de Vries reviewed it on Gerrit:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/24

Simon