From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 11583395B82A for ; Thu, 14 May 2020 11:32:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 11583395B82A Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-adZMyaUfP8ORef-mDqZgpw-1; Thu, 14 May 2020 07:32:16 -0400 X-MC-Unique: adZMyaUfP8ORef-mDqZgpw-1 Received: by mail-wr1-f72.google.com with SMTP id y4so1423204wrw.20 for ; Thu, 14 May 2020 04:32:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5y7UxdM4ydT0WYTrJqJDDnvbxux4b1LvrtlujjelEtE=; b=QdXTs+2XGWbpif4R36I0rEH1Wgp/GPzPQerdsO7InUwRL8wY3sL6vxh2itomlWCHdW zKoCvEa3q9g0pwBTQVZSbXkKwWxQS8E4iek9LjfZvEYX9AM8sjnXgjbYLeh06sXqAdbE GABW8fyct7acDP97IkLT7X65Hor6XfM0A2B8jml7A2+5fmYs772RAT4akn8gQpmjyCJj +yNk5xn6aw5H4bILNaxPZMeZSuaBNqhyfDk9OvNJTJmCxEsBuhXLBardSLg/k+PzT1ek fRdSNR8nh3eoW2Mh0SIMhp8DiO0wq4sHFFRgHVd/56KWf3JtPzX7nkYQHe1HAjihIudZ pVdw== X-Gm-Message-State: AGi0PuZiRvnc5D2VxhHHbAn1RAXX49qtMTgP/mG1/zmNOJ5QT3A+bsqa Uu3LN3jQ/+d5R6gqa2/KCC3fmUIAmxWDpcijaAec2z+AztufNcTdT2n3EcIJtfzsSNjAktGNYdz LTTYNaos29JXEB/qtGl7oUQ== X-Received: by 2002:a7b:c651:: with SMTP id q17mr30777224wmk.167.1589455935585; Thu, 14 May 2020 04:32:15 -0700 (PDT) X-Google-Smtp-Source: APiQypJzZYbfe43ywNKeTPhrS+GocaZRZP/lgvXycaC+G2leIbNmXREk4uhJ2dkCLigsIMNIgnieBg== X-Received: by 2002:a7b:c651:: with SMTP id q17mr30777208wmk.167.1589455935378; Thu, 14 May 2020 04:32:15 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id s8sm3461568wrt.69.2020.05.14.04.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2020 04:32:14 -0700 (PDT) Subject: Re: [PATCH v7 5/5] gdb/infrun: handle already-exited threads when attempting to stop To: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: From: Pedro Alves Message-ID: <1bf3eb3d-7ace-441f-6141-d29a227f49b3@redhat.com> Date: Thu, 14 May 2020 12:32:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 11:32:21 -0000 On 5/14/20 9:50 AM, Aktemur, Tankut Baris via Gdb-patches wrote: > Thank you for checking and updating the broader impact! This revision looks > very good to me. I had minor comments about 3 patches and I emailed them. > I pushed the suggested changes to this branch for convenience: > > https://github.com/barisaktemur/gdb/commits/thread-exit-in-stop-all-threads-v9 > > I repeated the regression testing with this branch, too. Great, thanks for doing that! Other than the small comments I made in response to the patches in v8, I agree with all your changes. This looks good to me. Thanks, Pedro Alves