From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u1FlJtmcvmqT0CQAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 13:48:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=r1Sd9sh+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7EE771E04F; Thu, 01 Oct 2026 13:48:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 82A111E047 for ; Thu, 01 Oct 2026 13:48:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F19564BB3B80 for ; Thu, 1 Oct 2026 17:48:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F19564BB3B80 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=r1Sd9sh+ Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 646844BB3BCE for ; Thu, 1 Oct 2026 17:47:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 646844BB3BCE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 646844BB3BCE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790876864; cv=none; b=uI/QMvW3MqWlqvw3kTCHduTpt+/yHgsmUQtHa4a5ODZ9WA0AO0xxG2Z72syU4PGwRHM58FeP4TQBw1rrEAqXKQn2hfExHQLy6PIBT/hE9u4on4XtvK28DgAGGR02LU68qlM5SUq01+5potgMe6fNpYiyutBmLkfBcKVD9vAKCkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790876864; c=relaxed/simple; bh=4fcQHGysnIn6L4I7MGGZ0W6+tRG+7zI0Oh3D/oAH4bQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EiLDwKtvL9/oqq4vAmX7ZeWdXLGPbpcOwLrJs4lsdbk1UKRQeylPzVCHhpLgQlspJSmpBXYydApccEeu74AaRRXxQEdfJiVDjhu4ln/WTukP7rrdkJnF0M1OFE3qeqKt//dJ7P+vmL1nRG1hBxhOH0E21mHo/lxEmCfGH75bm4A= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=r1Sd9sh+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 646844BB3BCE Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 691HlYu4207427 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Oct 2026 13:47:39 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 691HlYu4207427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1790876859; bh=KeOlkzoV9jt9mUv1wCYkHNla7hXISWDPbTk5EilIRVk=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=r1Sd9sh+kHHSnoO9P9i9yTO22CkyZYnmKbZEdLcmIeYyrXF5wjVZIgLkeANjVkVml b+RetGtxyPuiutDoMp2mIuBnJ1A2gi10UFllbJy65pWivcm8SUB597ABxDrCVgGVsb P8P+ufJ2zaJF2Hu35L7RMpt9mUhMWv/YtXB3AbvR7/xmoPNuCzsU84NZPwfyEzj+Dr +mR5K7kVbandWmnOF+7SedpetY5goba39HoHobj427FM6Uh8gmBIwY3Cjz444dqS68 zqmFeX7cVvyWlAU2/T+e5Q50xuC/7ozj2qKAjmmvXggvAjDsc/MZSohCkekQTzlwFl Qo+r0DSFXMmNw== Received: by simark.ca (Postfix) id A30BA1E047; Thu, 01 Oct 2026 13:47:33 -0400 (EDT) Message-ID: <1bee4aa2-0ab3-47c9-b989-fc3165d1d40b@polymtl.ca> Date: Thu, 1 Oct 2026 13:47:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/11] gdb: fix some comments in global_symbol_searcher To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-12-simon.marchi@polymtl.ca> <87jyo1xvmm.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87jyo1xvmm.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 1 Oct 2026 17:47:34 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/1/26 11:56 AM, Andrew Burgess wrote: > simon.marchi@polymtl.ca writes: > >> From: Simon Marchi >> >> Fix a few comments in and around global_symbol_searcher: >> >> - The comment of global_symbol_searcher::m_exclude_minsyms refers to >> M_SYMBOL_REGEXP, which does not (or no longer) exist. It means >> M_SYMBOL_NAME_REGEXP. >> >> - The comment in global_symbol_searcher::add_matching_msymbols refers >> to find_pc_symtab, which does not exist anymore. The code calls >> find_compunit_symtab_for_pc. >> >> - The comment of global_symbol_searcher calls it a structure, but it >> is a class. >> >> - RESULTS_SET -> RESULT_SET >> >> - MAX_SEARCH_RESULTS -> M_MAX_SEARCH_RESULTS > > Approved-By: Andrew Burgess > > Thanks, > Andrew Thanks for the reviews, I addressed your comments and pushed the series. Simon