From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58408 invoked by alias); 15 Nov 2018 10:59:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57585 invoked by uid 89); 15 Nov 2018 10:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:726, you! X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Nov 2018 10:59:12 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FDC15275A; Thu, 15 Nov 2018 10:59:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B05AC600CD; Thu, 15 Nov 2018 10:59:09 +0000 (UTC) Subject: Re: [RFA] Move copy_bitwise unittests to own unittest file To: Joel Brobecker References: <20181024162037.21024-1-tom@tromey.com> <20181101153517.GA2705@adacore.com> <082f66ea-223b-52f4-bc24-b274dbcf4f01@redhat.com> <609409e6-235a-4724-3ced-57c3ff42e299@redhat.com> <20181109171641.GD18647@adacore.com> <20181114171116.GA6074@adacore.com> <7628ab26-ad93-726c-f1d4-d5c60492115c@redhat.com> <20181114231724.GA4336@adacore.com> <20181115000158.GC4336@adacore.com> Cc: Tom Tromey , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1be97baa-1a76-dd84-e894-3e00036ec365@redhat.com> Date: Thu, 15 Nov 2018 10:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181115000158.GC4336@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00238.txt.bz2 On 11/15/2018 12:01 AM, Joel Brobecker wrote: > Here it is: > > gdb/ChangeLog: > > * unittests/copy_bitwise-selftests.c: New file. > * utils.c (selftests::bits_to_str, selftests::check_copy_bitwise) > (selftests::copy_bitwise_tests): Delete, moving this code to > unittests/copy_bitwise-selftests.c instead. > (_initialize_utils): Do not register copy_bitwise tests. > * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add > unittests/copy_bitwise-selftests.c. > > Tested on x86_64-linux using the official testsuite, but also by > verifying that "maintenance selftests" still runs the copy_bitwise > tests. > > OK to push to master? > OK. > Thank you! Thanks, Pedro Alves