From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YW1bCUs/VmVm3gcAWB0awg (envelope-from ) for ; Thu, 16 Nov 2023 11:11:55 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=qFZdj2jX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1A73B1E0D2; Thu, 16 Nov 2023 11:11:55 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A41321E091 for ; Thu, 16 Nov 2023 11:11:52 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E7443857340 for ; Thu, 16 Nov 2023 16:11:52 +0000 (GMT) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 6FE5E3858425 for ; Thu, 16 Nov 2023 16:11:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FE5E3858425 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FE5E3858425 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700151098; cv=none; b=ZLsDvImjlq9XsMoIkaZ6X2spQPa/X4A6NGVnRdvBNrQWYnZa9Hvd7N4h5JgVAJHirG+KDdcnJDOY8TtmToJkPTnPEgsy1SQ4s+VJEPXApavmAdnSGtdD9C2NjHeMZ0Bv831qCRQSJY56I0gAfqADLprIJ8xcmZR/mln/Gl+t4KQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700151098; c=relaxed/simple; bh=HHlrd68EUUCgZzm/vVUU2jgQv1hvxxr2mdfcOazsYmQ=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:Mime-Version; b=bep3EJGGWMkx4lF3SZnRZyDdqbdoiO2sNJGpRImtdf4SCJGzpeEu0m1CRF5elZVrGHxGCpiTMA7gkXMQjrsLvbkxFMNEVzP1RSgFfHDhQ3gv1jN4Vv+rZYUnbYAIN0pUPxrGbXY1dm/nOHoqJZQl106r7NcH4X+nakCO05IoIi4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AGG91cF026650; Thu, 16 Nov 2023 16:11:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=5ou6b//FtiVWM1N51dP8tEo5I8depw8rSaeKjNq9FBA=; b=qFZdj2jXT/VHJrLSf8IOIMIvwBHmpZm81bQwMwyDrNY9NjBqDgPof+Xjy3TNYqGmGYdu zikK75tBBIMGdEtP7kzYA61oPKU0qcw3+ODDTuNRWBnRsDIl3ur0r7XKca1+dxGay2Zt DYaARuXm/J37gQkXlDdq5HotmgRtr0DdRmKLWqGqByiCxgn2bhI7He7vkdIVB+O2xgUd YtOxwzjJnkN3S2L+CPuaeqIkvy+ZZESTJolkAC+VOMjiPjkrFMX08IlYLbSmIBB66OFU Lqc6AgcbQMSysdgyukQczyHnN96/A0Qti9kQByBKDsJBKsKFey5/TEbygNttYQ62q+w3 9A== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3udp61rf24-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 16:11:34 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AGFXu4g030074; Thu, 16 Nov 2023 16:11:33 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uanekykvd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 16:11:33 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AGGBXSo11796992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Nov 2023 16:11:33 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CC9B5805F; Thu, 16 Nov 2023 16:11:33 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56F0E58051; Thu, 16 Nov 2023 16:11:32 +0000 (GMT) Received: from wecm-9-67-110-146.wecm.ibm.com (unknown [9.67.110.146]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 16 Nov 2023 16:11:32 +0000 (GMT) Message-ID: <1be655a8cfef2afbab409a5802a999785e01924b.camel@linux.ibm.com> Subject: Re: Ada compile with -fvar-tracking From: Carl Love To: Luis Machado , Tom Tromey , cel@linux.ibm.com Cc: gdb-patches@sourceware.org Date: Thu, 16 Nov 2023 08:11:31 -0800 In-Reply-To: References: <871qcsp1h9.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dhgAY64AfgYWBo0SJkBUQp-zR6tfPIM2 X-Proofpoint-ORIG-GUID: dhgAY64AfgYWBo0SJkBUQp-zR6tfPIM2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-16_16,2023-11-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 mlxlogscore=590 clxscore=1015 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311160126 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Luis, Tom: On Thu, 2023-11-16 at 14:02 +0000, Luis Machado wrote: > On 11/14/23 21:17, Carl Love wrote: > > Tom: > > > > On Tue, 2023-11-14 at 12:40 -0700, Tom Tromey wrote: > > > set flags {debug additional_flags=-cargs additional_flags=-fvar- > > > tracking additional_flags=-margs} > > > > So I put that in as follows: > > > > set flags {debug additional_flags=-cargs additional_flags=-fvar- > > tracking additional_flags=-margs} > > I guess one way to make the above slightly cleaner (debatable) is to > append the additional flags on different lines: > > set flags {"debug"} > lappend flags "additional_flags=-cargs" > lappend flags "additional_flags=-fvar-tracking" > lappend flags "additional_flags=-margs" > > Slightly more verbose, but may make the additional flags more > explicit/easier to read. Yes, I do think that is easier to read. So I worked on the patch some more once I got it to compile to see if I need all three options on PowerPC. On Power, I only seem to need the -fvar-tracking option. The -cargs and -margs don't seem to have any effect on PowerPC. It looks like the following is all that I need on Power: --- a/gdb/testsuite/gdb.ada/finish-large.exp +++ b/gdb/testsuite/gdb.ada/finish-large.exp @@ -19,7 +19,13 @@ require allow_ada_tests standard_ada_testfile p -if {[gdb_compile_ada "${srcfile}" "${binfile}" executable debug] != ""} { +if {[have_fvar_tracking]} { + set flags {debug additional_flags=-fvar-tracking} +} else { + set flags {debug} +} + +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable $flags] != ""} { return -1 I think Power is the only platform that needs -fvar-tracking for this test so I was inclined to leave off the other two options. But if not having the other two options with -fvar-tracking causes issues on other platforms then I should include them. Tom, for your platform do you have to have all three options or not? I tested the above patch on PowerPC and X86-64. It seems to work fine on both systems. Carl