Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 07/11] sim/rx: move some variable declarations to the start of the block
Date: Mon,  1 Feb 2021 11:44:10 +0000	[thread overview]
Message-ID: <1b842eda3cbf2f16d414c6bca3f250bb8a1e11ac.1612179773.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1612179773.git.andrew.burgess@embecosm.com>

For sim code variables still need to be declared at the start of the
enclosing block.  This silences a few GCC warnings.

sim/rx/ChangeLog:

	* syscalls.c (rx_syscall): Move declaration of some variables to
	the start of the enclosing block.
	* trace.c (load_file_and_line): Likewise.
---
 sim/rx/ChangeLog  | 6 ++++++
 sim/rx/syscalls.c | 5 +++--
 sim/rx/trace.c    | 3 ++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/sim/rx/syscalls.c b/sim/rx/syscalls.c
index 2f89da17330..22778b3df49 100644
--- a/sim/rx/syscalls.c
+++ b/sim/rx/syscalls.c
@@ -160,6 +160,7 @@ rx_syscall (int id)
 
     case SYS_open:
       {
+	int oflags, cflags;
 	int path = arg ();
 	/* The open function is defined as taking a variable number of arguments
 	   because the third parameter to it is optional:
@@ -167,8 +168,8 @@ rx_syscall (int id)
 	   Hence the oflags and cflags arguments will be on the stack and we need
 	   to skip the (empty) argument registers r3 and r4.  */
 	argp = 4;
-	int oflags = arg ();
-	int cflags = arg ();
+	oflags = arg ();
+	cflags = arg ();
 
 	read_target (buf, path, 256, 1);
 	if (trace)
diff --git a/sim/rx/trace.c b/sim/rx/trace.c
index 6f9294ad75a..9d9f2dfd98d 100644
--- a/sim/rx/trace.c
+++ b/sim/rx/trace.c
@@ -139,6 +139,7 @@ load_file_and_line (const char *filename, int lineno)
       break;
   if (!f)
     {
+      FILE *file;
       int i;
       struct stat s;
       const char *found_filename, *slash;
@@ -159,7 +160,7 @@ load_file_and_line (const char *filename, int lineno)
       files = f;
       f->filename = strdup (filename);
       f->data = (char *) malloc (s.st_size + 2);
-      FILE *file = fopen (found_filename, "rb");
+      file = fopen (found_filename, "rb");
       fread (f->data, 1, s.st_size, file);
       f->data[s.st_size] = 0;
       fclose (file);
-- 
2.25.4


  parent reply	other threads:[~2021-02-01 11:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 11:44 [PATCH 00/11] fix build warnings for rx simulator Andrew Burgess
2021-02-01 11:44 ` [PATCH 01/11] sim/rx: define sim_memory_map Andrew Burgess
2021-02-01 14:46   ` Mike Frysinger via Gdb-patches
2021-02-08 11:01     ` Andrew Burgess
2021-02-01 11:44 ` [PATCH 02/11] sim/rx: fix an issue where we try to modify a const string Andrew Burgess
2021-02-01 11:44 ` [PATCH 03/11] sim/rx: fill in missing 'void' for empty argument lists Andrew Burgess
2021-02-01 11:44 ` [PATCH 04/11] sim/rx: mark some functions as static Andrew Burgess
2021-02-01 11:44 ` [PATCH 05/11] sim/rx: delete an unused function Andrew Burgess
2021-02-01 11:44 ` [PATCH 06/11] sim/rx: use puts instead of printf in a few places Andrew Burgess
2021-02-01 14:49   ` Mike Frysinger via Gdb-patches
2021-02-08 10:58     ` Andrew Burgess
2021-02-01 11:44 ` Andrew Burgess [this message]
2021-02-01 11:44 ` [PATCH 08/11] sim/rx: use PRIx64 in printf format string Andrew Burgess
2021-02-01 11:44 ` [PATCH 09/11] sim/rx: add some missing includes Andrew Burgess
2021-02-01 11:44 ` [PATCH 10/11] sim/rx: avoid pointer arithmetic on void * pointers Andrew Burgess
2021-02-01 11:44 ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-01 14:50   ` Mike Frysinger via Gdb-patches
2021-02-02  4:53     ` [PATCH] sim: erc32/m32c/rl78: add sim_memory_map stub for gdb Mike Frysinger via Gdb-patches
2021-02-08 10:57     ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-02  4:37 ` [PATCH 00/11] fix build warnings for rx simulator Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b842eda3cbf2f16d414c6bca3f250bb8a1e11ac.1612179773.git.andrew.burgess@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox