From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75119 invoked by alias); 15 Sep 2018 13:16:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74964 invoked by uid 89); 15 Sep 2018 13:16:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=H*Ad:D*fr, explanations, H*M:smile X-HELO: idris.smile.fr Received: from idris.smile.fr (HELO idris.smile.fr) (91.216.209.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Sep 2018 13:15:46 +0000 Received: from localhost (localhost [127.0.0.1]) by idris.smile.fr (Postfix) with ESMTP id DBE111EE270D; Sat, 15 Sep 2018 15:15:37 +0200 (CEST) Received: from idris.smile.fr ([127.0.0.1]) by localhost (bluemind-mta.prod.vitry.intranet [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TsHUTwXrXrDl; Sat, 15 Sep 2018 15:15:37 +0200 (CEST) Received: from [192.168.1.17] (LFbn-1-477-200.w86-245.abo.wanadoo.fr [86.245.183.200]) by idris.smile.fr (Postfix) with ESMTPSA id AB2A61EE265E; Sat, 15 Sep 2018 15:15:37 +0200 (CEST) Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c To: Joel Brobecker Cc: Sergio Durigan Junior , Tom Tromey , Pedro Alves , GDB Patches , Rich Felker , Thomas Petazzoni , Romain Naour References: <20180912173113.2007-1-sergiodj@redhat.com> <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> <874leulhqt.fsf@redhat.com> <203b1739-3418-2aa4-c40e-c2e63e717297@smile.fr> <87h8ir3gg6.fsf@tromey.com> <87in37oimf.fsf@redhat.com> <6e01d5ff-42bb-e1fc-162c-aa3fe97cf6b2@smile.fr> <20180914220940.GB26509@adacore.com> From: Romain Naour Message-ID: <1b59da32-0fa0-fd8f-ddd6-507e45df2988@smile.fr> Date: Sat, 15 Sep 2018 13:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180914220940.GB26509@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-09/txt/msg00490.txt.bz2 Hi Joel, All, Le 15/09/2018 à 00:09, Joel Brobecker a écrit : > Hello Romain, > >>> Me too. I can backport it to 8.2 if wanted. >> >> Yes please for the upcoming 8.2.1. > > Once a release has been made off a give branch, there are a couple > of additional conditions before we can backport that change to > that branch: > > - The patch needs to be safe, and you need approval from a Global > Maintainer to do so; > > I looked at the patch, and although I was nervous about > the removal of the #include at first, I checked > the contents of the file, and I am reasonably certain that > there isn't any other code that might needed on some obscure > system. So you have my OK for the patch to be backported to > the gdb-8.2-branch. Ok, thanks. Note that Sergio is the original author of this part of the code introduced with gdb 8.2 and backported to gdb 8.1.1 [1]. > > - And the commit should have a corresponding GDB PR number > (https://sourceware.org/bugzilla/); the PR number acts as > a reference for "what's changed" in each corrective release, > so the clearer the explanation in the description, the better. > > If you are the one motivated for the backport, it would be > helpful if you could take care of creating the PR. Sergio > offered to then backport it for you, but I can also help > with that. I'm agree on the principle but the change from gdb 8.2 introducing the issue has been backported to gdb 8.1.x [1] without such GDB PR number (as far I can see). IIUC, all patches backported to a stable branch must have a GDB PR number. This is not always the case. Without the fix provided by Sergio (Thanks!) we can't build gdb with a musl toolchain, so gdb 8.1.x and gdb 8.2.x remain unfixed. I'll create the GDB PR but all explanations of the issue have been provided on the mailing list by gdb developers and maintainers. [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=2441702a72f324e41a1624dc042b334f375e2d81 Best regards, Romain > > Thank you, >