From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0hmWDbrvD2YqYiQAWB0awg (envelope-from ) for ; Fri, 05 Apr 2024 08:34:02 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OD+9WSL7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 141BA1E0C0; Fri, 5 Apr 2024 08:34:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D44161E0AC for ; Fri, 5 Apr 2024 08:33:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E08138449C2 for ; Fri, 5 Apr 2024 12:33:59 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3FC6B3858415 for ; Fri, 5 Apr 2024 12:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FC6B3858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FC6B3858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712320411; cv=none; b=U8Hfqj2vhoRrPY7gt9Y/iP/pPW3ZMnPXV0itq9xBlLU9rzy3HR11hbdHLUhvlBnxwL9nBX2UMqsKWhZzrKWUUG2iIM3f8PwZIXWZT+qAKbLxJgBVHwcR8soknmH8sgTnRrJTmtQOkzTCKZNzlA3xneEkPHodMvpgQy7QeSw24qs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712320411; c=relaxed/simple; bh=yiDzReFTmgjZxtx1m91e3vf+gpkAFF+f6tQHfUKZzwM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=RcT08cmCoCLFW8mc1MIZIpQ2vW/iXyuwOTJ19b7iUW+IyJ/D4WCboF4kf+NObE1HHMb5Y39OHsmpi+hrd4ZrSF9cBHQ2GH5AN9O7kzhDEOGC0ACVam5jzYzGuJ3VKiK/W7MdbzsL8iKHlxU0z+yrj602avXKqo1VheXF7CWqWrI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712320409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V7chVvtsT4dVQU68UMOmv7bwIEBZAGYP8/qlIwi8Dzs=; b=OD+9WSL7ge9ffapyeZnSrvbW0UYOc8bkEx+lxUCFLoWCfCrcUHVFMxgN1qqqCcVg79DlSM +UTeumnmoooC9eORiIbPovkb8RVzPTIh8Bry2qKaKK7/TPqfIs9AJEtx85UkSdeMBS2p4u ou/EV1I7ss9PpeXq64tLEjNlgu9lQb8= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-_RmHI5BKMfiRbsucutsTGA-1; Fri, 05 Apr 2024 08:33:28 -0400 X-MC-Unique: _RmHI5BKMfiRbsucutsTGA-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-56c1c344fe0so869145a12.0 for ; Fri, 05 Apr 2024 05:33:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712320407; x=1712925207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V7chVvtsT4dVQU68UMOmv7bwIEBZAGYP8/qlIwi8Dzs=; b=ib8tkyAypQ8Xfp0DscW+qo+IK+NKifs4PlH/bplIrhkHcjClVGGGRLlomVfkg+Pihv OSVFoUtg0d3/IYll7HyurFwJCWZrb2JPAbLxdaEliDFdyDri4HZ7Nq2EUgcQbYW4G48z OfheXg2LJ01RjoBf6LCjUpe0le4ytQFEVm4jBeSthq386UDl9pLZyZRMMoIFQB7joc85 pixZrK5mSqN/BgLMvCy5hqBo7uNnLEYbk/toDD9+9k7FFqzHsMrKG9caPN7LbfRtRcFV 6uNcJUW9PWBRAoiyFo2vhXnIwNXaGQjbfkcuXAWs9FVRLI7FhPtxlVAcCc9AlRyGTJP4 hFWw== X-Gm-Message-State: AOJu0YwqCU3JD5lqY/q0SS8c7pyMQAc15MFnnilxBH36nqBWJH1/0PpQ NMBFiTc/gERMI7ze/CkJcnSf/aslQ9Ijbrfe4kKVh7eZxxGDesJECuVz8BC2XMAcwd6NsruMI/+ tlDBwHXPnFEW0YNOnc0N6YP8pYy+RhybqrdgjdRKlL5mR9HuIic7qUN3u/FxlC/ogHyWHPD5Y0A EE9a4Se8uMJSA1/qdtnxeg768JI/JucQVGFm5d6TPk69Q= X-Received: by 2002:a50:cc86:0:b0:568:a4b6:9828 with SMTP id q6-20020a50cc86000000b00568a4b69828mr1015753edi.30.1712320406501; Fri, 05 Apr 2024 05:33:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGltBE5yA539lmDWYpZodOeJ7y+lWDXA3bxKuVeUZ/tbgOR36CKNNhZ7piLSLyvVJjZCEZhsQ== X-Received: by 2002:a50:cc86:0:b0:568:a4b6:9828 with SMTP id q6-20020a50cc86000000b00568a4b69828mr1015732edi.30.1712320405886; Fri, 05 Apr 2024 05:33:25 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id d2-20020a05640208c200b0056dd4cdb1c5sm741636edz.87.2024.04.05.05.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 05:33:25 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv4 01/10] gdbserver/ipa/x86: remove unneeded declarations Date: Fri, 5 Apr 2024 13:33:11 +0100 Message-Id: <1b2bd9ca7690604ebaabbef92f381ad91d9b08fc.1712245988.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no longer needed. These are: 1. 'init_registers_amd64_linux' - the comment claims this function is auto generated, but I don't believe that this is still the case. Also the function is not used in this file, 2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but neither are used in this file, so lets remove the declaration. The amd64 in-process-agent still builds fine after this commit. There should be no user visible changes after this commit. --- gdbserver/linux-amd64-ipa.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc index 13c8a5bb360..a6346750f49 100644 --- a/gdbserver/linux-amd64-ipa.cc +++ b/gdbserver/linux-amd64-ipa.cc @@ -23,10 +23,6 @@ #include "linux-x86-tdesc.h" #include "gdbsupport/x86-xstate.h" -/* Defined in auto-generated file amd64-linux.c. */ -void init_registers_amd64_linux (void); -extern const struct target_desc *tdesc_amd64_linux; - /* fast tracepoints collect registers. */ #define FT_CR_RIP 0 -- 2.25.4