From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ULWtKRLrkmFAUQAAWB0awg (envelope-from ) for ; Mon, 15 Nov 2021 18:19:46 -0500 Received: by simark.ca (Postfix, from userid 112) id A88C21F0C1; Mon, 15 Nov 2021 18:19:46 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 58F111ECEB for ; Mon, 15 Nov 2021 18:19:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B51BC3857C4A for ; Mon, 15 Nov 2021 23:19:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B51BC3857C4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637018385; bh=Kdlxmo9IAoFAGL+tey2QuhPMdWTz2RVsxK5zu+VRPww=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=cONwsRiJzAcOtHTu8XkXJmXHERozGFjVTEEv0jftUuL0zfpwJ4KtXOVXKb4cfOFPh tp8YU8jtXNfhhEDfPnPtJ1FOZtBEYCtwP7cQe1NAcL1jdXpb2JKhWhrY5Iak9xxsOw wcMcOPYBRU9s0cztazlJYwqxKQdyy5jTOcZKvmkA= Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by sourceware.org (Postfix) with ESMTPS id 868EE3858405 for ; Mon, 15 Nov 2021 23:19:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 868EE3858405 Received: by mail-ua1-x92b.google.com with SMTP id i6so38380515uae.6 for ; Mon, 15 Nov 2021 15:19:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kdlxmo9IAoFAGL+tey2QuhPMdWTz2RVsxK5zu+VRPww=; b=BpWLEdUPPjIou233rh2OV0uslHbNlMDOIsb9DhUzJCqkG37jyDsTgo7F7Yri/5EQiT SIa3KmBEt56xCE6+BSlFocQrB40Aibvym4V2ZRCI5UcT1y/KSw5dgtlx0nRVjnjKlPok 86ifG0ZMjG3js3sTrRlDEpUCs6KnFedIAejXaheUTcj8oZZ2RZZ8APCVzgeMHqJZb62c S7uiiqsOlLMOP5YMEBdLkdkWTgBBjPZCcfnuHdT98xYU8gXtSZrinjDkz6R9q2tO0Apf tMI1mXcZkJZOwuNirJyx9cx9oMorU66TF9tVGN7rU9qXvqu7Gt7y7f7/cwrur850qSPe W/qQ== X-Gm-Message-State: AOAM532eGF7SSlFQsm/EfE10S/2DaWcoxdC+UX+6R8+lguilDsmHwt5t PqMtzXvGcgiMeBVGYzCvQI7lpQ== X-Google-Smtp-Source: ABdhPJxg+Yf3LEg4GzRxCp75HbjQpyy9tzJxUR8KAm8CKHrdYjpaZFO8+ug2z2S58GUVp2y40DKHdQ== X-Received: by 2002:a67:d28b:: with SMTP id z11mr49408304vsi.49.1637018363179; Mon, 15 Nov 2021 15:19:23 -0800 (PST) Received: from [128.0.53.100] ([177.81.208.251]) by smtp.gmail.com with ESMTPSA id bb13sm9263065vkb.11.2021.11.15.15.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 15:19:22 -0800 (PST) Subject: Re: [PATCH] gdb: fix gdbarch_tdep ODR violation To: Simon Marchi , will schmidt , Simon Marchi , gdb-patches@sourceware.org, John Baldwin References: <20211112204233.4108340-1-simon.marchi@efficios.com> <6f000cddd5fa3bb69f7321667a3aab83225531e9.camel@vnet.ibm.com> <3eb3037d-2d40-d156-a8df-1c0447a9efaf@efficios.com> Message-ID: <1af2a07d-43ee-20ff-4a6c-0d422503c2e0@linaro.org> Date: Mon, 15 Nov 2021 20:19:14 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <3eb3037d-2d40-d156-a8df-1c0447a9efaf@efficios.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 11/15/21 5:43 PM, Simon Marchi wrote: > On 2021-11-15 3:42 p.m., will schmidt wrote: >> On Mon, 2021-11-15 at 11:29 -0500, Simon Marchi wrote: >>> On 2021-11-15 5:45 a.m., Luis Machado via Gdb-patches wrote: >>>> LGTM >>> >>> Thanks to you and John for taking a look, I pushed the patch. >>> >>> Simon >>> >> >> Hi, >> >> I'm now seeing a build failure on powerpc. (specifically ppc64le, but >> i'm not sure it will matter which powerpc variant). >> >> First failure is >> >> ... >> CXX ppc-linux-nat.o >> ppc-linux-nat.c: In function ‘int ppc_register_u_addr(gdbarch*, int)’: >> ppc-linux-nat.c:658:22: error: ‘struct gdbarch_tdep’ has no member >> named ‘ppc_gp0_regnum’ >> 658 | if (regno >= tdep->ppc_gp0_regnum >> ... >> >> >> Assorted other no-such-member errors follow. >> >> >> >> Thanks, >> -Will >> > > Yeah, I kind of forgot to look for uses of gdbarch_tdep in native files, > which are not built by default on x86-64 :(. I'm working on a patch to > fix all of them. Yeah. I do see some breakage for native arm/aarch64 as well. Do you think it might be easier to revert then re-validate the new patch. I suppose some targets are tricky to build native files for.