From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55065 invoked by alias); 1 Jun 2018 20:06:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55048 invoked by uid 89); 1 Jun 2018 20:06:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=BAYES_00,GIT_PATCH_1,KAM_STOCKGEN,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=objfile X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Jun 2018 20:06:34 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E1B1F820FB; Fri, 1 Jun 2018 20:06:32 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A658F5C57D; Fri, 1 Jun 2018 20:06:32 +0000 (UTC) Subject: Re: [RFA 3/6] Make PSYMBOL_VALUE_ADDRESS take objfile argument To: Tom Tromey , gdb-patches@sourceware.org References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-4-tom@tromey.com> From: Keith Seitz Message-ID: <1a874bc2-1a4d-3dd5-4718-10b93d5d2868@redhat.com> Date: Fri, 01 Jun 2018 20:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180503223621.22544-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00033.txt.bz2 On 05/03/2018 03:36 PM, Tom Tromey wrote: > > Note that the macro doesn't actually perform any relocation -- it uses > the argument, to ensure that any possible syntax errors are caught, > but it multiplies it by 0 so that it has no effect. Just a word of warning: ANOFFSET will assert if PSYMBOL_SECTION is -1. [Setting that field isn't added until the last patch.] As a result, I am seeing a lot of temporary regressions. I build with -O0, so maybe these won't show up during a buildbot test run? Example from gdb.base/reread.exp: run Starting program: /home/keiths/work/gdb/branches/tromey-psymbols-progspace.patch /linux/gdb/testsuite/outputs/gdb.base/reread/reread ../../src/gdb/psymtab.c:493: internal-error: Section index is uninitialized A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : run to foo() (GDB internal error) Resyncing due to internal error. > ChangeLog > 2018-05-03 Tom Tromey > > * psympriv.h (SET_PSYMBOL_VALUE_ADDRESS) > (PSYMBOL_VALUE_RAW_ADDRESS): New macros. > (PSYMBOL_VALUE_ADDRESS): Add 'objfile' parameter. > * psymtab.c (find_pc_sect_psymtab_closer, find_pc_sect_psymbol) > (fixup_psymbol_section, relocate_psymtabs): Update. > (print_partial_symbols): Add 'objfile' parameter. Update. > (dump_psymtab, add_psymbol_to_bcache, psym_fill_psymbol_map): > Update. With that caveat, (and IANAM), this LGTM. Keith