From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id V8fZA6BHZmIMaQIAWB0awg (envelope-from ) for ; Mon, 25 Apr 2022 03:02:56 -0400 Received: by simark.ca (Postfix, from userid 112) id 665A41E058; Mon, 25 Apr 2022 03:02:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4FCD71E00D for ; Mon, 25 Apr 2022 03:02:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 917A33857820 for ; Mon, 25 Apr 2022 07:02:52 +0000 (GMT) Received: from nx226.node02.secure-mailgate.com (nx226.node02.secure-mailgate.com [192.162.87.226]) by sourceware.org (Postfix) with ESMTPS id 906423858002 for ; Mon, 25 Apr 2022 07:02:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 906423858002 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=trande.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=trande.de Received: from host202.checkdomain.de ([185.137.168.148]) by node02.secure-mailgate.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1nisjs-00GLWx-V6; Mon, 25 Apr 2022 09:02:38 +0200 X-SecureMailgate-Identity: zied.guermazi@trande.de;host202.checkdomain.de Received: from [192.168.178.48] (dynamic-077-179-168-191.77.179.pool.telefonica.de [77.179.168.191]) (Authenticated sender: zied.guermazi@trande.de) by host202.checkdomain.de (Postfix) with ESMTPSA id ECA9A2804F1; Mon, 25 Apr 2022 09:02:26 +0200 (CEST) X-SecureMailgate-Identity: zied.guermazi@trande.de;host202.checkdomain.de Message-ID: <1a6a663b-0ea3-3704-402f-9a1ad49822da@trande.de> Date: Mon, 25 Apr 2022 09:02:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/1] get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE Content-Language: en-US To: "Metzger, Markus T" References: <20220424211541.70674-1-zied.guermazi@trande.de> <20220424211541.70674-2-zied.guermazi@trande.de> From: Zied Guermazi In-Reply-To: X-PPP-Message-ID: <20220425070227.115335.90861@host202.checkdomain.de> X-PPP-Vhost: trande.de X-Originating-IP: 185.137.168.148 X-SecureMailgate-Domain: host202.checkdomain.de X-SecureMailgate-Username: 185.137.168.148 Authentication-Results: secure-mailgate.com; auth=pass smtp.auth=185.137.168.148@host202.checkdomain.de X-SecureMailgate-Outgoing-Class: ham X-SecureMailgate-Outgoing-Evidence: SB/global_tokens (0.00928925272569) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT8QfHZSxzexUA8pyIqdBJOOPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5xepKJyYLZISh0ScmnJxtOQL++T0fzDkcbraJCnPSgcQrqW ghmgrvbuYBMbgPFqhEjKF590ee3aGyyzch48U9RYPumU89c8OaxcWLmp7ynpEhRNjsTGMD1b0Qb8 5iijp1HasE0yYSwoSJtDBJTXEF44+qKA9WNimSzzMEEnsLmJnD3bQmEqUddg4pDcHxi62gxzSOZO aYOlkYc6lCBjGxXRtrdIeJGUu23VykQIijZdTFmpY3ZEt1L/xHpIrLXSv09dmhE0Cjtkk/HF/Kxy ZirN3HjrAG8VuBgM4i9bc+OM5H6YFrhxVw5i30CZMe0+JKoB15eMIME6iZU0/33rc4pTBldNoc4/ ugpbufbubK+x4vA/QHsSr98zh4ylHHSOvF4EizIlMC06U8aFKFbkglvNo7UbuWzwvM5eRjzlfUYD MWFgOK8gW+hazh84oBeMtGGs+REr5it4yuwWmXN5FmKajBUnmlmmmmIH8Dg80WcRp+fC5fGvBaRW nWe6WFte+h1HBQQL7n9+OTZ37LZfI/sW30YZMgUX6Z4ThlOFxTu4LUsF4GHuFWly2YtZO0AGnGQ3 T2YxzxB8woiuExubdcsml481x58OeqpgxEwDRkEDKwPt8rNcco5Lt6ku63DkksyWUQhsiRV7ToHt 3HSONnNjcxw3qqhc+N6cuEg4XWh5Fqb0FldYqp+kcqm+1aM0u7TM30nmVmKV/QL5kcJUMTdrWsPa k/yQylAhV2EiGMYLU+gZ8kRW3yj6wqwjQ36QzRPL7Rp7sTyiVa8HG50AexxrzznCpn9MRUzzcEJz OzmIv9M+m4WpRRDP6YzwkAPgQJbZw2WK4NzRiZTDVGmt15BzNCflaPsIqsBW58vnzO6f8wY++9st Rr5cPMeXVtYjjgoS0lYUUbappPJYB65JgjbmctgzcDoFd+96Xw4QUNtTnZZhiw7af43YPLSeyfeI qT7OqoqMIvCpZajrvxuS+2n0bmim7U+d9AZiaR2WxIbRcfP4wHlqBE95R7lrKCg7FGkTm3FqRDxU q50C08gBiOmGBiFMXZsNOH+1R01VtZLf6H6YFrhxVw5i30CZMe0+JKqWmKu/Exva/4bO4tpXcmDO vZQjnSGPGpsSE/xM+RnyGGWi2HOzq/csyFjkk1RUX5M= X-Report-Abuse-To: spam@node04.secure-mailgate.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" hi Markus, thanks for your feedback, please have a look below for the answers. On 25.04.22 07:03, Metzger, Markus T wrote: > Hello Zied, > >> diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c >> index b0d6dcd7cf1..a9aaa9c88b3 100644 >> --- a/gdb/nat/linux-btrace.c >> +++ b/gdb/nat/linux-btrace.c >> @@ -486,9 +486,10 @@ linux_enable_bts (ptid_t ptid, const struct >> btrace_config_bts *conf) >> if (fd.get () < 0) >> diagnose_perf_event_open_fail (); >> >> + long page_size = sysconf (_SC_PAGESIZE); > Please check the return value. You may just error out but we should > detect errors, at least. [Zied] according to man pages the returned values should not be below 1. I will check against it and write a warning message. > > >> struct perf_event_mmap_page *header = (struct perf_event_mmap_page *) >> data.get (); >> - data_offset = PAGE_SIZE; >> + data_offset = page_size; > Hmmm, I would have expected a compiler warning, here, since PAGE_SIZE is > now long and DATA_OFFSET is __u64. [Zied] I go a clean compilation on my machine. here is the outcome: "build_intel/gdb$ make   CXX    nat/linux-btrace.o   GEN    init.c   CXXLD  gdb " Do you recommend casting page_size to a __u64? > > >> /* Allocate the configuration page. */ >> - scoped_mmap data (nullptr, PAGE_SIZE, PROT_READ | PROT_WRITE, >> MAP_SHARED, >> + long page_size = sysconf (_SC_PAGESIZE); > Here, we'd also want to check the return value. [Zied] ok > > >> @@ -661,7 +663,7 @@ linux_enable_pt (ptid_t ptid, const struct >> btrace_config_pt *conf) >> size_t length; >> __u64 data_size; >> >> - data_size = (__u64) pages * PAGE_SIZE; >> + data_size = (__u64) pages * page_size; > Hmmm, this also looks like the compiler would want to warn about > signed and unsigned multiply. [Zied] No warnings observed. Do you recommend casting page_size to a __u64? > > Regards, > Markus. > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0,www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > -- Kind Regards Zied Guermazi