From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28707 invoked by alias); 17 Nov 2016 00:12:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28692 invoked by uid 89); 17 Nov 2016 00:12:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1096 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Nov 2016 00:12:39 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 82AAC12B8; Thu, 17 Nov 2016 00:12:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAH0CbgY022416; Wed, 16 Nov 2016 19:12:37 -0500 Subject: Re: [PATCH] gdb/tracepoint.c: Don't use printf_vma To: Joel Brobecker References: <1479251441-16443-1-git-send-email-palves@redhat.com> <20161116235831.GA4132@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1a578b5a-608e-b75e-7a68-687bae3c1aa8@redhat.com> Date: Thu, 17 Nov 2016 00:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116235831.GA4132@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00469.txt.bz2 On 11/16/2016 11:58 PM, Joel Brobecker wrote: >> I noticed that bfd's printf_vma prints to stdout directly: >> >> bfd-in2.h:202:#define printf_vma(x) fprintf_vma(stdout,x) >> >> This is a bad idea in gdb, where we should use >> gdb_stdout/gdb_stderr/gdb_stdlog, etc., to support redirection. >> >> Eliminate uses of sprintf_vma too while at it. >> >> Tested on Fedora 23, w/ gdbserver. >> >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * tracepoint.c (collection_list::add_memrange): Add gdbarch >> parameter. Use paddress instead of printf_vma. Adjust recursive >> calls. >> (collection_list::stringify): Use paddress and phex_nz instead of >> sprintf_vma. Adjust add_memrange call. >> * tracepoint.h (collection_list::add_memrange): Declare new method. > > How about adding an ARI rule for those? I think it would help > avoid this function creeping back in. Indeed, sounds like a good idea. > It's not very difficult, and I might be able to find some time > this weekend to take care of it. Thanks! -- Pedro Alves