From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kTw+M4xdE2YGnycAWB0awg (envelope-from ) for ; Sun, 07 Apr 2024 22:59:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1712545164; bh=SL+Gvt4oDsEZX1O+jWu4GW3LT3vLCLxmPVrAnVYbbGY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UrvFRGig7S2PvwNhWMOpGBEcXVKIN0l/n8EUYgAfAVnN3sIWF2ud36DCDaM2pAjeD SruowgABIfKBrH/Tjzq9UXwmXuDsDenV71v/g4fvj3jVpA3oVt25qgD6YIUGN+/Gjt svi4hM0TNWizT3DVLAxkVbZz7Tm/MiSgm1ojz/eo= Received: by simark.ca (Postfix, from userid 112) id B6BF41E0C0; Sun, 7 Apr 2024 22:59:24 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=IsKJT5Si; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6BCB41E092 for ; Sun, 7 Apr 2024 22:59:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4C9F3858408 for ; Mon, 8 Apr 2024 02:59:21 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0A9113858D28; Mon, 8 Apr 2024 02:58:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A9113858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A9113858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712545140; cv=none; b=WDkHIW9KpRy0aHr/1SHb0IQUIdTds+RWI8ID3T7qyQz4pmk1Ud2OF482zszkldhDrROge1fVaJ+0fhP9Qr9ZHQBzqNZALfqDng+eU1ZO+0n0IYfkE1g2a91YdPhblW3N4yX/8nPrsdTMZdHMZEvKlDfLtj9fJQRu83vnWKU4vXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712545140; c=relaxed/simple; bh=SL+Gvt4oDsEZX1O+jWu4GW3LT3vLCLxmPVrAnVYbbGY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=OyPzu/Rn2J0fVHEMgTjgvTUhMo+vixTKAzLkRMZlIv7qMNS30GGPTRmtLzoBoCU3iyYrayPBpEKYfi5xLNYkzqbiPsWStnojSVilXwjjk6D1YtqOZvUcFw5dSAbxlJg/dT/fj/uFSvZ8WdtWah3CIq6g1MhaDhRk78RjwN3xCoM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1712545138; bh=SL+Gvt4oDsEZX1O+jWu4GW3LT3vLCLxmPVrAnVYbbGY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IsKJT5SifCtgSBwu8kyQzNYERZcINo+fb7jXTl9p6tSWBFdMOmPBaK2LoleLPOEj2 yqOgxVrZDtlD1EqxvkEyLiTmuadEV7Nm9ATtBK300BcV3/knS7zl6f9jzuCHo6MtVM HLySY94DMaEeAH2yA4NGLee7KTb6r/ngCONc5HLA= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1D5081E092; Sun, 7 Apr 2024 22:58:57 -0400 (EDT) Message-ID: <1a509448-bd4f-4782-9848-15c6cd51d212@simark.ca> Date: Sun, 7 Apr 2024 22:58:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: ignore -Wregister instead of -Wdeprecated-register To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org, binutils@sourceware.org References: <20240311160715.90270-1-simon.marchi@efficios.com> <878r2opski.fsf@tromey.com> <0780826d-4649-45e8-b056-dcae2a513bb1@efficios.com> <08ccf2e8-6494-4bb4-bcf3-51bedf24ac24@efficios.com> <87wmpalfkl.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87wmpalfkl.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-04-06 10:40, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> In ada-lex.l, we already use `DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER`, > Simon> which for Clang translates to ignoring `-Wdeprecated-register` [1]. I think > Simon> that was produced when compiling as C++11, but now that we always compile as > Simon> C++17, Clang produces a `-Wregister` error [2]. > >>>> Can we just '#define register' in this file or somewhere nearby? > >>> We probably can, but ignoring the diagnostic seems safer and less hacky >>> to me. > > Simon> Just stumbled on this. Are you ok with the current patch, or would you > Simon> really prefer the #define approach? > > It's fine if you want to do it. I should really finish my rewrite of > this lexer. IMO flex causes more problems than it solves. > > Tom Ok, thanks, pushed. Simon