From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86746 invoked by alias); 18 Apr 2017 18:44:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85378 invoked by uid 89); 18 Apr 2017 18:44:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 18:44:36 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7223C3DBCC; Tue, 18 Apr 2017 18:44:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7223C3DBCC Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7223C3DBCC Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80B028328A; Tue, 18 Apr 2017 18:44:36 +0000 (UTC) Subject: Re: [RFA 5/5] Use ui_out_emit_list To: Tom Tromey , gdb-patches@sourceware.org References: <20170414022337.28368-1-tom@tromey.com> <20170414022337.28368-6-tom@tromey.com> From: Pedro Alves Message-ID: <1a1902d6-65c0-7ab4-2be9-ed1357f04dac@redhat.com> Date: Tue, 18 Apr 2017 18:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170414022337.28368-6-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00524.txt.bz2 On 04/14/2017 03:23 AM, Tom Tromey wrote: > This changes some spots to use ui_out_emit_list. This only touches > "easy" cases, where the cleanup was used in a block-structured way. > There's also one more use of ui_out_emit_tuple in here. > > ChangeLog > 2017-04-13 Tom Tromey > > * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Use > ui_out_emit_list. > * stack.c (print_frame): Use ui_out_emit_list. > * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Use > ui_out_emit_list. > * mi/mi-main.c (print_one_inferior) > (mi_cmd_data_list_register_names) > (mi_cmd_data_list_register_values, mi_cmd_list_features) > (mi_cmd_list_target_features, mi_cmd_trace_frame_collected): Use > ui_out_emit_list. > * mi/mi-interp.c (mi_on_normal_stop_1): Use ui_out_emit_list. > (mi_output_solib_attribs): Use ui_out_emit_list, > ui_out_emit_tuple. > * mi/mi-cmd-var.c (varobj_update_one): Use ui_out_emit_list. > * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames) > (mi_cmd_stack_list_args, list_args_or_locals): Use > ui_out_emit_list. > * disasm.c (do_assembly_only): Use ui_out_emit_list. > * breakpoint.c (print_solib_event, output_thread_groups): Use > ui_out_emit_list. LGTM. Thanks, Pedro Alves