Re: [PATCH 15/20] Add attribute::get_unsigned method

Tom Tromey
2020-04-04T14:17:08Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Instead, gdb_assert (!requires_reprocessing) should be added to
Simon> ::address and ::string.

I did this in the earlier patch.

Simon> Note that I don't mind if we leave the assert in this function,
Simon> it's true in any case that requires_reprocessing should be false
Simon> at this point.

I guess I'll leave it for completeness.

Simon> Also, I noted that this method is named "get_unsigned", since you
Simon> obviously can't name it "unsigned". If you used my idea to name
Simon> the others "as_string" and "as_address", this one could be
Simon> "as_unsigned", and the names would all be coherent.

Yep, I'm doing this throughout.

Tom