Re: [PATCH 13/20] Change how reprocessing is done

Tom Tromey
2020-04-04T14:14:49Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> + /* True if this attribute requires reprocessing. */
>> + bool reprocessing_p () const
>> + {
>> + return requires_reprocessing;
>> + }

Simon> Nitpicking on names again: the method name sounds like we inquire whether
Simon> the attribute is currently reprocessing (as if it was a lengthy operation).

Simon> So I'd name it requires_reprocessing_p. Or just requires_reprocessing (I still
Simon> find those _p suffixes for predicates odd).

Sounds good, I used requires_reprocessing_p.

Tom