Re: [PATCH 04/20] Change some uses of DW_STRING to string method

Tom Tromey
2020-03-30T23:53:45Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> In cases like this, I think it would be worth assigning the result of attr->string
Simon> to a local variable, to avoid paying the cost of the check multiple times
Simon> unnecessarily.

I made this change.

I did some profiling of the DWARF reader recently and I think that some
of these methods should probably be inlined as well. I'll double-check
... my profiling was on a branch without this series, but inlining
form_is_ref and part of get_ref_die_offset was a win.

Tom