Re: [PATCH 07/20] Remove DW_BLOCK

Simon Marchi
2020-03-30T15:13:37Z

On 2020-03-28 3:21 p.m., Tom Tromey wrote:
> @@ -22578,8 +22578,8 @@ dwarf2_symbol_mark_computed (const struct attribute *attr, struct symbol *sym,
> info_buffer for SYM's objfile; right now we never release
> that buffer, but when we do clean up properly this may
> need to change. */
> - baton->size = DW_BLOCK (attr)->size;
> - baton->data = DW_BLOCK (attr)->data;
> + baton->size = attr->block ()->size;
> + baton->data = attr->block ()->data;

Again, in these cases, it would probably be worth using a local variable to store
the result of attr->block (), to avoid doing the check twice.

Simon