Re: [PATCH 11/20] Add reprocessing flag to struct attribute

Tom Tromey
2020-04-04T14:02:24Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> The name is odd, the "form" isn't reprocessed. What would you think of
Simon> "form_requires_processing"?

Seems good, I made this change and the others.

Simon> The "requires_reprocessing" field implicitly
Simon> means "attribute_requires_reprocessing". But if we want to avoid confusion
Simon> between the two, the field could be renamed "reprocessing_done", and its
Simon> logic inverted.

I think it is fine as-is, especially with the expanded comment.

Tom