From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94474 invoked by alias); 23 Aug 2017 12:44:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84267 invoked by uid 89); 23 Aug 2017 12:44:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 spammy=realise X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40076.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.76) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 12:44:35 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0167.eurprd08.prod.outlook.com (10.161.35.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Wed, 23 Aug 2017 12:44:31 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::3d9d:a238:3471:1cc3]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::3d9d:a238:3471:1cc3%16]) with mapi id 15.01.1362.019; Wed, 23 Aug 2017 12:44:31 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 0/7] Regcache: Split out target regcache functionality Date: Wed, 23 Aug 2017 12:44:00 -0000 Message-ID: <1C4B1DB0-3C45-4C1F-A864-C5748CCBB0C0@arm.com> References: <86valer48e.fsf@gmail.com> In-Reply-To: <86valer48e.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0167;6:WVIaCIAD89/ZCQ1wkH6P3wnVfJBFp+lzx+tg/6/uTtQMcOV3+9UEwv0LP2HqanWxgfkf/XxBCGV9pjWuk8+u0KaFDPzbI2sXj+XapCUQ0rNf8pVNM/xZigdIqdeKXj0as/K173VzvatyxfQtjA1VdLHiNpvYtV35FZT9dPpiJce23CrosiirQSC/hWqyHY/lfZSEkgFQDBJ4amewJVJB9AFbQrdi8qAyt4MmLC35I+Wnkg4wyD6kUgjZTUXqSV3941nMDj3aE6cZ1onV+OWWLyD1aQnOJeeAd0hWzDiwenKtXEPFd0XunuP0NzjFt0jIgWtdTaKAQuGDFtlDbrh3Dg==;5:N9nIU9ph8E40eYIM5+JwJ6ObZMdQLO3nWiM1RjMv1EjoWa5W+FcMVTntlAffBq2f3inE7JRohFZF5X9XSy+J3MoxTsMCYlRALs0UP2/NnHNAM5LI/A5anFSNRzslgCiDhFRQfuKEDmL5D8xIqwT2qw==;24:VCiUMuWUYWMpW48sxz8GyuYmYYDvyVpGFD6OuSBahV8XW/lYbCQQD90WtC9J4Nu4lhyBSpLmJg0YdjgZlXinB4GRxpxnGX259zj7AUEYhJs=;7:AHZWBJlA2BTpykYvx4rbuF6wwu4DSMnxjgLvkQQ9S9aix41ReHitumguSdfne/gxaLnt1uu5GyDoFUJpp5B+SE5YLnHKrZwbuRpuvCmt5TxDwseRyR08ITD03BwtEchK17kl/y0/PAWFsAzV1hm2zxyiGx4xaB7WqK8JWaUsv4dQu2xmLkjqP68KmHIs87YdNfX64PQ12Bk/d67L5BzRrzTOwbTZXnA+MCwzT4ChrfM= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e2a2778c-492d-4b03-196e-08d4ea24b34b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603184)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM3PR08MB0167; x-ms-traffictypediagnostic: AM3PR08MB0167: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(180628864354917); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0167;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0167; x-forefront-prvs: 040866B734 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(39860400002)(24454002)(199003)(189002)(68736007)(6512007)(2900100001)(3660700001)(4743002)(110136004)(102836003)(478600001)(6306002)(33656002)(2950100002)(6916009)(6116002)(99286003)(3280700002)(7736002)(101416001)(53936002)(54906002)(36756003)(3846002)(39060400002)(2906002)(305945005)(82746002)(966005)(66066001)(6486002)(5660300001)(4326008)(8936002)(6506006)(1411001)(8676002)(5890100001)(83716003)(81166006)(81156014)(106356001)(72206003)(6246003)(53546010)(14454004)(105586002)(50986999)(86362001)(5250100002)(229853002)(97736004)(54356999)(189998001)(25786009)(76176999)(6436002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0167;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2017 12:44:31.2910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0167 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00439.txt.bz2 DQo+IE9uIDIzIEF1ZyAyMDE3LCBhdCAxMTowMiwgWWFvIFFpIDxxaXlhb2x0 Y0BnbWFpbC5jb20+IHdyb3RlOg0KPiANCj4gQWxhbiBIYXl3YXJkIDxBbGFu LkhheXdhcmRAYXJtLmNvbT4gd3JpdGVzOg0KPiANCj4+IEEgdGFyZ2V0X3Jl Z2NhY2hlIGlzIGEgcmVnY2FjaGUgY29ubmVjdGVkIHRvIGEgdGFyZ2V0LiBS ZWFkcyBhbmQNCj4+IHdyaXRlcyBvZiByZWdpc3RlciB2YWx1ZXMgYXJlIHBh c3NlZCB0aHJvdWdoIHRvIHRoZSB0YXJnZXQuDQo+PiBBIHRhcmdldF9yZWdj YWNoZSBjYW5ub3QgYmUgcmVhZG9ubHkgKGJlY2F1c2UgdGhpcyBkb2Vzbid0 IG1ha2UNCj4+IHNlbnNlKS4NCj4gDQo+IEF0IHRoaXMgc3RhZ2UsIGNhbiB3 ZSBkb24ndCBhc3N1bWUgdGhlIHJlYWRvbmx5LW5lc3Mgb2YgdGFyZ2V0X3Jl Z2NhY2hlPw0KPiBodHRwczovL3NvdXJjZXdhcmUub3JnL21sL2dkYi1wYXRj aGVzLzIwMTctMDcvbXNnMDAyNTIuaHRtbA0KDQpPaywgSSBkaWRu4oCZdCBy ZWFsaXNlIGNvcmUgZmlsZXMgd2VyZSB0cmVhdGVkIGFzIGEgdGFyZ2V0Lg0K SSBuZWVkIHRvIGxvb2sgYXQgdGhlIGNvZGUgbW9yZSBmb3IgdGhpcywgYnV0 IEkgY291bGRu4oCZdCBmaW5kIGFueXRoaW5nIGluIHRoZQ0KZXhpc2l0aW5n IGNvZGUgdGhhdCBtYWtlcyBhIGNvcmUgcmVjYWNoZSByZWFkb25seS4NCklm IHNvLCBtYXliZSBpdOKAmXMgbXkgY29kZSB0aGF0IG5lZWRzIHRvIGFkZCB0 aGlzIGZ1bmN0aW9uYWxpdHkuDQoNCj4gDQo+PiANCj4+IE1lYW53aGlsZSwg YSByZWdjYWNoZSAoc29tZXRpbWUgcmVmZXJyZWQgdG8gYXMgYSBkZXRhY2hl ZCByZWdjYWNoZSkNCj4+IGlzIG5vdCBjb25uZWN0ZWQgdG8gYSB0YXJnZXQu IEJ5IGRlZmF1bHQgaXQgaXMgcmVhZG9ubHksIGJ1dCBkb2VzDQo+PiBub3Qg aGF2ZSB0byBiZS4gSW4gYWRkaXRpb24gdG8gdGhlIHJhdyByZWdpc3RlcnMg YSByZWdjYWNoZSBhbHNvDQo+PiBjYWNoZXMgY29va2VkIHJlZ2lzdGVyIHZh bHVlcy4gRHVwbGljYXRpbmcgYSB0YXJnZXRfcmVnY2FjaGUgd2lsbA0KPj4g YWx3YXlzIHJlc3VsdCBpbiBhIGRldGFjaGVkIHJlZ2NhY2hlLg0KPj4gDQo+ PiBCb3RoIHJlZ2NhY2hlIGFuZCB0YXJnZXRfcmVnY2FjaGUgc3VwcG9ydCB0 aGUgZnVsbCBzZXQgb2YgcmF3X3JlYWQsDQo+PiByYXdfd3JpdGUsIHJhd19j b2xsZWN0LCByYXdfc3VwcGx5LCBjb29rZWRfcmVhZCwgY29va2VkX3dyaXRl DQo+PiBmdW5jdGlvbnMgYW5kIGFsbCB0aGVpciB2YXJpYXRpb25zLiBBIHVz ZXIgb2YgYSByZWdhY2hlIGRvZXMgbm90DQo+PiBuZWVkIHRvIHRyZWF0IHRo ZSB0d28gdHlwZXMgYW55IGRpZmZlcmVudGx5IC0geW91ciByZWdjYWNoZSBq dXN0DQo+PiBkb2VzIHRoZSBjb3JyZWN0IHRoaW5nLiBGb3IgZXhhbXBsZSwg b24gYSB0YXJnZXRfcmVnY2FjaGUsDQo+PiByYXdfd3JpdGUgd2lsbCB3cml0 ZSB0byBib3RoIHRoZSBjYWNoZSBhbmQgdGhlIHRhcmdldCwgYnV0IG9uDQo+ PiBhIHJlY2FjaGUgaXQgd2lsbCBvbmx5IHdyaXRlIHRvIHRoZSBjYWNoZS4N Cj4+IA0KPj4gV2l0aCB0aGlzIHNldCBvZiBwYXRjaGVzLCB0aGUgcmVnY2Fj aGUgZm9yIHRoZSBjdXJyZW50IHRocmVhZCAoYXMNCj4+IGdpdmVuIGJ5IGdl dF9jdXJyZW50X3JlZ2NhY2hlKCkpLCBpcyBub3cgYSB0YXJnZXRfcmVnY2Fj aGUsIHRoYXQNCj4+IHdpbGwgcGVyZm9ybSBleGFjdGx5IHRoZSBzYW1lIGZ1 bmN0aW9uYWxpdHkgYXMgdGhlIHJlZ2NhY2hlIGluDQo+PiB0aGUgZXhpc2l0 aW5nIGhlYWQuDQo+PiANCj4+IEFuIGVhcmxpZXIgcGxhbiBmb3IgdGhpcyBz ZXQgb2YgcGF0Y2hlcyB3YXMgdGhhdCB0aGUgZGV0YWNoZWQNCj4+IHJlZ2Nh Y2hlIHdvdWxkIG5vdCBzdXBwb3J0IHJhd193cml0ZSwgcmF3X2NvbGxlY3Qs IGNvb2tlZF9yZWFkLA0KPj4gY29va2VkX3dyaXRlLiBUaGUgcHJvYmxlbSBp cyBtYW55IG9mIHRoZSB0YXJnZXQgaG9va3MgdGhlbiBuZWVkDQo+IA0KPiBN eSBzdWdnZXN0aW9uIHdhcyB0aGF0IGRldGFjaGVkIHJlZ2NhY2hlIGRvZXNu J3QgaGF2ZQ0KPiB7cmF3LGNvb2tlZH1fe3JlYWQsd3JpdGV9XyBtZXRob2Rz LCBvbmx5IGhhcyBjb2xsZWN0IGFuZCBzdXBwbHkgbWV0aG9kcy4NCj4gYW5k IGF0dGFjaGVkIG9uZSBoYXMge3Jhdyxjb29rZWR9X3tyZWFkLHdyaXRlfV8g bWV0aG9kcy4NCj4gaHR0cHM6Ly9zb3VyY2V3YXJlLm9yZy9tbC9nZGItcGF0 Y2hlcy8yMDE3LTA3L21zZzAwMTI3Lmh0bWwNCg0KQWdyZWVkLiBUeXBvIGlu IG15IGRlc2NyaXB0aW9uLg0KDQo+IA0KPj4gdXBkYXRpbmcgdG8gb25seSBh Y2NlcHQgdGFyZ2V0X3JlZ2NhY2hlLiBNYW55IG9mIHRoZSBpbXBsZW1lbnRh dGlvbnMNCj4+IG9mIHRoZSB0YXJnZXQgaG9va3MgdGhlbiBjYWxsIGJhY2sg aW50byB0aGUgcmVnY2FjaGUsIGNhdXNpbmcgdGhvc2UNCj4+IGZ1bmN0aW9u cyBpbiB0dXJuIHRvIGJlIGRlcGVuZGFudCBvbiB0aGUgbmV3IGNsYXNzZXMs IGV4cGxvZGluZyB0aGUNCj4+IHNpemUgb2YgdGhlIHBhdGNoLiBJdCB0aGVu IGJlY29tZSB2ZXJ5IGZpZGRseS9jb25mdXNpbmcgdG8gbWFpbnRhaW4NCj4+ IHdoaWNoIHR5cGUgb2YgcmVnY2FjaGUgaXMgcmVxdWlyZWQgYXQgYW55IHBv aW50Lg0KPiANCj4gdGFyZ2V0IGhvb2tzIHNob3VsZCBjYWxsIHJlZ2NhY2hl IHN1cHBseSBhbmQgY29sbGVjdCBtZXRob2RzLCBJTU8uDQo+IA0KDQpBZ3Jl ZWQgaW4gcHJpbmNpcGxlLCBidXQgdGhpcyBpcyB3b3VsZCBiZSBhIGxhcmdl IGNoYW5nZSENCkl0IGNvdWxkIGhhdmUgaGlkZGVuIHNpZGUgZWZmZWN0cyAt IGEgdGFyZ2V0IHRoYXQgY2FsbHMgY29va2VkX3JlYWQgbWlnaHQgYmUNCmV4 cGVjdGluZyB0byByZWFkIGEgcHNldWRvIHJlZy4NCg0KSSB3YW50ZWQgdG8g YXZvaWQgdGhhdCBjaGFuZ2UgaW4gdGhpcyBwYXRjaCBzZXJpZXMuDQoNCkEg bGF0ZXIgc2V0IG9mIHBhdGNoZXMgY291bGQgY2hhbmdlIHRoZSB0YXJnZXRz IHRvIG9ubHkgY2FsbCBzdXBwbHkvY29sbGVjdA0KbWV0aG9kcy4gUG9zc2li bHkgb25lIHRhcmdldCBhdCBhIHRpbWUuIE9uY2UgdGhpcyBpcyBmaXhlZCwg dGhlbiB0aGUgYWRkaXRpb25hbA0KbWV0aG9kcyBjYW4gYmUgcmVtb3ZlZCBm cm9tIGRldGFjaGVkIHJlZ2NhY2hlcy4NCg0KPiAtLSANCj4gWWFvICjpvZDl sKcpDQoNCg== >From gdb-patches-return-141148-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Aug 23 13:07:37 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 44172 invoked by alias); 23 Aug 2017 13:07:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 44145 invoked by uid 89); 23 Aug 2017 13:07:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 13:07:34 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 48956267E0; Wed, 23 Aug 2017 13:07:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 48956267E0 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DBE1A7DD00; Wed, 23 Aug 2017 13:07:32 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , GCC Patches , Tom Tromey , Keith Seitz , Phil Muldoon , Alexandre Oliva Subject: Re: [libcc1] Improve detection of triplet on compiler names References: <87mv6qhq9u.fsf@redhat.com> <74900a91-685b-2bdc-6cb7-8333ce9c5d0a@redhat.com> Date: Wed, 23 Aug 2017 13:07:00 -0000 In-Reply-To: <74900a91-685b-2bdc-6cb7-8333ce9c5d0a@redhat.com> (Pedro Alves's message of "Wed, 23 Aug 2017 10:20:33 +0100") Message-ID: <87a82qh1pn.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00440.txt.bz2 Content-length: 1994 On Wednesday, August 23 2017, Pedro Alves wrote: > On 08/23/2017 05:17 AM, Sergio Durigan Junior wrote: >> The GCC patch improves the libcc1::compiler_triplet_regexp::find and >> libcp1::compiler_triplet_regexp::find methods by first trying to match >> the triplet in the compiler name and correctly discarding the triplet >> part of the regexp if the matching succeeds. I've had to do a few >> modifications on the way the regexp's are built, but I'll explain them >> in the patch itself. >> >> The GDB patch is very simple: it adds the trailing "-" in the triplet >> regexp. Therefore, we will have a regexp that truly matches the full >> triplet (e.g., "^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?-") instead of one >> that leaves the trailing "-" match to libcc1. >> >> I've tested this patch both on my Fedora and my Debian machines, and >> both now work as expected, independently of the presence of the triplet >> string in the compiler name. I am sorry about the cross-post, but these >> patches are really dependent on one another. > > Is there a backward/forward compatibility impact? Unfortunately, yes. > Does new GDB work with old GCC? No. On Fedora systems, you would get: Could not find a compiler matching "^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?--gcc$" And on Debian: Could not find a compiler matching "^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?--x86_64-linux-gnu-gcc-7$" > Does old GDB work with new GCC? The situation would be the inverse of what's currently happening. Old Fedora GDBs would now be broken: Could not find a compiler matching "^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?gcc$" But old Debian GDBs would now start working. As can be seen, these failures are now happening because of the trailing dash that is now included in the triplet regexp by GDB. I don't know if that warrants a change in the API, though. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/