From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69573 invoked by alias); 19 Jan 2018 16:55:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69558 invoked by uid 89); 19 Jan 2018 16:55:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jan 2018 16:55:27 +0000 Received: by mail-wm0-f66.google.com with SMTP id r78so4869343wme.0 for ; Fri, 19 Jan 2018 08:55:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7DCLx21ehmEPD96fGh+2dimVs1lZbTLM+hFlE0Ybr+Q=; b=pA0ONEaMPuNiNmclJebeble2UA0E62cewhrnOiP6ZzuNsAx7fskT05TC0IrldYc3ja GGdwYxQH6C1rzKBCkaf4y9Hf2jvut0gQgG/SruYvJyiY3fE85tLhzmNFaoTMBDKB5mgb 1O9oQoGPDn0eECTSAdozj7lyns7qN3++lNTQc4O5RMtDxg7cbRXbcKvXWlD2oWxv8wvD vvJkHDMZveIrnDAG3tvq1sU2TZWPJGbORfYj9EX88CxwVBTyCZ1MHRHQzziLdW9l6Y8P hVMBuY+YedVvwCAWQM4HvLtYrKyBDXDUcT7N+QGeM/4MCd809OnhJXvLj+GQJoTCqIyJ CUzA== X-Gm-Message-State: AKwxytflb/3vsLL9y7o/zZAdNPOVzJb5YTQLsfS2TRNIFXN/4JQgmBfO LjEA09lQigYSIz5E0dWjtvm66UaoZ6E= X-Google-Smtp-Source: ACJfBoulhLNZGdVnWwFQnH7sr1YkV4LGlP6bBrNWBjNqtjzEb8DnGWVhh7x5kJ4yYb38My0lRrKbgA== X-Received: by 10.28.109.10 with SMTP id i10mr5186525wmc.107.1516380924815; Fri, 19 Jan 2018 08:55:24 -0800 (PST) Received: from eduroam-jrtc4-35d43e-2.trin.private.cam.ac.uk (global-184-7.nat-1.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id w73sm26205047wrb.34.2018.01.19.08.55.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jan 2018 08:55:24 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver From: James Clarke In-Reply-To: Date: Fri, 19 Jan 2018 16:55:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <1BA91B1E-5E4A-4084-822C-3A35ADB4390C@jrtc27.com> References: <20171215000434.47315-1-jrtc27@jrtc27.com> <20171215000434.47315-2-jrtc27@jrtc27.com> To: Pedro Alves X-SW-Source: 2018-01/txt/msg00403.txt.bz2 On 19 Jan 2018, at 16:48, Pedro Alves wrote: > On 12/15/2017 12:04 AM, James Clarke wrote: >> gdb/ChangeLog: >> * gdbserver/linux-low.c (handle_extended_wait): Surround call to >> thread_db_notice_clone with #ifdef USE_THREAD_DB. >> --- >> [Originally erroneously sent to the binutils mailing list] >=20 > Looks OK, but could you remind me what goes wrong if we > don't do this? Does gdbserver fail to link? Yes, with the expected: > [...]/linux-low.c:664: undefined reference to `thread_db_notice_clone(thr= ead_info*, ptid_t)' Every other use of thread_db_* is guarded by USE_THREAD_DB, so I assume it's fine to do here too. Regards, James