From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112379-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14017 invoked by alias); 14 May 2014 21:11:32 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13824 invoked by uid 89); 14 May 2014 21:11:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: ausc60pc101.us.dell.com
Received: from ausc60pc101.us.dell.com (HELO ausc60pc101.us.dell.com) (143.166.85.206) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 14 May 2014 21:11:29 +0000
X-LoopCount0: from 10.170.28.39
From: <Paul_Koning@Dell.com>
To: <dje@google.com>
CC: <gbenson@redhat.com>, <gdb-patches@sourceware.org>, <tromey@redhat.com>
Subject: Re: [PATCH] Prompt user to report bugs
Date: Wed, 14 May 2014 21:11:00 -0000
Message-ID: <1B70C5D6-D845-4F9A-A874-63DF77FB9030@dell.com>
References: <20140514110742.GA25550@blade.nx> <CADPb22T0DvL237NkheQ1h0onABvTPUKkXXxZu2Uzh3WdpSbgVA@mail.gmail.com>
In-Reply-To: <CADPb22T0DvL237NkheQ1h0onABvTPUKkXXxZu2Uzh3WdpSbgVA@mail.gmail.com>
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <15FECC0D03B70949A6C4533F58F7F391@dell.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-IsSubscribed: yes
X-SW-Source: 2014-05/txt/msg00217.txt.bz2


On May 14, 2014, at 5:05 PM, Doug Evans <dje@google.com> wrote:

> On Wed, May 14, 2014 at 4:07 AM, Gary Benson <gbenson@redhat.com> wrote:
>> Hi all,
>>=20
>> This patch prints a couple of extra lines in internal_vproblem
>> to prompt the user to report the bug that's just happened.
>>=20
>> Ok to commit?
>>=20
>> Thanks,
>> Gary
>>=20
>> --
>> 2014-05-14  Gary Benson  <gbenson@redhat.com>
>>=20
>>        * utils.c (internal_vproblem): Prompt the user to file a report.
>>=20
>> diff --git a/gdb/utils.c b/gdb/utils.c
>> index a8a7cb3..905ce6d 100644
>> --- a/gdb/utils.c
>> +++ b/gdb/utils.c
>> @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *problem,
>>   else
>>     internal_error (__FILE__, __LINE__, _("bad switch"));
>>=20
>> +  fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_stderr=
);
>> +  if (REPORT_BUGS_TO[0])
>> +    {
>> +      fputs_unfiltered (_("  For instructions, see:\n"), gdb_stderr);
>> +      fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO);
>> +    }
>> +  fputs_unfiltered ("\n\n", gdb_stderr);
>> +
>>   if (problem->should_dump_core =3D=3D internal_problem_ask)
>>     {
>>       if (!can_dump_core (reason))
>>=20
>=20
> top.c doesn't wrap "%s." in _().
> I don't know if it matters, it's just odd to see "%s." wrapped.


It also seems odd to see =93%s.=94 inside _( ) since there=92s nothing to t=
ranslate there.

	paul