From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25141 invoked by alias); 14 Mar 2018 10:09:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24753 invoked by uid 89); 14 Mar 2018 10:09:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0084.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Mar 2018 10:09:48 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0182.eurprd08.prod.outlook.com (10.161.35.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 10:09:39 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::64e8:8f30:eae8:a839]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::64e8:8f30:eae8:a839%13]) with mapi id 15.20.0567.018; Wed, 14 Mar 2018 10:09:38 +0000 From: Alan Hayward To: Philipp Rudo CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v3 6/8] Create xml from target descriptions Date: Wed, 14 Mar 2018 10:09:00 -0000 Message-ID: <1B0658F7-832C-4C8E-A614-BAC073ACDCE4@arm.com> References: <757A8B89-2EF0-46BD-BAA6-6E668538B17F@arm.com> <20180313190516.7f0b6443@ThinkPad> In-Reply-To: <20180313190516.7f0b6443@ThinkPad> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0182;6:FtnQgPqLlAtIGtdGc2fVp3NU2EEtbkAb4+DtFQwTW8v6LaGF9WmXXlgNoMzbsC7jDztpipIB1Kup1H03kqbtRU2AvOYk+Az3wSArI1pQE0noxJS0DKXWL9Tr0TJlPOYYQYRGtnU+Ma91giJlOLQ22CFjQTEprYvnvZQ93Eylh5Fvb/atH39Ya2S7boHjpGvAkyLJYhl6TXRapjoiZjL2BVFFVxHm34AN8EgTwFR0B+zvpQXkEwgPYhnRFzO1/ff4ychWXCoxfx0AAYjVOmCe6qcrcjg8HJHfWtv8yDwpI+IV9BKOX9nnY0r596AIMmF9A8pkFdQaDVPQHSUk8yW0Kr6vloAjxbSnc+cdKMNeZTok9pjiJiwRSc5Je0dlC/MK;5:6UisKzOnBzCGRuPIYfvUMQsgyKW0NiFahfHvqF7yBk1TaK+HrW9V+IFIAqGyE3HtC1nEUgHGgtUqnkqFdByGVO19YFtehwRUxY6XZT7dh6LLKePnlyfFQi2XwKBeBLrpcOB+mjy14RPTIclQ4pbfjNKf23VdlCtPv3jpaqxf8Bw=;24:v+2+GMf3rqcfWjc9ehlEVEfjBTs2wjAct/iXaGtaHSeKhu5wXiLYZgajtoct6oPKWYdpxseKSW2sWQwydQPBD4fFnBPRtKWEeaym4DW9dA8=;7:JaYXVqur2rOyEwzecWAqo+/ekJEA0gJadOCBpWJxnguvAqkLtlSgWyGkK9TFMKuhkGuIW1+YISTqCc6c+twfJKnaS09brbbALTZEbgWYkbI9S5J9NhnBdHgtRMC3xFMu8VHuVM9tjJCSLC3DUV0dsxgYvzjD9uw4tDOPTFAf9PKEs3x83wNAHgJrDyFaiz4xa9/FNv05m9SDmnFkS1hUIW3vD9Dr4ptPJiszN6lI7yMwDdwwLRsu+DV0k60g08HA x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ca39e209-57c7-4d9d-6fbf-08d58993b254 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:AM3PR08MB0182; x-ms-traffictypediagnostic: AM3PR08MB0182: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(180628864354917)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:AM3PR08MB0182;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0182; x-forefront-prvs: 0611A21987 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(39860400002)(376002)(39380400002)(396003)(346002)(199004)(189003)(3280700002)(6246003)(53546011)(3660700001)(83716003)(68736007)(54906003)(99286004)(25786009)(575784001)(59450400001)(478600001)(72206003)(6506007)(82746002)(86362001)(229853002)(4326008)(2906002)(3846002)(14454004)(6116002)(102836004)(6486002)(6436002)(81166006)(97736004)(81156014)(76176011)(8936002)(8676002)(316002)(26005)(2950100002)(186003)(105586002)(6916009)(36756003)(7736002)(106356001)(2900100001)(66066001)(305945005)(5660300001)(33656002)(53936002)(6512007)(5250100002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0182;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: YdjBHlkz2AiamcWrWhBCXTop55cyU7TiJGqecubG+jTu3zX5lJ2rOrJs+oof81pse+SWLcUS4aY6dzdjaSsYeA4qXOYdjlCurafLbYDPy4MZVMiY6HI4+YnTEuhpBFh3Rz+/Xg14Mlfo9S+htmLjkRO3mH4Uz6prkiq/sjwFxpqyZ6z1qsgdHmj3rk4hCF+OdncKKl129rvgHVCpHG5E61JPb5RItv3zc9HJ0vmzJPlenuAhVOtcWPg1D4YE0cyX4iLbAwEjlSjsuAvH2EDGSf75yPbC5QRJB/z7xqbniQd+Cf2goeHRqaqgnKuFIQkvwbloETJ0Mv7lCnckiJyrPw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <4877BC37D1E48A479DB724BDDA6AC8DC@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca39e209-57c7-4d9d-6fbf-08d58993b254 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2018 10:09:38.5525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0182 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00278.txt.bz2 DQoNCj4gT24gMTMgTWFyIDIwMTgsIGF0IDE4OjA1LCBQaGlsaXBwIFJ1ZG8g PHBydWRvQGxpbnV4LnZuZXQuaWJtLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBB bGFuLA0KPiANCj4gT24gVGh1LCAxIE1hciAyMDE4IDExOjQxOjA0ICswMDAw DQo+IEFsYW4gSGF5d2FyZCA8QWxhbi5IYXl3YXJkQGFybS5jb20+IHdyb3Rl Og0KPiANCj4gWy4uLl0NCj4gDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL2NvbW1v bi90ZGVzYy5jIGIvZ2RiL2NvbW1vbi90ZGVzYy5jDQo+PiBpbmRleCAxMTVl N2NkNzc5NDJiODZkZWRjZWQ5NDY3NzNkMWQ3MTk1MGUyYmIzLi5jZTViODkw NDVjNDhjNjVhYzRjNmM0OGY2NjQ2ZjhkNWM2Y2U5ZDhiIDEwMDY0NA0KPj4g LS0tIGEvZ2RiL2NvbW1vbi90ZGVzYy5jDQo+PiArKysgYi9nZGIvY29tbW9u L3RkZXNjLmMNCj4+IEBAIC0yODgsNCArMjg4LDE1OCBAQCB0ZGVzY19hZGRf ZW51bV92YWx1ZSAodGRlc2NfdHlwZV93aXRoX2ZpZWxkcyAqdHlwZSwgaW50 IHZhbHVlLA0KPiANCj4gWy4uLl0NCj4gDQo+PiArdm9pZCBwcmludF94bWxf ZmVhdHVyZTo6dmlzaXQgKGNvbnN0IHRkZXNjX3JlZyAqcmVnKQ0KPj4gK3sN Cj4+ICsgICptX2J1ZmZlciArPSAiPHJlZyBuYW1lPVwiIjsNCj4+ICsgICpt X2J1ZmZlciArPSByZWctPm5hbWU7DQo+PiArICAqbV9idWZmZXIgKz0gIlwi IGJpdHNpemU9XCIiOw0KPj4gKyAgKm1fYnVmZmVyICs9IHN0ZDo6dG9fc3Ry aW5nIChyZWctPmJpdHNpemUpOw0KPj4gKyAgKm1fYnVmZmVyICs9ICJcIiB0 eXBlPVwiIjsNCj4+ICsgICptX2J1ZmZlciArPSByZWctPnR5cGU7DQo+PiAr ICAqbV9idWZmZXIgKz0gIlwiIHJlZ251bT1cIiI7DQo+PiArICAqbV9idWZm ZXIgKz0gc3RkOjp0b19zdHJpbmcgKHJlZy0+dGFyZ2V0X3JlZ251bSk7DQo+ PiArICBpZiAocmVnLT5ncm91cC5sZW5ndGggKCkgPiAwKQ0KPj4gKyAgICB7 DQo+PiArICAgICAgKm1fYnVmZmVyICs9ICJcIiBncm91cD1cIiI7DQo+PiAr ICAgICAgKm1fYnVmZmVyICs9IHJlZy0+Z3JvdXA7DQo+PiArICAgIH0NCj4+ ICsgICptX2J1ZmZlciArPSAiXCIvPlxuIjsNCj4+ICt9DQo+IA0KPiBpbiB0 aGUgeG1sIHlvdSBjYW4gYWxzbyBzZXQgaWYgYW4gcmVnaXN0ZXIgaXMgZ2V0 cyBzYXZlX3Jlc29yZSwgaS5lIA0KPiANCj4gaWYgKCFyZWctPnNhdmVfcmVz dG9yZSkNCj4gICptX2J1ZmZlciArPSAiXCIgc2F2ZS1yZXN0b3JlPVwibm/i gJ07DQoNCkEgc3BlY2lhbCAzOTAgZmxhZyA6KQ0KSeKAmWxsIGRvdWJsZSBj aGVjayBtYWtlIHN1cmUgSSBoYXZlbuKAmXQgbWlzc2VkIGFueSBvdGhlciBm bGFncyB0b28uDQoNCg0KPiANCj4gWy4uLl0NCj4gDQo+PiBkaWZmIC0tZ2l0 IGEvZ2RiL3JlZ2Zvcm1hdHMvcmVnZGF0LnNoIGIvZ2RiL3JlZ2Zvcm1hdHMv cmVnZGF0LnNoDQo+PiBpbmRleCA4YzZlMTkxNTk2MzUwZmI0ZTk4M2Y4NzM2 OTg1ZDk4MzJmNDFlMmQzLi5lNmUwNmJkYWIwYmRlY2M1Nzk2ODZmMzUyNWU5 ZjkzNTU1ZTBkZDgzIDEwMDc1NQ0KPj4gLS0tIGEvZ2RiL3JlZ2Zvcm1hdHMv cmVnZGF0LnNoDQo+PiArKysgYi9nZGIvcmVnZm9ybWF0cy9yZWdkYXQuc2gN Cj4+IEBAIC0xODAsNyArMTgwLDYgQEAgZWNobw0KPj4gY2F0IDw8RU9GDQo+ PiAjaWZuZGVmIElOX1BST0NFU1NfQUdFTlQNCj4+ICAgcmVzdWx0LT5leHBl ZGl0ZV9yZWdzID0gZXhwZWRpdGVfcmVnc18ke25hbWV9Ow0KPj4gLSAgcmVz dWx0LT54bWx0YXJnZXQgPSB4bWx0YXJnZXRfJHtuYW1lfTsNCj4+ICNlbmRp Zg0KPj4gDQo+PiAgIGluaXRfdGFyZ2V0X2Rlc2MgKHJlc3VsdCk7DQo+IA0K PiBUaGlzIGh1bmsgY2F1c2VkIGFsbCB0aGUgdGVzdCBjYXNlcyBpbiBnZGIu c2VydmVyIHRvIGZhaWwuICBSZW1vdmluZyBpdCAnZml4ZWQnDQo+IGl0IGZv ciBtZS4gIEFsdGhvdWdoIGkgY2Fubm90IHRlbGwgeW91IHdoYXQgd2VudCB3 cm9uZy4NCj4gDQoNCkkgc3VzcGVjdCB0aGlzIGlzIGFuIG9sZCBzdHlsZSB2 cyBuZXcgc3R5bGUgdGFyZ2V0IGRlc2NyaXB0aW9ucyBpc3N1ZS4NCknigJl2 ZSBmb3VuZCBteXNlbGYgYW4gQXJtIDMyIGJveCBhbmQgcG90ZW50aWFsbHkg YSBQUEMgYm94IHRvbyAtIGhvcGluZyBJIGNhbiByZWNyZWF0ZSB0aGUgaXNz dWUgb24gb25lIG9mIHRoZW0uDQoNClRoYW5rcyBmb3IgbmFycm93aW5nIGl0 IGRvd24gdG8gdGhpcy4NCg0KDQpBbGFuLg0KDQoNCg== >From gdb-patches-return-145950-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Mar 14 10:31:16 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 80100 invoked by alias); 14 Mar 2018 10:31:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 80086 invoked by uid 89); 14 Mar 2018 10:31:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:55.2018, H*r:sk:static. X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Mar 2018 10:31:13 +0000 Received: by mail-wm0-f65.google.com with SMTP id t6so2998166wmt.5 for ; Wed, 14 Mar 2018 03:31:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=RDq8lPROBCRsZEfd9MVgXDkRzatensx1sQDzgMQltgQ=; b=bM7V37B1/Geb0rpp/6LnhAeBJJ8VfpeDa/iCtr8U4USTIUXQIlggIe5tQ0ybx3mcl7 ek+oB0VVY4JVwUMmLWW9Tsz4oF14TlzDsKcu/ZE/O0HhF+lbzRmCuiU2t5WORLk/evYn 97U511dtpX9PicjYckkD5IZ/n4FtqkRSAv0iY6zcOSsiVC+b53/cViObwUxa1YaVR6S8 4WIdHVja38xDxJnjR0Yrj4qtywZ90yuCecyBx7m/eYmiKFkq2F77vtKZYpd+8tD5Vjwh 9mv7s2eJvRHSsIWHR4i3nrUg10tWhXFXcJcfFKZwKaMmqd3l75i04FFgiyo1GWooyNey rlJQ== X-Gm-Message-State: AElRT7F/ER5Qe387tL851IqVpi+PLxUCx6ZGxC9t5GXj+2fENp7PY+ua 8JfO86QqFeOZy+p1G9qi1iKxYzKX X-Google-Smtp-Source: AG47ELsJoHSYjEAlX7ANem9C23VI0zv3Vpl+V5X24zenWMCPCKYCeVZ8FpNvTj16kR3HPd+8ASgeCA== X-Received: by 10.28.158.205 with SMTP id h196mr1110097wme.25.1521023471460; Wed, 14 Mar 2018 03:31:11 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id j42sm2368475wre.55.2018.03.14.03.31.10 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 14 Mar 2018 03:31:10 -0700 (PDT) From: Yao Qi To: Stephen Roberts Cc: gdb-patches@sourceware.org, nd@arm.com Subject: Re: [PATCH v2] This patch replaces the linear search in find_pc_sect_line with a binary search for faster performance. References: <1520924729-12839-1-git-send-email-stephen.roberts@arm.com> <1520962763-24018-1-git-send-email-stephen.roberts@arm.com> Date: Wed, 14 Mar 2018 10:31:00 -0000 In-Reply-To: <1520962763-24018-1-git-send-email-stephen.roberts@arm.com> (Stephen Roberts's message of "Tue, 13 Mar 2018 17:39:23 +0000") Message-ID: <86h8pjdk45.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00279.txt.bz2 Content-length: 1509 Stephen Roberts writes: > I've made all the suggested changes except for one - I break on a specifi= c line because the code is templatized so I can't set breakpoints on specif= ic methods. > I know I could use rbreak, but I feel that this would make the test less = clear and would include the overhead of looking up functions by regex, whic= h is not relevant to this fix. > If you still think I should go ahead and use rbreak, let me know. > That is fine by me. >=20=20 > - for (i =3D 0; i < len; i++, item++) > - { > - /* Leave prev pointing to the linetable entry for the last line > - that started at or before PC. */ > - if (item->pc > pc) > - break; > + auto pc_compare =3D [](const CORE_ADDR & pc, > + const struct linetable_entry & lhs)->bool The indentation looks wrong. It needs six spaces before "auto" instead of four spaces. > + { > + return pc < lhs.pc; > + }; >=20=20 > - prev =3D item; > - } > + struct linetable_entry *first =3D item; > + struct linetable_entry *last =3D item + len; > + item =3D std::upper_bound (first, last, pc, pc_compare); > + if (item !=3D first) > + prev =3D item - 1; /* Found a matching item. */ Otherwise, patch is good to me. If no one has comments in three days, you can push it in. Do you have a sourceware account? With that account/ssh key, you can push your commit to gdb repository. https://sourceware.org/cgi-bin/pdw/ps_form.cgi --=20 Yao (=E9=BD=90=E5=B0=A7)