From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34615 invoked by alias); 7 Aug 2017 14:32:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34195 invoked by uid 89); 7 Aug 2017 14:32:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=among X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Aug 2017 14:32:22 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v77EWF62024189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 7 Aug 2017 10:32:20 -0400 Received: by simark.ca (Postfix, from userid 112) id D0E511EA1D; Mon, 7 Aug 2017 10:32:15 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 0F7B51E9AB; Mon, 7 Aug 2017 10:32:05 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 07 Aug 2017 14:32:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] C++-ify skip.c In-Reply-To: <87d187cwf3.fsf@pokyo> References: <20170806194231.26627-1-tom@tromey.com> <5e21aff786d07501d546194f8f48e5bb@polymtl.ca> <87d187cwf3.fsf@pokyo> Message-ID: <19ea4d685104d39dfc20486425f41f37@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 7 Aug 2017 14:32:16 +0000 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00120.txt.bz2 On 2017-08-07 15:57, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Ah thanks, I tripped on this with me poison-XNEW patch. I > didn't have > Simon> the time to fix and post it yet. > > Ah, I didn't know about this. > I think I will wait for that before working in this area any more. > > Tom There are many things to fix before the poison-xnew patch can go in, but I think the issue you found is worth fixing sooner than later. Among the things that need to change is the opaque types with multiple definitions, like arch_lwp_info and private_thread_info. These need to be made into actual class hierarchies. If anybody is looking for things to do, feel free to pick up some patches and post them :) https://github.com/simark/binutils-gdb/commits/poison-xnew Simon