From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] [gdb] Fix xmllint namespace errors
Date: Wed, 26 Aug 2026 12:29:15 +0200 [thread overview]
Message-ID: <19cc51bf-2e0a-49bd-89e3-301d1728e406@suse.de> (raw)
In-Reply-To: <20260826083040.1702439-2-tdevries@suse.de>
On 8/26/26 10:30 AM, Tom de Vries wrote:
> diff --git a/gdb/testsuite/gdb.xml/inc-2.xml b/gdb/testsuite/gdb.xml/inc-2.xml
> index b076814d148..f4d65cf80b9 100644
> --- a/gdb/testsuite/gdb.xml/inc-2.xml
> +++ b/gdb/testsuite/gdb.xml/inc-2.xml
> @@ -1 +1,3 @@
> -<xi:include href="inc-body.xml"/>
> +<target xmlns:xi="http://www.w3.org/2001/XInclude">
> + <xi:include href="inc-body.xml"/>
> +</target>
It seems I didn't test this properly.
This change (adding <target> ... </target>) caused a failure in
gdb.xml/tdesc-xinclude.exp.
It seems that this can be fixed using this simpler change:
...
<xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="inc-body.xml"/>
...
I'll update the patch to use this pattern instead in case of missing
<target> ... </target>.
Thanks,
- Tom
next prev parent reply other threads:[~2026-08-26 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 8:30 [PATCH 0/2] [gdb] xml linting Tom de Vries
2026-08-26 8:30 ` [PATCH 1/2] [gdb] Fix xmllint namespace errors Tom de Vries
2026-08-26 10:29 ` Tom de Vries [this message]
2026-08-26 14:55 ` Tom de Vries
2026-08-26 8:30 ` [PATCH 2/2] [pre-commit] Check xml files Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19cc51bf-2e0a-49bd-89e3-301d1728e406@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox