From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stan Shebs To: scottb@netwinder.org Cc: gdb-patches@sourceware.cygnus.com Subject: Re: Merge of ARM Linux port with existing ARM code... Date: Thu, 16 Dec 1999 14:49:00 -0000 Message-id: <199912162249.OAA10157@andros.cygnus.com> References: <3857DC13.438069C4@netwinder.org> X-SW-Source: 1999-q4/msg00404.html Date: Wed, 15 Dec 1999 13:21:07 -0500 From: Scott Bambrough > That's a great start in the right direction. We can always come back > and polish the code later on. I'll get the basic stuff in, then you > can check it over in the next snap and tell me what I missed. It doesn't seem to be in this weeks snapshot, will it be in next weeks? Just to confirm, I've pasted in your ARM GNU/Linux changes. They're not put in verbatim; I tweaked some names and usages to conform better to the coding standards, and didn't apply some changes that only rearranged code, so as to simplify the diffs. I didn't (intentionally anyway :-) ) discard anything substantive, so you should get the next snap and try patching in any changes you may have made since the beginning of November. I also wrote ChangeLog entry and NEWS item. Since I don't have a native to test on, the ARM GNU/Linux config testing is up to you; but your tweaks in inferior function call code results in four more passes in the testsuite, and no additional fails. So thanks again for the contribution, and let me know how it all works on the Netwinder! Stan >From taylor@cygnus.com Fri Dec 17 16:02:00 1999 From: David Taylor To: Jimmy Guo Cc: gdb-patches@sourceware.cygnus.com Subject: Re: (patch) hpjyg03: (buildsym|language).[ch] Date: Fri, 17 Dec 1999 16:02:00 -0000 Message-id: <199912172347.SAA29264@texas.cygnus.com> X-SW-Source: 1999-q4/msg00405.html Content-length: 1385 It has been noticed that the language.c portion of this patch causes additional noise at startup. Namely: warning: Unrecognized range check setting: "auto; currently off" I'm curious as to whether this message gets printed at HP (or are there other language.c patches not yet submitted that get rid of it). In any case, here's a patch to eliminate that noise: taylor@texas 548: cvs diff -c language.c Index: language.c =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/language.c,v retrieving revision 2.68 diff -c -r2.68 language.c *** language.c 1999/12/13 18:00:13 2.68 --- language.c 1999/12/17 23:26:48 *************** *** 1578,1589 **** add_language (&auto_language_defn); language = savestring ("auto", strlen ("auto")); - range = savestring ("auto", strlen ("auto")); - type = savestring ("auto", strlen ("auto")); - - /* Have the above take effect */ - set_language_command (language, 0); set_type_command (NULL, 0); set_range_command (NULL, 0); } --- 1578,1588 ---- add_language (&auto_language_defn); language = savestring ("auto", strlen ("auto")); set_language_command (language, 0); + + type = savestring ("auto", strlen ("auto")); set_type_command (NULL, 0); + + range = savestring ("auto", strlen ("auto")); set_range_command (NULL, 0); } >From guo@cup.hp.com Fri Dec 17 17:03:00 1999 From: Jimmy Guo To: David Taylor Cc: gdb-patches@sourceware.cygnus.com Subject: Re: (patch) hpjyg03: (buildsym|language).[ch] Date: Fri, 17 Dec 1999 17:03:00 -0000 Message-id: References: <199912172347.SAA29264@texas.cygnus.com> X-SW-Source: 1999-q4/msg00406.html Content-length: 1597 Oops. Yes what was submitted in this patch wasn't the complete thing -- the language.c changes in the hpjyg20 patch fixes this problem. - Jimmy Guo, guo@cup.hp.com >It has been noticed that the language.c portion of this patch causes >additional noise at startup. Namely: > > warning: Unrecognized range check setting: "auto; currently off" > >I'm curious as to whether this message gets printed at HP (or are >there other language.c patches not yet submitted that get rid of it). > >In any case, here's a patch to eliminate that noise: > >taylor@texas 548: cvs diff -c language.c >Index: language.c >=================================================================== >RCS file: /cvs/cvsfiles/devo/gdb/language.c,v >retrieving revision 2.68 >diff -c -r2.68 language.c >*** language.c 1999/12/13 18:00:13 2.68 >--- language.c 1999/12/17 23:26:48 >*************** >*** 1578,1589 **** > add_language (&auto_language_defn); > > language = savestring ("auto", strlen ("auto")); >- range = savestring ("auto", strlen ("auto")); >- type = savestring ("auto", strlen ("auto")); >- >- /* Have the above take effect */ >- > set_language_command (language, 0); > set_type_command (NULL, 0); > set_range_command (NULL, 0); > } >--- 1578,1588 ---- > add_language (&auto_language_defn); > > language = savestring ("auto", strlen ("auto")); > set_language_command (language, 0); >+ >+ type = savestring ("auto", strlen ("auto")); > set_type_command (NULL, 0); >+ >+ range = savestring ("auto", strlen ("auto")); > set_range_command (NULL, 0); > }