From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stan Shebs To: guo@cup.hp.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: (patch) hpjyg17: gdb testsuite compiler.c(c) Date: Wed, 10 Nov 1999 21:19:00 -0000 Message-id: <199911110519.VAA28635@andros.cygnus.com> References: X-SW-Source: 1999-q4/msg00226.html Date: Tue, 9 Nov 1999 12:22:47 -0800 (PST) From: Jimmy Guo This patch moves compiler.c / compiler.cc to testsuite/lib/, and modifies gdb.exp (get_compiler_info) to locate these two files from $srcdir/lib/ instead of $srcdir/$subdir. The reason for this change is to eliminate multiple copies of these two files from existing (or future) test suite directories. When applying this patch, please also remove existing compiler.c(c) files from testsuite/gdb.* and testsuite/gdb.*/gdb.*/. Thanks. Thanks very much! I've committed this to the repository. Stan >From shebs@cygnus.com Wed Nov 10 21:24:00 1999 From: Stan Shebs To: guo@cup.hp.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: (patch) hpjyg18: derivation.exp Date: Wed, 10 Nov 1999 21:24:00 -0000 Message-id: <199911110524.VAA28647@andros.cygnus.com> References: X-SW-Source: 1999-q4/msg00227.html Content-length: 271 Date: Wed, 10 Nov 1999 09:41:20 -0800 (PST) From: Jimmy Guo *** This patch goes with hpjyg17 -- compiler.c(c) location change. *** Yes indeed, becomes obvious when the previous change is tested! This one is now committed. Stan >From taylor@cygnus.com Thu Nov 11 08:13:00 1999 From: David Taylor To: Jimmy Guo Cc: gdb-patches@sourceware.cygnus.com Subject: Re: 2nd try: (patch) hpjyg03: (buildsym|language).[ch] Date: Thu, 11 Nov 1999 08:13:00 -0000 Message-id: <199911111603.LAA20557@texas.cygnus.com> X-SW-Source: 1999-q4/msg00228.html Content-length: 162 The language part of this patch is approved. I'll be replacing the call to assert with a call to internal_error. It should be committed in the next day or two. >From taylor@cygnus.com Thu Nov 11 08:28:00 1999 From: David Taylor To: Jimmy Guo Cc: gdb-patches@sourceware.cygnus.com Subject: Re: (patch) hpjyg16: valarith.c Date: Thu, 11 Nov 1999 08:28:00 -0000 Message-id: <199911111617.LAA20566@texas.cygnus.com> X-SW-Source: 1999-q4/msg00229.html Content-length: 229 Relatively minor nit -- I don't like the name my_strcmp -- it doesn't suggest to me how it differs from the regular strcmp. Since it takes two value_ptr arguments, how about calling it value_strcmp instead? Otherwise approved. >From guo@cup.hp.com Thu Nov 11 09:03:00 1999 From: Jimmy Guo To: David Taylor Cc: gdb-patches@sourceware.cygnus.com Subject: Re: (patch) hpjyg16: valarith.c Date: Thu, 11 Nov 1999 09:03:00 -0000 Message-id: References: <199911111617.LAA20566@texas.cygnus.com> X-SW-Source: 1999-q4/msg00230.html Content-length: 273 >Relatively minor nit -- I don't like the name my_strcmp -- it doesn't >suggest to me how it differs from the regular strcmp. Since it takes >two value_ptr arguments, how about calling it value_strcmp instead? value_strcmp is it. Thanks! - Jimmy >Otherwise approved.