From: Stan Shebs <shebs@cygnus.com>
To: phdm@macqel.be
Cc: gdb-patches@cygnus.com, gdb@cygnus.com
Subject: Re: testsuite/print_long_arg_list
Date: Thu, 08 Apr 1999 13:43:00 -0000 [thread overview]
Message-ID: <199904082043.NAA29533@andros.cygnus.com> (raw)
In-Reply-To: <199904071649.SAA28333@mail.macqel.be>
Date: Wed, 7 Apr 1999 18:49:38 +0200 (CEST)
From: "Philippe De Muyter" <phdm@macqel.be>
Running the testsuite with gdb-4.17.87 on m68k-motorola-sysv, I got
(among others) the following failure :
print_long_arg_list (a=22.219999999999998, b=33.332999999999998, c=0, d=-25, e=1
[...]
Looking at the expected result, I see :
gdb_expect {
-re ".*print_long_arg_list \\(a=22.219999999999999, b=33.332999999999998
[...]
For me, the differences are in the last digits of some float or double numbers.
Isn't the test too strict ?
I'm no floating-point expert, but I do know that you're supposed to be
careful about ignoring the last digit. On the other hand, GDB just
uses a printf %g to display float values, so the output is going to
depend on the system's C library as much as GDB's correctness. In fact,
"a" is actually 22.22 in the sources, so even the expected test result
isn't what it should be.
My inclination is to relax the match here. What does everybody else
think?
Stan
next prev parent reply other threads:[~1999-04-08 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-07 9:49 testsuite/print_long_arg_list Philippe De Muyter
1999-04-08 13:43 ` Stan Shebs [this message]
1999-04-08 15:28 ` testsuite/print_long_arg_list J.T. Conklin
1999-04-08 16:01 ` testsuite/print_long_arg_list Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199904082043.NAA29533@andros.cygnus.com \
--to=shebs@cygnus.com \
--cc=gdb-patches@cygnus.com \
--cc=gdb@cygnus.com \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox