From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sAstEpTcbF9sBQAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 13:51:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 4829C1EE05; Thu, 24 Sep 2020 13:51:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EEB151E599 for ; Thu, 24 Sep 2020 13:51:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 427153857C52; Thu, 24 Sep 2020 17:51:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 427153857C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1600969875; bh=/W/8dx21x41O9T+pekB8NXlGOw/7Qioz/otcjGa0rM8=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xGqkIU0aCYl1Ud+uT3IhL+CLQxkSApZxz4W8UgYQvxaEuD3RFFNfR+Th/kXVkZRGL p8vCG8NN0ysp0fb+//cjJ4KCFL+FwjMAW5+GuyfsAahp0SRWA76OHW7Nl5sO7muKl3 jyJpqPUDRimstAgnB//mv6Pk4dOHhk1K4RoSqPQM= Received: from sonic310-11.consmr.mail.ir2.yahoo.com (sonic310-11.consmr.mail.ir2.yahoo.com [77.238.177.32]) by sourceware.org (Postfix) with ESMTPS id DBA7F3857C52 for ; Thu, 24 Sep 2020 17:51:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DBA7F3857C52 X-YMail-OSG: 0HfOD9EVM1l8QoM.CD6hkVBiMslhHGHKOpIpeWVnppGkyh96.95YMp7SopVHKeT QPAJjTmcvv5bfpQ.xFAIBK05JUUL6kq1DqBuWkB9lfbTWFIJE.7IK.PCKr25BtxSh7VEYm8DgK0P LwgVxW6AKesrOjVDcETHAeEh822IMbklNIS6y79fWY3bausWeRrUVVI.t_PqlO01Vm3PJA6.3acu BXLISAR5s5lZ8rcQ.M0tYZiKXbV._umhC_UyvTu.qPgH47NwXbg6aQI5p5Dy8UcqkyWFHryta2rn mqN1PqYliPutJvLmX0zcmo8E2zxNPdk.m.YsRR30vtN3f5MQcNWUVi1CnXAAeH3zRgxFE49vXanM WUnSei4qRFxMd_4d1ODLzp1_y7QmrXWJsjWiUByLSc07WraXMjxlYfONECPYBMD956C0XxUZ9yd4 tg4yiy7Sdsp3GmdrnZyEfBU8S_6.d1xBnVSkRkPDpSS1t0kADnT5cmFJrDWh9KBPcaq6hN8UQ16Y pi.h5ejhckYwQ0DyZe2yLHnQJc_bgRmSMZDaCYnSvYL.G5SMFUTH1Ri.s0S2JOD5iFOr3so19Flr QKC9JJHaq5S3dbce8h..QPXOW_U_9n2Clk0EAelOjjWLSux6k5q882LOvWyYj9vJSnmawGjy9mun kOIT2zttDJnOXIPweTfBAc.cbApTYG662Y5KoOpu_DDy2grlbFU_s8UjasvYzxpunf9suq_FbHkL K5MsiPknZNcsP34GRiR3t1wRDsmDj4cjagH7ugKxzrMyh2hR1F1McsnTz4oPZhxwEESrepIvgZlr eAsaiHGkXRDNVaIQ3B7sUSmb6l5nTTReHegirNQbEcgzrlMHjctX6SBwdikcH7qVp1Gs9uXPd4T9 rAdyA2Mb8vddkrg4kgwY2qOonUMUnnz_x6g9BHa7UHm.AjmjzoJSKOhgOmwQSEtCQndBdBsqOfoS UicTFLO0M3.GsiVoQ6JvIQJukDXiV55o2cvh78pp0_sdcmJWxk_hRHzmqiJ_D_hWplQdgdfrQ3eK DkjAoHNJyddUZlpjRuIhqprPFmOm6Ptg1tdbe_Jy81gib.fXuWvNLcPSKWJ0tH6A6b9ZOC2Gp9XD OJrLjK4ThP8Kp7Hg9qIt.Ukk3z30snAtCjsAn2IU9riomefF0H757vO5tmnwqd7_v1F9i84D2wBe OQ3SX70sKZ0.w8fj1ezi5BKvNOyuXAbRd9Q5ZGa42CvMsNHg_PCbohXSweggrBldXR0VCkHmMF4C 5I8KZIKSvUFYfBArwCDcMtJGIX_fFQRxB.oL.R_a5vT9SqGaHkP26KkcS9gK9uU5H08ve3oWNeBo 7JjXyAj.DIEad71ZM2Dl5BF8SuPHcqBvYLP6SU5ObS59C2Me5eQ19gJJbC44ZD1VOmEEFiZXrebY suaz5gx9l_jltmDe2HR7nDhoHt21OCUm.DRQ3Avh.9f8DFlFhuyIThgXusZWDrNjrBecHdo93Igz MoL8Ugy5u4Q.x Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Thu, 24 Sep 2020 17:51:11 +0000 Date: Thu, 24 Sep 2020 17:51:08 +0000 (UTC) To: Joel Brobecker Message-ID: <1994899713.688642.1600969868909@mail.yahoo.com> In-Reply-To: <20200924172247.GS4075@adacore.com> References: <20200923172122.2089-1-ssbssa.ref@yahoo.de> <20200923172122.2089-1-ssbssa@yahoo.de> <0ce3a433-4256-93e9-8843-57cd5f28ba73@simark.ca> <2023373258.594579.1600961165295@mail.yahoo.com> <538186656.652086.1600965451252@mail.yahoo.com> <8c6040f0-d21a-40b5-8587-be23a312689c@simark.ca> <153976107.672644.1600967156864@mail.yahoo.com> <20200924172247.GS4075@adacore.com> Subject: Re: [PATCH 1/3] Handle 64bit breakpoints of WOW64 processes as SIGINT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.16674 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Cc: Simon Marchi , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Donnerstag, 24. September 2020, 19:22:51 MESZ hat Joel Brobecker Folgendes geschrieben: > > > >>> diff --git a/gdb/nat/windows-nat.c b/gdb/nat/windows-nat.c > > > >>> index a277156138..2cbbc0f2cc 100644 > > > >>> --- a/gdb/nat/windows-nat.c > > > >>> +++ b/gdb/nat/windows-nat.c > > > >>> @@ -243,6 +243,13 @@ handle_exception (struct target_waitstatus *= ourstatus, bool debug_exceptions) > > > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else if (wow64_process) > > > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > > > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* This breakpoint ex= ception is triggered for WOW64 processes when > > > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 reaching an int3 instruction in 64bit code. > > > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 gdb checks for int3 in case of SIGTRAP, this fails because > > > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 Wow64GetThreadContext can only report the pc of 32bit code, and > > > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 gdb lets the target process continue. > > > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 So handle it as SIGINT instead, then the target is stopped > > > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 unconditionally.=C2=A0 */ > > > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DEBUG_EXCEP= TION_SIMPLE ("EXCEPTION_BREAKPOINT"); > > > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rec->Except= ionCode =3D DBG_CONTROL_C; > > > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ourstatus->= value.sig =3D GDB_SIGNAL_INT; > > > >> > > > >> That is fine with me, thanks. > > > >> > > > >> Just to make sure I understand, stopping a 32-bit process from a 6= 4-bit > > > >> GDB is the only time we expect this to happen, right? > > > > > > Ok, thanks.=C2=A0 Please go ahead and merge. > > > > Pushed, thanks. > > > > I think it would be great to have this in the gdb-10-branch. > > Would that be possible? > > > OK for me, Hannes. Thanks, pushed as well to gdb-10-branch. Hannes