From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id 9A0AA3952508 for ; Mon, 9 Mar 2020 17:55:14 +0000 (GMT) Received: by mail-qk1-x742.google.com with SMTP id f198so10076860qke.11 for ; Mon, 09 Mar 2020 10:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fkQixE5YM2Hs/mwaYq1bfrJrSLUvljpQFPyr5+dsFtM=; b=X0/JDKrYcHGpate6FuI7Rn9+nP/MrqWDFuYELm90ZRJV9k03d/xKbE9vzDoS08i0bL B/3u+JDxotneyruiVVkvfoIPioOvtXULsf7D26WRpZFJRXxokjEyY8KoMbeHYzp+LpBT elYbrI4DLHxCX8NNbYOryNCosIZAEQemjNN635p5yCtt1mGxJmh8pjROaAfNRo7QeWjR tKlH+6nKcNG4UppbQAr2+Ul0EV0kVVga0JHnQkJhbCEDtgIcUbh0Td/FmjZeEaOinEtM 85Tof5kDl2jl2WfAiUa+5wE4qgij51pD2TUq6Ys5RBfUhqjTgUdS0gx+MVtFM7bj31ij VILQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fkQixE5YM2Hs/mwaYq1bfrJrSLUvljpQFPyr5+dsFtM=; b=T1LUCECjy5Qb/7ZuA0OYDSRmUJiAEza13jMPC1Z/dADVTIRrFWC7miQVF5Lxe3vqtY /plX+6PisqDiUYWQnI1RpV2Byc0m9NSBj4XnxsjX2TeyxxyNJniorXLx9EfQOnd+x6mk hbv9KPE2QE5GCavQTfYLU8P2EwlHE3PuunXUsyVK8vZVT/y9kPQjECUfV0/tRZoOyttS Im8n4lHewfpsOgekkpkPhPDQzP0fSjFeVU2vPVUAUwiuogrM9rLgz7vwWf+Ll0cK5HHN G/ZzyV13zXF2YT3OHWmbEui+t1dQnISnGQrlAShdS13p/oiDL5zL+uRycvjsK5yBYkkv pPBA== X-Gm-Message-State: ANhLgQ0f9uVoZZ9aLHkfg4YLaOpgjcmFtgOImPTHNWZxT9pzDHVj7rD8 dpCFiI4i7B8oLPW11vDO7bmqchTqLts= X-Google-Smtp-Source: ADFU+vtw5wdlnfuJCp/Z+6+KJ/mGkBNlOIKRNOkcRZHXjzQAlD1CHYFfJIFKhSwu6YnoSEl0LR0SUw== X-Received: by 2002:a05:620a:a90:: with SMTP id v16mr9999846qkg.46.1583776513687; Mon, 09 Mar 2020 10:55:13 -0700 (PDT) Received: from [192.168.0.185] ([179.177.238.226]) by smtp.gmail.com with ESMTPSA id h47sm4055014qtb.75.2020.03.09.10.55.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2020 10:55:12 -0700 (PDT) Subject: Re: [PATCH] Find tailcall frames before inline frames From: Luis Machado To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200220155820.22809-1-tromey@adacore.com> <87sgip6rk9.fsf@tromey.com> <665eda59-ae52-42f4-b3b2-e3a070036ca8@linaro.org> Message-ID: <19708130-1937-2e7f-0beb-7fdcc481b3aa@linaro.org> Date: Mon, 9 Mar 2020 14:55:09 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <665eda59-ae52-42f4-b3b2-e3a070036ca8@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GARBLED_BODY, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2020 17:55:15 -0000 On 3/5/20 7:21 AM, Luis Machado wrote: > Hi Tom, > > On 3/3/20 6:45 PM, Tom Tromey wrote: >> Tom> gdb/ChangeLog >> Tom> 2020-02-20  Tom Tromey  >> >> Tom>     * dwarf2/frame.c (struct dwarf2_frame_cache) >> Tom>     > Tom>    entry_cfa_sp_offset_p> : Remove members. >> Tom>     (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first. >> Tom>     (dwarf2_frame_prev_register): Don't call >> Tom>     dwarf2_tailcall_sniffer_first. >> Tom>     (dwarf2_append_unwinders): Don't append tailcall unwinder. >> Tom>     * frame-unwind.c (add_unwinder): New fuction. >> Tom>     (frame_unwind_init): Use it.  Add tailcall unwinder. >> >> I'm going to check this in now. >> >> Tom >> > > This has caused quite a few failures in the following tests for > aarch64-linux: > > gdb.opt/inline-break.exp > gdb.opt/inline-cmds.exp > gdb.python/py-frame-inline.exp > gdb.reverse/insn-reverse.exp > > I see the following: > > info frame^M > ../../../repos/binutils-gdb/gdb/frame.c:579: internal-error: frame_id > get_frame_id(frame_info*): Assertion `fi->level == 0' failed.^M > A problem internal to GDB has been detected,^M > further debugging may prove unreliable.^M > Quit this debugging session? (y or n) FAIL: > gdb.python/py-frame-inline.exp: info frame (GDB internal error) > Resyncing due to internal error. > n^M > ^M > This is a bug, please report it.  For instructions, see:^M > .^M > > > (gdb) up^M > ../../../repos/binutils-gdb/gdb/inline-frame.c:172: internal-error: void > inline_frame_this_id(frame_info*, void**, frame_id*): Assertion > `frame_id_p (*this_id)' failed.^M > A problem internal to GDB has been detected,^M > further debugging may prove unreliable.^M > Quit this debugging session? (y or n) FAIL: > gdb.python/py-frame-inline.exp: up (GDB internal error) > Resyncing due to internal error. > n^M > ^M > This is a bug, please report it.  For instructions, see:^M > .^M > > > I can help get more information on it if you need. Reported as https://sourceware.org/bugzilla/show_bug.cgi?id=25649 so we can track it.