From: msnyder@sonic.net
To: gdb-patches@sourceware.org
Cc: brobecker@adacore.com
Subject: [PATCH] ada-lang, possible_user_operator_p, null pointer
Date: Sat, 11 Aug 2007 20:43:00 -0000 [thread overview]
Message-ID: <19577.12.7.175.2.1186864998.squirrel@webmail.sonic.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
If type1 is null (which is checked for earlier), this line will
dereference it.
Also, I'm not sure what the CONCAT operator is, but is it
possible that the OR at the beginning of the same line
should be an AND? Just checking...
[-- Attachment #2: 56.txt --]
[-- Type: text/plain, Size: 1254 bytes --]
2007-08-11 Michael Snyder <msnyder@access-company.com>
* ada-lang.c (possible_user_operator_p): Guard against NULL.
Index: ada-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-lang.c,v
retrieving revision 1.100
diff -p -r1.100 ada-lang.c
*** ada-lang.c 6 Aug 2007 20:07:44 -0000 1.100
--- ada-lang.c 11 Aug 2007 20:39:20 -0000
*************** possible_user_operator_p (enum exp_opcod
*** 3536,3542 ****
((TYPE_CODE (type0) != TYPE_CODE_ARRAY
&& (TYPE_CODE (type0) != TYPE_CODE_PTR
|| TYPE_CODE (TYPE_TARGET_TYPE (type0)) != TYPE_CODE_ARRAY))
! || (TYPE_CODE (type1) != TYPE_CODE_ARRAY
&& (TYPE_CODE (type1) != TYPE_CODE_PTR
|| (TYPE_CODE (TYPE_TARGET_TYPE (type1))
!= TYPE_CODE_ARRAY))));
--- 3536,3542 ----
((TYPE_CODE (type0) != TYPE_CODE_ARRAY
&& (TYPE_CODE (type0) != TYPE_CODE_PTR
|| TYPE_CODE (TYPE_TARGET_TYPE (type0)) != TYPE_CODE_ARRAY))
! || (type1 != NULL && TYPE_CODE (type1) != TYPE_CODE_ARRAY
&& (TYPE_CODE (type1) != TYPE_CODE_PTR
|| (TYPE_CODE (TYPE_TARGET_TYPE (type1))
!= TYPE_CODE_ARRAY))));
next reply other threads:[~2007-08-11 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-11 20:43 msnyder [this message]
2007-08-14 4:27 ` Joel Brobecker
2007-08-14 5:20 ` Joel Brobecker
2007-08-14 18:33 ` msnyder
2007-08-15 18:39 ` [commit] ada-lang, possible_user_operator_p, null pointer (take 2) Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19577.12.7.175.2.1186864998.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox