From: msnyder@sonic.net
To: msnyder@sonic.net
Cc: "Mark Kettenis" <mark.kettenis@xs4all.nl>,
msnyder@sonic.net, gdb-patches@sourceware.org
Subject: Re: [PATCH] c-exp.y, memory leak
Date: Fri, 17 Aug 2007 23:28:00 -0000 [thread overview]
Message-ID: <19531.12.7.175.2.1187393323.squirrel@webmail.sonic.net> (raw)
In-Reply-To: <5061.12.7.175.2.1186784974.squirrel@webmail.sonic.net>
>>> Date: Sat, 4 Aug 2007 18:51:09 -0700 (PDT)
>>> From: msnyder@sonic.net
>>>
>>> 2007-08-04 Michael Snyder <msnyder@access-company.com>
>>>
>>> * c-exp.y (parse_number): Memory leak.
>>
>> Shouldn't this use xfree()?
>
> Actually, although arguably they should -- I'm not so sure.
>
> It's kind of a mess -- c-exp.y uses malloc, and then Makefile.in
> runs sed on c-exp.c to transform malloc to xmalloc. No such sed
> transform is done to convert free to xfree, and there is at least
> one other call to free in there that does not get converted.
>
> I'm reluctant to mess with the sed scripts. "free" is just too
> common a string.
Alright -- I'm going to commit this using "free" rather than
"xfree", on the premise that the file already calls free once,
and doesn't call xfree at all.
prev parent reply other threads:[~2007-08-17 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 1:51 msnyder
2007-08-05 18:52 ` Mark Kettenis
2007-08-05 22:08 ` Michael Snyder
2007-08-10 22:29 ` msnyder
2007-08-17 23:28 ` msnyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19531.12.7.175.2.1187393323.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox