From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2449 invoked by alias); 15 Nov 2010 01:21:29 -0000 Received: (qmail 2441 invoked by uid 22791); 15 Nov 2010 01:21:27 -0000 X-SWARE-Spam-Status: Yes, hits=5.1 required=5.0 tests=AWL,BAYES_50,MIME_BASE64_BLANKS,RFC_ABUSE_POST,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mailout3.samsung.com (HELO mailout3.samsung.com) (203.254.224.33) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Nov 2010 01:21:17 +0000 Received: from epms1.samsung.com (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LBW0080BJREYI20@mailout3.samsung.com> for gdb-patches@sourceware.org; Mon, 15 Nov 2010 10:21:14 +0900 (KST) Received: from epv6spt1 ("port 10963"@[203.254.225.172]) by ms1.samsung.com (Sun Java(tm) System Messaging Server 7u3-15.01 64bit (built Feb 12 2010)) with ESMTP id <0LBW00JXIJRESEK0@ms1.samsung.com> for gdb-patches@sourceware.org; Mon, 15 Nov 2010 10:21:14 +0900 (KST) Date: Mon, 15 Nov 2010 01:21:00 -0000 From: JuYoung Kim Subject: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name To: "gdb-patches@sourceware.org" Cc: =?utf-8?Q?=EA=B9=80=EC=A3=BC=EC=98=81?= Reply-to: j0.kim@samsung.com MIME-version: 1.0 X-MTR: 20101115011123135@j0.kim Msgkey: 20101115011123135@j0.kim X-EPLocale: ko_KR.utf-8 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20101109060300735@j0.kim X-ParentMTR: 20101109065305390@j0.kim Content-transfer-encoding: base64 Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <19193243.6341289784074300.JavaMail.weblogic@epml17> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00170.txt.bz2 CkhlbGxvLCBNeSBuYW1lIGlzIEtpbSwgSnV5b3VuZyBhdCBUbWF4Q29yZSBj by4gaW4gc291dGgga29yZWEuCkkndmUgc2VudCB0aGlzIGVtYWlsIGxhc3Qg d2VlayBidXQgaGF2ZW4ndCByZWNlaXZlIGFueSByZXBseSBvciBpbmZvcm0u ClRvZGF5IEkgZm91bmQgdGhlIGVtYWlsIHdhcyBlbmNvZGVkIGluIGtvcmVh biBhbmQgbWF5YmUgeW91IGNvdWxkIG5vdCByZWFkIGl0LgpTbywgSSBzZW5k IHRoaXMgbWFpbCBhZ2FpbiwgYW5kIEkgaG9wZSB5b3UgcmVwbHkgbWUgYXMg cG9zc2libGUgYXMgeW91IGNhbiwgcGxlYXNlLgoKSXQgaXMgYWJvdXQgc3Vi ZmlsZSBmb3IgRFdBUkYuCldoZW4geW91IHNlZSB0aGUgZnVuY3Rpb24gZHdh cmYyX3N0YXJ0X3N1YmZpbGUoKSBpbiB0aGUgc291cmNlLCB0aGVyZSBpcyBh IGNvbW1lbnQgYWJvdXQgc291cmNlJ3MgZmlsZSBuYW1lLgpTb21lIGNvbXBp bGVyICggbGlrZSBSQ1ZUMy4xICkgaW5jbHVkZSAnLycgYXQgdGhlIGVuZCBv ZiBkaXIgbmFtZS4KCkZvciBleGFtcGxlLAppbiBjYXNlLCBEV19BVF9uYW1l OiAvc3JjZGlyL2xpc3QwLmMKeW91IGV4cGVjdArCoMKgIMKgIGZpbGVzLmZp bGVzWzBdLm5hbWU6IGxpc3QwLmgKwqDCoCDCoCBmaWxlcy5maWxlc1swXS5k aXI6IC9zcmNkaXIKYnV0LCB0aGUgRFdBUkYgbWFkZSBieSBSVkNUMy4xIGlz IGxpa2UgdGhpcy4KwqDCoCDCoGZpbGVzLmZpbGVzWzBdLm5hbWU6IGxpc3Qw LmgKwqDCoCDCoGZpbGVzLmZpbGVzWzBdLmRpcjogL3NyY2Rpci8KCnRoZW4g dGhlIGZ1bmN0aW9uIGR3YXJmMl9zdGFydF9zdWJmaWxlKCk7IG1ha2UgdGhl IGZ1bGxuYW1lICIvc3JjZGlyLy9saXN0MC5jIgosIHdoaWNoIHJlc3VsdCBp biB0aGUgZ2RiIGNhbm5vdCBmaW5kIHRoZSBzb3VyY2UncyBkZWJ1Z2dpbmcg aW5mb3JtYXRpb24uCgpUaGUgZnVuY3Rpb24gZHdhcmYyX3N0YXJ0X3N1YmZp bGUoKSBpcyBhdCBnZGIvZHdhcmYycmVhZC5jOjg2NTAuCgpUaGUgb3JpZ2lu YWwgc291cmNlIGNvZGUgaXMKCi4uLi4uLi4uLgrCoMKgaWYgKCFJU19BQlNP TFVURV9QQVRIIChmaWxlbmFtZSkgJiYgZGlybmFtZSAhPSBOVUxMKSB7CsKg wqAgwqBmdWxsbmFtZSA9IGNvbmNhdCAoZGlybmFtZSwgU0xBU0hfU1RSSU5H LCBmaWxlbmFtZSwgKGNoYXIgKilOVUxMKTsKwqDCoH0KwqDCoGVsc2UKwqDC oCDCoGZ1bGxuYW1lID0gZmlsZW5hbWU7Ci4uLi4uLi4uCgpJIGNoYW5nZWQg aXQgYXMgYmVsb3cuCgouLi4uLi4uLgrCoMKgaWYgKCFJU19BQlNPTFVURV9Q QVRIIChmaWxlbmFtZSkgJiYgZGlybmFtZSAhPSBOVUxMKSB7CsKgwqAgwqAg aWYgKGRpcm5hbWVbc3RybGVuKGRpcm5hbWUpLTFdID09ICcvJyB8fCBkaXJu YW1lW3N0cmxlbihkaXJuYW1lKS0xXSA9PSAnJykKwqAgwqAgwqAgwqAgZnVs bG5hbWUgPSBjb25jYXQgKGRpcm5hbWUsIGZpbGVuYW1lLCAoY2hhciAqKU5V TEwpOwrCoMKgIMKgIGVsc2UgZnVsbG5hbWUgPSBjb25jYXQgKGRpcm5hbWUs IFNMQVNIX1NUUklORywgZmlsZW5hbWUsIChjaGFyICopTlVMTCk7CsKgwqB9 CsKgwqBlbHNlCsKgwqAgwqAgZnVsbG5hbWUgPSBmaWxlbmFtZTsKLi4uLi4u Li4uLgoKVGhpcyBpcyBteSBmaXJzdCB0aW1lIHRvIHJlcG9ydCB0aGUgcGF0 Y2guClNvIHBsZWFzZSwgaW5mb3JtIG1lIGlmIG15IHdheSBvZiByZXBvcnRp bmcgaXMgbm90IHByb3Blci4KClRoYW5rcy4= >From gdb-patches-return-76414-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Nov 15 04:09:06 2010 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 11245 invoked by alias); 15 Nov 2010 04:09:05 -0000 Received: (qmail 11234 invoked by uid 22791); 15 Nov 2010 04:09:04 -0000 X-SWARE-Spam-Status: No, hits=0.6 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Nov 2010 04:08:28 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LBW00H00RDWYE00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 15 Nov 2010 06:08:07 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.249.126]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LBW00HY2RHIVA20@a-mtaout22.012.net.il>; Mon, 15 Nov 2010 06:08:07 +0200 (IST) Date: Mon, 15 Nov 2010 04:09:00 -0000 From: Eli Zaretskii Subject: Re: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name In-reply-to: <19193243.6341289784074300.JavaMail.weblogic@epml17> To: j0.kim@samsung.com Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83oc9rcjps.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT References: <19193243.6341289784074300.JavaMail.weblogic@epml17> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2010-11/txt/msg00171.txt.bz2 Content-length: 766 > Date: Mon, 15 Nov 2010 01:21:14 +0000 (GMT) > From: JuYoung Kim > Cc: 김주영 > >   if (!IS_ABSOLUTE_PATH (filename) && dirname != NULL) { >      if (dirname[strlen(dirname)-1] == '/' || dirname[strlen(dirname)-1] == '') Please use IS_DIR_SEPARATOR instead of testing for '/' literally. And the second part of the if clause cannot happen at all, so it should be removed. Also, the GNU coding standards say to put the braces like this: if (something) { do_something; do_something_else; } >      else fullname = concat (dirname, SLASH_STRING, filename, (char *)NULL); Make "else" have its own line, like this: else fullname = concat (dirname, SLASH_STRING, filename, NULL);