From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12363 invoked by alias); 21 Sep 2009 23:39:17 -0000 Received: (qmail 12352 invoked by uid 22791); 21 Sep 2009 23:39:15 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Sep 2009 23:39:11 +0000 Received: from totara (215.29.255.123.dynamic.snap.net.nz [123.255.29.215]) by viper.snap.net.nz (Postfix) with ESMTP id 3254D3DA4CF; Tue, 22 Sep 2009 11:39:09 +1200 (NZST) Received: by totara (Postfix, from userid 1000) id 3D751C168; Tue, 22 Sep 2009 11:31:41 +1200 (NZST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19128.3293.212721.745656@totara.tehura.co.nz> Date: Mon, 21 Sep 2009 23:39:00 -0000 To: tromey@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH:gdb/mi] Update a specified list of variable objects In-Reply-To: References: <19127.27863.973393.962895@totara.tehura.co.nz> From: nickrob@snap.net.nz (Nick Roberts) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00691.txt.bz2 Tom Tromey writes: > >>>>> "Nick" == Nick Roberts writes: > > Nick> -var-update [PRINT_VALUES] NAME1 NAME2 ... > > Two notes on this patch. > > First, it needs a documentation change as well. I should have posted it as a RFC. I've not run the testsuite or written any tests either. I wanted to test the water first but these will be forthcoming if there's general agreement on the change. > Nick> ! int index = optind; > Nick> ! while (argv[index]) { > > Second, a nit: wrong brace placement. Hmm. Too much Java. -- Nick http://www.inet.net.nz/~nickrob