From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31353 invoked by alias); 14 Sep 2009 22:55:03 -0000 Received: (qmail 31343 invoked by uid 22791); 14 Sep 2009 22:55:02 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 22:54:58 +0000 Received: from totara (214.63.255.123.dynamic.snap.net.nz [123.255.63.214]) by viper.snap.net.nz (Postfix) with ESMTP id 797643DA9A8; Tue, 15 Sep 2009 10:54:55 +1200 (NZST) Received: by totara (Postfix, from userid 1000) id 55EA8C164; Tue, 15 Sep 2009 10:54:54 +1200 (NZST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19118.51646.285931.86868@totara.tehura.co.nz> Date: Mon, 14 Sep 2009 22:55:00 -0000 To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: Patch: implement new dynamic varobj spec In-Reply-To: References: <19113.58116.381538.294631@totara.tehura.co.nz> <19114.58228.563201.654364@totara.tehura.co.nz> From: nickrob@snap.net.nz (Nick Roberts) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00465.txt.bz2 > I think we've been conservative enough about this code that it is > probably reasonable to let people rely on it. It has been through a lot > of vetting. > > However, I don't mind adding a note to the manual if other maintainers > want that. Some of the the headaches of MI are due to legacy code. Hence mi0, mi1, mi2, etc. I don't know if others are already using these features but it would seem sensible to me for frontends to _drive_ MI and not for it to be the other way around. For example, here are a couple changes that I would like to see: 1) The displayhint field output from -var-create as well/or instead of from -var-list-children. That would be useful for determining whether an element should be expandable or not. Types map, list -- yes, type string -- no. With normal variable objects I just use num_children but this isn't sufficient for dynamic ones. 2) If is_map is true, rather than: var1.0 = key0 var1.1 = value0 var1.2 = key1 var1.0 = vaue1 ... I would prefer GDB to output: var1.0 = "map_element" var1.0.key = key0 var1.0.value = value0 var1.1 = "map_element" var1.1.key = key1 var1.1.value = value1 That way the values could be displayed as a tree: [-]--0 | | | |--key0 | | | |--value0 | [-]--1 | | | |--key1 | | | |--value1 -- Nick http://www.inet.net.nz/~nickrob