From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic313-20.consmr.mail.ir2.yahoo.com (sonic313-20.consmr.mail.ir2.yahoo.com [77.238.179.187]) by sourceware.org (Postfix) with ESMTPS id CAF0D386F021 for ; Thu, 30 Apr 2020 12:42:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CAF0D386F021 X-YMail-OSG: GIbrrv4VM1mABpfsWDWtUC4GmfsN0beOhqwSphI47vDBq3f7cG65wXLXzwtsk0F jNu5eQfTWCrmdptHpjh2XJFDifQYcVzfJxsXuDrhsb792k5L9lDsa8Qk8uydtclvtWVVPGk_UzyO FI587xNyiq_GC9IJyQIS.zMdJwB.phd1.BhXzrcBb3K7Y7Z3PZykuq6_cMu6OPRNh3RZcC0LUkXK jh_j3A6USDKa_PljnTYRgYOspRhePR1ITPB768OHoHYLGz7mYcPExYuB625uErHKRrTeJQXLJvA5 E3S6ln5XW1qUovSK87pdWI0ZVcyA8170Tau7k01fxzX0Tuv4oHjSeTleD.nMfXtkvKyO6ml6JPT9 5D.nTMWLBonYM.Vhk.ruyPzt.Hlaf7LXl6Fz3gkq94uOaNIGNbGb8IXVzP6olsSjBm2i8ybgDm.q hy8W9OHelopdRRZ9M3Zh2wNb.JXvLtSYjWiekiZ8JunfUaTnTh4iO2arahgKz4Up3SPotv_QRsL8 k5a2ahoSWBl1uWEwfnjxUg46VSxZ18QlwJENfkTikK42L7PTbyW2ltRjlPX.SSDeRPC4RtxheZez jMUBeA8qOi.UDqb4GI39UZ1c.CcDYXRKOj_xGfG8_7gk7bB1rSycI7qFs3vYSgzPXyFJ6BxwkN7L QdnW4GXHilea6bs8kz6lOMlBrfLm.907sPVUOcFxQRGcmtrH8tF0gNXfQtBfLL5rcBz2SgtuA9yS ZAz3gaSr0cCI4jRfV3eTZrkfVEPssf7BvpJ5_KZ1AdqX4uQL0etJ3KptiWMZb2qQmIvMw05ELqiz GLBfMvGpYmQlnNztqHt_c1yevH.uxyCjvrbg1rT9ngcb3hVLK4TreYvY0ML4MXik8fNMIuS9tQM3 3a.e8wnKxMCrIL_o_.qC79FvKZ9mFnH4QMcL8cCvHVWEvthE50MwomDGIgrHyAghLWGvfQ_JNN2n J5ncdjYO4wXuyJncN9js5ZPpXP0w1tCWgvlIsyw1MYdus5MyyssRSMgqlnIBTU_MpkYDzVVIr.Z5 ah9ASEA09MTQtpzKWadrsljZyzBuB6uKZmYE1TYvqEvEpPykTWfmUtUVm2b00.fdDABAwEwuq687 PU9sVW7DSe.k5xP5cNjk514iw6jn7lGSnDtYDYmir1nAmFkCZu3Th9n7dwyfp9NwoGxqlS1VZ7x2 T_Ji_kioUoYBsXYknLl17.FG1OqD0LQpghbjOyDa.LeP.DTs0_k7Po2Qt8uy0eJ2PEuC2KxqNLPn 4TmSG8dt2YqcyHAgRYs_PFecpD1EQd7zz02ypSTa0lyVQlH6BJHoaivzA2yBCoBw9bnIFP7QLJz2 JO9Hr52CeVPeYogGW Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Thu, 30 Apr 2020 12:42:21 +0000 Date: Thu, 30 Apr 2020 12:42:18 +0000 (UTC) From: Hannes Domani To: Gdb-patches Message-ID: <1901697675.5346744.1588250538897@mail.yahoo.com> In-Reply-To: <6e8eebd7-eed7-11ac-dc8a-e1dfe5f2a47d@simark.ca> References: <20200429134808.3642-1-ssbssa.ref@yahoo.de> <20200429134808.3642-1-ssbssa@yahoo.de> <911174982.4511581.1588178963372@mail.yahoo.com> <45689522.4534618.1588180764080@mail.yahoo.com> <6e8eebd7-eed7-11ac-dc8a-e1dfe5f2a47d@simark.ca> Subject: Re: [PATCH v3][PR gdb/15559] Use thiscall calling convention for class members MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.15756 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 12:42:33 -0000 Am Mittwoch, 29. April 2020, 20:27:02 MESZ hat Simon Marchi Folgendes geschrieben: > On 2020-04-29 1:19 p.m., Hannes Domani via Gdb-patches wrote: > >=C2=A0 Am Mittwoch, 29. April 2020, 18:49:32 MESZ hat Hannes Domani via = Gdb-patches Folgendes geschrieben: > > > >> Am Mittwoch, 29. April 2020, 18:45:35 MESZ hat Simon Marchi Folgendes geschrieben: > >> > >>>> @@ -234,6 +264,8 @@ i386_windows_init_abi (struct gdbarch_info info,= struct gdbarch *gdbarch) > >>>>=C2=A0=C2=A0 { > >>>>=C2=A0=C2=A0=C2=A0=C2=A0 i386_windows_init_abi_common (info, gdbarch)= ; > >>>>=C2=A0=C2=A0=C2=A0=C2=A0 windows_init_abi (info, gdbarch); > >>>> + > >>>> +=C2=A0 set_gdbarch_push_dummy_call (gdbarch, i386_windows_push_dumm= y_call); > >>>>=C2=A0=C2=A0 } > >>> > >>> Just to be sure, this call convention does not apply to Cygwin progra= ms? > >> > >> > >> I don't really know, but you're right, I should find out. > >> I will install & test with a cygwin compiler tomorrow. > > > > Installing cygwin went faster than I expected. > > > > And yes, cygwin does NOT use thiscall calling convention. > > That just makes me more glad that now there exists a distinction betwee= n > > cygwin & non-cygwin programs in gdb. > > Ok, the patch LGTM then. Pushed, thanks. Hannes