From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6331 invoked by alias); 28 Aug 2018 16:57:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6321 invoked by uid 89); 28 Aug 2018 16:57:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:061c, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 16:57:46 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1BC564000783; Tue, 28 Aug 2018 16:57:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94D79A9E6D; Tue, 28 Aug 2018 16:57:44 +0000 (UTC) Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue To: SiZiOUS , gdb-patches@sourceware.org References: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com> From: Pedro Alves Message-ID: <18eaf339-ca0a-061c-4a17-b837e6ef81a2@redhat.com> Date: Tue, 28 Aug 2018 16:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-08/txt/msg00694.txt.bz2 Hi, On 08/28/2018 01:01 PM, SiZiOUS wrote: > This little patch was made to allow the compilation under the MinGW/MSYS legacy environment (I don't know for the newer MinGW-w64/MSYS2 environment!). > If this patch is not applied, then the compilation of gdb-7.12.1 under MinGW/MSYS is impossible. GDB 7.12 is old by now and not actively maintained. Can you check whether this is necessary on the master branch? Also, it's a bit curious that nobody else ran into this so far. Could it be you're using an older mingw and that the issue has been fixed in the mingw/w32api headers meanwhile? > This fix is not intrusive as it's taken into account only if ERROR_IO_PENDING is not declared in the current scope, so it should be considered safe. > See the Bugzilla bug entry for more details. > > Please note, this fix only allows the build possible under MinGW/MSYS, there is no bug fixes or improvements for GDB itself. > > gdb/ChangeLog: > 2018-08-28  SiZiOUS > >     PR build/23568 >     * ser-mingw.c: Conditioned fix allowing compilation under >     the MinGW/MSYS legacy environment ('ERROR_IO_PENDING' was not >     declared in the scope). Thanks, Pedro Alves