From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85294 invoked by alias); 17 Feb 2017 01:28:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85283 invoked by uid 89); 17 Feb 2017 01:28:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:cf9c2c5, H*MI:sk:cf9c2c5, H*f:sk:cf9c2c5 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Feb 2017 01:28:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6EB90804EC; Fri, 17 Feb 2017 01:28:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1H1ShFp032385; Thu, 16 Feb 2017 20:28:44 -0500 Subject: Re: [PATCH 1/8] Rename read_unsigned_leb128 to gdb_read_unsigned_leb128 To: Jan Kratochvil References: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> <463df715-da64-57a4-3237-99826918def1@redhat.com> <20170216194026.GA30138@host1.jankratochvil.net> <50c2f5aa-dedf-5c32-438f-1f9023795ec0@redhat.com> Cc: gdb-patches@sourceware.org, Victor Leschuk From: Pedro Alves Message-ID: <189e471a-ebb0-a254-d854-05593c61531a@redhat.com> Date: Fri, 17 Feb 2017 01:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00461.txt.bz2 On 02/16/2017 10:54 PM, Pedro Alves wrote: > Actually, I think visibility wouldn't work given bfd is linked > statically. And C++ namespaces are out of question obviously > given bfd is written in C. That leaves avoiding namespace > collision by renaming something, but I think that given > that it's bfd that is a library, that it should be bfd > that should have its internal-with-external-linkage symbols > renamed, giving them a "_bfd_" prefix, as other internal > symbols have. I quickly hacked up a mini-series to rename these > plus a few others I noticed by playing with nm + grep. I'll > post it to binutils@ in a bit. FYI, this is now done, and merged to master: https://sourceware.org/ml/binutils/2017-02/msg00165.html Thanks, Pedro Alves