From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30885 invoked by alias); 28 Jul 2012 11:41:23 -0000 Received: (qmail 30875 invoked by uid 22791); 28 Jul 2012 11:41:23 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Jul 2012 11:41:09 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Sv5OO-0003oU-Ez from Yao_Qi@mentor.com ; Sat, 28 Jul 2012 04:41:08 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 28 Jul 2012 04:41:08 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Sat, 28 Jul 2012 04:41:06 -0700 From: Yao Qi To: CC: Pedro Alves Subject: Re: 7.4->7.5 Regression gdb.base/pending.exp with gdbserver [Re: [PATCH] Dynamic printf for a target agent] Date: Sat, 28 Jul 2012 11:41:00 -0000 Message-ID: <18940192.JmGRuSODTD@qiyao.dyndns.org> User-Agent: KMail/4.8.3 (Linux/3.3.7-1.fc16.i686; KDE/4.8.3; i686; ; ) In-Reply-To: <3480554.LITosdQYbn@qiyao.dyndns.org> References: <4FC57340.6070306@earthlink.net> <5012C373.4050006@redhat.com> <3480554.LITosdQYbn@qiyao.dyndns.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00720.txt.bz2 On Saturday, July 28, 2012 06:23:41 PM Yao Qi wrote: > I am wondering that the original code can skip some "bad" chars in 'X' an= d=20 > 'cmds:' to go to next ';', and I don't know this case does exist. We may > add an assertion at the end of 'while (*dataptr)' loop, like this, >=20 > while (*dataptr) > { > ... > gdb_assert (*dataptr =3D=3D 0 || *dataptr =3D=3D ';'); > } Sorry, my brain didn't work just now. It is wrong, and please ignore this. --=20 Yao (=E9=BD=90=E5=B0=A7)