From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2Vf/AqM6hmmOkywAWB0awg (envelope-from ) for ; Fri, 06 Feb 2026 14:01:55 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=S50m9dul; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E5CEA1E0BA; Fri, 06 Feb 2026 14:01:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 495C41E08D for ; Fri, 06 Feb 2026 14:01:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id CA09C4BAD163 for ; Fri, 6 Feb 2026 19:01:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA09C4BAD163 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=S50m9dul Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170110005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::5]) by sourceware.org (Postfix) with ESMTPS id CA2AD4BAD151 for ; Fri, 6 Feb 2026 19:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA2AD4BAD151 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA2AD4BAD151 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1770404486; cv=pass; b=AXIykFaVGZldmUM8ittq1HtrPLEibZneBVyzxSjJiMmZzvk2o0k2eWdooEZhdf97PwvxsYrFPiz3a5s9x2dl+nPJn2xwKOra6sD4toX5SdDELuaSijLEwJ1oP+NBiwGM1ZsNWTQiqmwxKfAiTCE3oA6hsD5E29EpqsxXzQJJktU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1770404486; c=relaxed/simple; bh=I69FNfNUjBI5J7C+T2jwmVTNBRxgFsV6FIpc8EJs70M=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=PlQtyZuteFsnWOPmBqTy2s8s7W2ZpNpxJGZvTV0jlS/LGa/2stR3kqk9nJQPTZ5gPkEBNJEqleddeQBeTtYhh80BWr5wZo2/y7TQM70F3NbovS5P2jLiMcWGK1/giL9RcmUDdRwRa7ch8NWiqopzwXiv3t1OiejkVwT0C1MNv1Y= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA2AD4BAD151 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vfeo8nDODLnmNHExOx+lars2dRTEqDwztSybYef5mnnvBUjKnluCDU+wkJatj3+AugANRTuoue6QDp1B/Zvzw73H+BsgcGuCw8EuO9W4+5I9UNGMwgt1nb2yO8GDdnCvBOd3L6EDv9cKlMJ3JCxJioy90OZ0NN283dAjdAOXbedkKYuCOK3RzX8DLvRtqOnJISRejANsq1rBNK9W6KVKSYK1YhU3JTlGZxz0ilJ20ThQDcp/QZGkX34Hd92ztnaUAoQNENNNyAWEcIW+Qc1Nd2+bhJRPArpnzR2mjzi7zud+XcKf2BNQb3jIyjllnQmaHxZqlSc4QUhWlSAZnv9XXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HSSUZdm9dl7oI/xad7N3bha1cXmqI2CFS8HabcC/ZlU=; b=iEgMG3Hj6jF/m/6yywF6uYJD1Krn2i1P3J5dvUud4Cc9cqeK06XY1AEe3uJ/+SHblMOL247qKn0CmiUgWYBuJQW6KbXjKLsK/VSt+nG3ksQh6tPh7T45np0XCBUIFCMB0Gm33Ak0t514vaT5AwSxw6BUJ8S1E7T7s0zGBwSQldZh4pFrYfZxzKQFK2Z2kTzvDYQaqgEK0MfKwzjTNJr5H0aR4p24AVYgih8iYauw4mUebyTOLXHbTpVUdlcIovhxZygSrRe/8fg4uyGTxlda22fyI/GhlpR68ySjUZPFhEt2WGLhMto2qoBBp9TOiFzpMdyoq4QMkDJ03AjjlBoJMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSSUZdm9dl7oI/xad7N3bha1cXmqI2CFS8HabcC/ZlU=; b=S50m9dulFEVr7HzWXk5X7zD71ka34hknkD7obSLcnLvxHZXZaZVXdy5Ifp1vQohj/YngiikW4EA9d0bksXSUYAZUuHqL7InH0HD37ShG9q6tF8/PN/n47FXxUZzif0KytUaK4ZGBGP95h+BG2lGACa9LHK7qbLjc3yuKS1Vls8rc0YQbi/pSKJuyACc4BxHx9POmpsmsN3WO22HDYesFq1eg0wxHkS9a7XxhEnFwgaEInG0/z4SMkIn+AVAz5vE8tDKj8MVgTta5mmy0l8aMuR2QIcl2/QJSuXMb3w1jjNETeYGj48sD2tp/ov/CZXV2n5QyiaxTl9KTn3PNET993A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT3PR01MB10282.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:8f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.15; Fri, 6 Feb 2026 19:01:22 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9587.013; Fri, 6 Feb 2026 19:01:21 +0000 Message-ID: <189096bc-677f-410c-aa2f-f32d59e926fb@efficios.com> Date: Fri, 6 Feb 2026 14:01:17 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union To: Tom Tromey , simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> <87v7g94yd2.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87v7g94yd2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0152.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:7e::11) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT3PR01MB10282:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a062615-d97b-4a59-b842-08de65b21e19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cEhsRzB2bWpSQTZMdkkvM2swTlhKdXRnVkkvQURpSWNzTWlyeUg0VXNDdk13?= =?utf-8?B?ZTJjTWpCUHZmT2luRlZMRnZaZUJxWGJHUTREbHp4b0FjaFZtdFJBZXgxMDV4?= =?utf-8?B?K3kvOENkUUFoNjkzcjZwc085R0JtRW8xUStjbW9FeW5mU2lVeEVta2dBMjJw?= =?utf-8?B?NGtzK0JtWWN1K3Iya0p4TFkvV2dSV1NXYWpOMjhucERuZjhjVDhmV1pKQWVh?= =?utf-8?B?aHlVcVFkYW95SjZOZXdGNEVXeXZrT1hFQ1BObU1oV01ESVNMKzg2cXloRnhK?= =?utf-8?B?am92Z0djWnBZOXJBcVV6WGx6ZDlmOUJwY1BnL2pYai9tbVhmd0VBK3pDNEVi?= =?utf-8?B?aitnaXF1ekR5N2lnZ2JWNi9HT0d6b2NTM0Y3MEpXdituSUl2MzhseXd1dXBw?= =?utf-8?B?N01zalFEZnVNQVBJRytGd0M4UGRBN1p5TUQrZERxL0F6TEsyM2NqVURaOHJ0?= =?utf-8?B?eHVrYXNKSlh2dmJITTl3enhEOG5RbWhzQldUV0tFMUF3N1BCRnd4UThnNmp3?= =?utf-8?B?MzJMaXlzTnJyY1lvZTZCOVpDS3Z5bHBPejJWb1hHcjVuSzg4Y0pIaWVDRmgw?= =?utf-8?B?VGRKTlpjeXJ0anNLSDFzUGN6dml5eGNieEQxSldpRnZqb3k2eFBjTHZNb1ZW?= =?utf-8?B?bkdjbVVsL1RqeHpvTnFoODhtdE9Sb3dJRVcyTzJnUE55WGN5ZHZ6WjU5RzB2?= =?utf-8?B?NDQxUUtkSGpiT0VlQURxakx5d2xqQnFxTHRmL3JGRmlCYksxTmRrL1lUVjMr?= =?utf-8?B?a3lYMHRFNSt5NHEzSzU0L3I3WTVDUXFZQldHZjAreDRPNnlsWGFPazJhaDdF?= =?utf-8?B?MzM4MDRUWjN1eEdsQTk2VmowYTNuNmVPQXE4Q3JtK282OUFTNWFpMi8wN1dU?= =?utf-8?B?OFpweVBRMlk1eFgyWldnbnBVNC80SlF4c2dHQ1d5Rkp4SytkTyt3OUR2bW1x?= =?utf-8?B?eURvWml6RHdBVFVKN0d4ZUNqZjBuaThnaDZFUU9nMDN0TEdvcGt0ekVvWExm?= =?utf-8?B?TGtDQ3k2L0RicktMSjFjbGxpWTNZMmlxaXB6bFlEa2h2TklXdUhtd2R0aWlI?= =?utf-8?B?VUhhZ1E3UWhJT0txc0FNU0M2NytRRlVlQzB3NzJLcjNZblVudittSTMxZG15?= =?utf-8?B?Sy9GdUNnZ2JvVXI3cWpHSmtDVzhzMHU5N291Z0xCY1I5N0lmZHM0SVc2RWRT?= =?utf-8?B?Y0E4Ull3UXdKZnVhUXBja0gxMWQxVWlqdU9DYzNPYUlUUUl2SDNxSS8rek5T?= =?utf-8?B?UmR5Rk4wbTVic056N0NPalpXWFhESE1ENVcwWFJYNi8rWmUwOU1BWWNyWTNV?= =?utf-8?B?WDZqWERUdjN2UGdWdUJMOVQ2aEoyTnZuWVY1VmVyOTNVdEl4NEhFZnI3VWFi?= =?utf-8?B?cnBkR2dWaU9vQXpKb1ZBZEZBb2hSL2swQmhmVXhXM3F5YUNkOE13VmhqSm5z?= =?utf-8?B?QmkwOUxrdllCc0VvOFl3TC9EZThWWFpaUU1OVXhZcFRVaExQcFVUTzhZOXpQ?= =?utf-8?B?V3pldE1iRTg2aFg4a3lFM1hKNXJhVDV4Z0l1Z054RFlLczBzMHdZU2NGT3pW?= =?utf-8?B?UmlhOUVvdGIxWUt3NGJPTXlsV0RPSHJLd1cwM2xTWVZ6YmVQNEp6STdzMjV2?= =?utf-8?B?L3c5bkxWOGhnRmZraFd4SkhnQ2psTENRRmN0SHdQbUc5Y0dJM1FMWVJtQm4w?= =?utf-8?B?dk1Fc3JMbVlGV0xQcEJ6bHNKaTlYRmdCWmNjQ0hIemVMOXMwSUZabzRaVm1J?= =?utf-8?B?RFNkaGhiaHphdDZTMEhrQ1FFRUdVOUFDSHJldWorQjM0NGlqSWdvOW1YN21Z?= =?utf-8?B?MTRSRTVqN1M0QWNzaGVNWVgweXNjd1JBa3Y1RFpmbEFzTkZHUm1zOVQyYU5s?= =?utf-8?B?RVZqZTFkcmJwWDM5bmRNRXFLZnp2UitjTmtNWnV0VWVpNHloZW8xeE5RdXJZ?= =?utf-8?B?b2d1dmR0anVuZDdhTEhrZ3lIM3U4bkRjanhzamxsTkxqUjJQV2w5N3dvK2JT?= =?utf-8?B?V011dk44ZEFraWJXVE16N05JUTZZMkJLaVBQTFArRlFYeTEzQVpreElTenJ3?= =?utf-8?B?ZzB4dDJpRzdka0dubFZ6bWgwVWVYcWNSUHF4OE51TFdlZzV6YXlkcFlSY0FX?= =?utf-8?Q?lhqY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(7053199007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFkwR3Q1b1VKcFVGWkprUityd2tSZlBObkJLcVU3VVFhWjNBdHpRajlqWUtu?= =?utf-8?B?WEk2cVR4RHRiN0lQL0JxYSs2c05vbTFEMWFvZEVkWk1UdHRvb1Nzd0doejg0?= =?utf-8?B?Z000MUtYd3J1Q3pvU1ByMlg4YnAyOXdBWVlacnFlWHlWaWZLNDFLcC8wbVpy?= =?utf-8?B?YWF2M0E3WWxLd1VaQWlKR2V5VGhYU1hNNjI2YkJmVTZRa05RZkU2SGpaTGJy?= =?utf-8?B?dU5XY2w2SkNxWXk5Y0VTQWtrdXpDSnVlWWZ6cUxiS3p4RjNGazdZS29CT05Z?= =?utf-8?B?YUdydmNQL3ZxRHNFUmx2N0x1dW9zRjcyempSeEl2bWRMRzVta0p4Q2V1anho?= =?utf-8?B?L08rWlNoNnc4UXJwTHZOWGhhbXQrU0pWcjRPYi9Da1NqcGdhWmxEa0dUUWNJ?= =?utf-8?B?azJ1bGFYRW5RclpZMkJiNGtURkV3c0pCVFpOQXY4Zk91elFLTU5JQ3JpdkZS?= =?utf-8?B?Z2pyUHRibDIvSUttY2xvMXNFTlo3S3pza2NtMlA4bVFSaTJTNHJlRERXNWVX?= =?utf-8?B?cWNOS2tJN1dWeHptWFFoMElMSlRiNWF3R2VLWE4xSC9OSnZBQXVRa1RJck5o?= =?utf-8?B?a3JnNHBxRGF0Uk0wVHEzMU9YbDlRYW5UNlloZDl3QmYwRTlieDc1VFAzQmhu?= =?utf-8?B?andpWnFSMDlCcDEvOHp3QW9RSU9ycVptNTZjQ1VYWVpTNURGeUxxS05yMkNj?= =?utf-8?B?c1FXbVIzMkRCQmdhaFJaakZ4bUwvOXR5SUdBcEtmOThqMHdVZ2NxZmV6a3Jv?= =?utf-8?B?dHp6dC9wWDkrWS8vcjllZ2RrNGg2aWJIbjJVMUJlOUg0STFCNmtPRytJYUk3?= =?utf-8?B?NTJTUnNQU0ErQVpXMGhSSUVMYVp0YjFFYWpWT3J2eWVwcUhqTHZWdk9mRHJG?= =?utf-8?B?cGdYbGlpV25sdkJlL0l2VzRaU0hyaVRKYWQ5TE9HUGRCM1dZdndjNmVYOTJS?= =?utf-8?B?Y1NXQnVDZ2JWZkVZaVUzZWdMOW5Uc0JYWWYyeHNQazUzN3JDSFUvdkhqalF3?= =?utf-8?B?Z1oweFVYc1ZCVTgxa0JPUXBTWWpmWE92WFFjK0NQNjBFQndIcEJMbndpSzBS?= =?utf-8?B?L092dE1QSmhGbGJUSFJYZnNrWFdhaDcwRkw2Vlk5K0daWmcwVElTM0pKMEdk?= =?utf-8?B?MHRWekQ4L0ZCN0llTEgzZTVxNW1yaVNWU0phUnlUY0wrdmJUM1F2MVFXTTJV?= =?utf-8?B?aGRDM3hZOEwzSXBlQTRMSFJyUkdnNjBaQlF6WGhSZERMZkhRclgxWWZYQXNx?= =?utf-8?B?OU43OEkzT0RoZmtTd1RscVYrQUYzYzdjOU8zRng1UTlOSENkK25mWlhOV1NG?= =?utf-8?B?SUpxODlKNnRVOUNxVENyTHFoN294TjVXSjFNNTd4TEFrWVlRWHFxYkN0Y1A4?= =?utf-8?B?SDBGMUUyTVZzbTJxTmJ2dkNPb0t0N2sxaERuN2g1WGl6M3V6T3pENE9SYVlE?= =?utf-8?B?QkVJajlzK0RMNkJ4TXp1MW9zRVFCcE10ZW5rMW0rNzJObXF6VHYybTVVUEt2?= =?utf-8?B?RVpkSWxkOGp2aXlUZmlXZitSWkV3SlMvM2k1SkxLZThjTnRtcmx6dDNERGRO?= =?utf-8?B?UDRpVUdHcmxhcFBQRExJblM2ejh6S3prWFJGUk5SRFBpK2VXdWM2bmNHVXlw?= =?utf-8?B?RFdSS3h1Q0NWSkpWUG1vanBFdmhUbVNXUXVkU1FXejhCS2F5L0hjQ1RxdW9F?= =?utf-8?B?ODlaSE84bTlIem80TWY0Z09obXpUZS9uY2RiWjdnanA1ckx0QUp3Q0JvZ1RG?= =?utf-8?B?OGFKekNBSE1NYzhNVDRuVjlMR2Vyd1pocVY0WHBQNDNYQkVXdWJia3NoTU1U?= =?utf-8?B?a0RhbEJ3bXdnc1hxYXR3djJIai9FckoyN2lWcFAxMnZKaHloTXVkQ3NDSnVD?= =?utf-8?B?ZnJxV3Y1ZFhmN0w3MFRrWExzMHM1cGlqR20vQW1BU3kxL1pVTDMybHovZzJm?= =?utf-8?B?dEo5TFI5RXhpNXNERU5GUnM3Mm5pdy9iZFFtbjlTSTRZWTdzOG1wQjFoWFdG?= =?utf-8?B?bEJWeWVPamdwUU00czNjYUU5TWFIV3BHSlRLUlpHeUhadG55V3R0UlQ3NlRo?= =?utf-8?B?UU1uUW9Kcko4enVxRWtSUmh2NUhET084eC9LSTNZWlhnb0R1NG1VUks2c3BG?= =?utf-8?B?cTNNNmJpNERxNUF1bXliYi9BL3hHc3BQaTZ2ZThiMU5NYjIvU1o3b2t2dVow?= =?utf-8?B?a1dpdDNCZVFPL01JVmsxR3l3ajNTOTVXMjVvQnRSTE9Wd2QzdCt3UGRrK0NZ?= =?utf-8?B?Tm9tcmJkOFJyV0huV054NXVXVnBTWC9MNSthREU2OHBMbmtqOHFkcU9xUTZ0?= =?utf-8?B?c3VWUURHSlhsaHROY0M3aXVQRzl2dituTVo3QjhMT0pISWd0MlhMQT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a062615-d97b-4a59-b842-08de65b21e19 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2026 19:01:21.8487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ltfWJeo6fkPrvBPc9drU8I2khUAihzOx7Ff3PC8Yb9w87bGAsGlh/fDM24lJ42Ei3DwuLanu0P/qeseH1kEngQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB10282 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-06 11:42, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> The block field is never used. The block is only used to grab a > Simon> reference to the mdict, which is stored in the mdict_iterator. > > Simon> Remove it and remove the union. Leave the compunit_symtab field, whose > Simon> name unfortunately conflicts with the method. > > Seems reasonable to me. > > Using an m_ name wouldn't be remiss, we have other cases where we've > done this but where the field is still "public". > > Simon> else > Simon> { > Simon> - iter->d.block = block; > Simon> - > > I didn't look to see how the initialization is done, but I wonder if > this should assign nullptr to the compunit_symtab field. It could, but I don't think it's necessary. This code path puts the iterator in FIRST_LOCAL_BLOCK mode (iterate on a single block), and it's forbidden (protected by the assert added in the following patch) to access the compunit when in that mode. So it's fine if it stays in an undefined state. > Approved-By: Tom Tromey Thanks, Simon