From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MEeSEQ/B/WUBxxEAWB0awg (envelope-from ) for ; Fri, 22 Mar 2024 13:34:07 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=drdgTqan; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=drdgTqan; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3970F1E0C0; Fri, 22 Mar 2024 13:34:07 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F19921E08C for ; Fri, 22 Mar 2024 13:34:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9903A3858410 for ; Fri, 22 Mar 2024 17:34:04 +0000 (GMT) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2042.outbound.protection.outlook.com [40.107.249.42]) by sourceware.org (Postfix) with ESMTPS id 86F4A3858D37 for ; Fri, 22 Mar 2024 17:33:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86F4A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86F4A3858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.249.42 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1711128826; cv=pass; b=k0f8Dp5lJJB80fzDVFhVwK1srmth0cNJPIw7LsCoMPgjx7CGd0H9Vjh0UeuLKa1xETlYchbLBkRCWmOsw8y/P5nkvElBBrhuzggrZnv2U1CS62PDB1PUWPWP4lu55hPua2wzMes+luqrASTcDnErtNT7zkVcLKIZN23qlliVmMA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1711128826; c=relaxed/simple; bh=0W+O6MpVn7uaz4H2GMGQPOiucbnz99tKaOjiDRZTocg=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=wvl7I9Qz5Yi5k/K978dfKW0ZUMyMHLILlYEHdl7Wssk3tDoK/TmlTgaqTtEuFQ8tlzXxkJsJhYHLHazvRTVa2NX1U/LRVFTPGcRik4qZC0cGzGdQ72CSqnEnRhuDyVgTssCzYSvN1vmUymjRboRzfkdzwx88NnnwqaFM/st4WDM= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TS7uQzz1Byk8juiYWRwM/Cm3KRMew/hsC3hwffhydL+sMTunEZNDxgXf8RSj3/+D60u06qEQN4/xGm4O87F+rTMFhJMQ0BlwoOvVNzUi/98CzNgI6DYeLd6hSVQCODJUyVt4xJfxXNjPUxjzQLaFEDg1ZM1EvLyEQpF+hzbKPywxxCcrnICzGXsxjC4C6d+C32le03b917JXmb8TuPX8E3aUNigl2yGXy4B25FM3I5pQoybV+KO6jfkj2gvSCckwJKI3E+v4ZxRkIsIhp4rq1ZWSD6GdcoMVRlfBRDM/Z5+iOMUpvjGkCEdjxA+oL5Ys5YGGI6xFFOE7g1C94mQbuA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fxa5CuDvS8csebIO+HfN8GZW2rlDo6nsvthgvZGwqzk=; b=K2Xvc4WD2ObjU2Q0jSW2XU5QpeaWTnzLQ9adYYS2jd8n/T288sGkHY7oWUa+ff1s4Cs4DG035OHarLNJuyUfWv/oBgM5zwMIk25ZC07RkEv6aBTYsFxzW9NVHysg+3qIpQFB2nWrcZ6OhfmXCz8wmabTkPedyRxpdz7BTQ0JehDiQKwWMB9F5uaiDKPELFgGUeEsYF4HtpDizSN5CgQiCbtV94q//Ho/ECw7wFfiDYuTQB1WNfgXXxDTvykkRgLesECFPxCZeX2xG+NigVBYIbkFz0USY6Iim5A1oBNRl8HfbkJcpyiNQ8amiuZ3bdzDTmiev07dVQ+2Ti4Ub571bA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fxa5CuDvS8csebIO+HfN8GZW2rlDo6nsvthgvZGwqzk=; b=drdgTqanDvjuc+QZ6Rr6nKMOtUB4PWqi+v0t+seHp800woSmPJIgrkKFKOgFKnxcdoha+Z5fjCkpUy4nMAY22R1SPyBkS1cGpsNkl84f9aoiEf3Ha33kHtDFgz2A6ymoALoumm3kL86h1LFwmDtgUi6H2b7IFjhKzsJ1R3v34nU= Received: from AS9PR06CA0019.eurprd06.prod.outlook.com (2603:10a6:20b:462::12) by PAVPR08MB9435.eurprd08.prod.outlook.com (2603:10a6:102:317::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 17:33:32 +0000 Received: from AMS0EPF00000191.eurprd05.prod.outlook.com (2603:10a6:20b:462:cafe::92) by AS9PR06CA0019.outlook.office365.com (2603:10a6:20b:462::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend Transport; Fri, 22 Mar 2024 17:33:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF00000191.mail.protection.outlook.com (10.167.16.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.10 via Frontend Transport; Fri, 22 Mar 2024 17:33:31 +0000 Received: ("Tessian outbound 5ad6c4395be7:v300"); Fri, 22 Mar 2024 17:33:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4b0df3f0e950ad6e X-CR-MTA-TID: 64aa7808 Received: from b8eab5c9ef7e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FCF1DDCB-9006-4AF5-8993-4BBF315F2870.1; Fri, 22 Mar 2024 17:33:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b8eab5c9ef7e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Mar 2024 17:33:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVwVOMHFNdHuv/w6TFUZFqZL2MmoSzO3ojC+Gf3/cqSeqqXc92pZUOjN+kD83OsSwclgzTxY6S/Klfr08M7DZFjq97kOfLMBkaFy4pQ0E+PdHD6Lo2w0xnaEyGjDm1iqoTGPtnRHOdjT5RM6D+Efs3JmsGpXZnjFA/FsKBFgdk5lhs9aRctA6WpW4Q/MQAF3iIVkNKNm3Ocsnui1Nfu0oaNPXWurvOdVaN0PzykwzMVK1IhOzEnuILlejtkxpTeTQAlS7MVmijUFw45YundaZqKmqJ4Ql0BH9DIRtBEWOM37HeDbSH2AUbN3nrxKIi/2ef/jpn1z+XqDUtmraqI7iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fxa5CuDvS8csebIO+HfN8GZW2rlDo6nsvthgvZGwqzk=; b=Q0yhOLQrElCxws81rwPw3OeZ1yC1d+6aWUJ5BskcODG+Se7Hn9aQJj8UKbuCiFlPYU41Fv0lL5wADxSNGJ9X1xGoLpbO0yITQB5f+zsypNVv3j8wq5wUiwj2qD2fhg1CE8OFWE4wutbTSaTaRj4lB0TZEQRrgudf3zXH7thl92eses0C8rX0PkdkjFqisgYpIXqE728tmqYAY6WeWxsURMT/YSEmTsoAEWNsA4mB4E6y66YXgt42GRTEo8/pmgrir0LrHCcmj1ksFMgqv8caqpapcOiM6y41zzlYMHRZv3xDMgSU30WNm9KYYq++sJyYh0FXfhBJEhiE8QLyqlyPFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fxa5CuDvS8csebIO+HfN8GZW2rlDo6nsvthgvZGwqzk=; b=drdgTqanDvjuc+QZ6Rr6nKMOtUB4PWqi+v0t+seHp800woSmPJIgrkKFKOgFKnxcdoha+Z5fjCkpUy4nMAY22R1SPyBkS1cGpsNkl84f9aoiEf3Ha33kHtDFgz2A6ymoALoumm3kL86h1LFwmDtgUi6H2b7IFjhKzsJ1R3v34nU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV2PR08MB8148.eurprd08.prod.outlook.com (2603:10a6:150:7c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.35; Fri, 22 Mar 2024 17:33:23 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7386.025; Fri, 22 Mar 2024 17:33:23 +0000 Message-ID: <188824c6-ac5b-47fc-b137-1555432b6313@arm.com> Date: Fri, 22 Mar 2024 17:33:21 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] gdb/nat: Use procfs(5) indexes in linux_common_core_of_thread Content-Language: en-US To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20240321231149.519549-1-thiago.bauermann@linaro.org> <20240321231149.519549-2-thiago.bauermann@linaro.org> From: Luis Machado In-Reply-To: <20240321231149.519549-2-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0409.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::13) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV2PR08MB8148:EE_|AMS0EPF00000191:EE_|PAVPR08MB9435:EE_ X-MS-Office365-Filtering-Correlation-Id: f3889df4-21b3-4c55-ae9b-08dc4a9631c2 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bUHEHBIXFeHjm78WxgcnZxWj1d4KOFKyG2UX6M0pfGez0BJTgNOOINi4Zo6eM9l8xC+2KvM6Wl6Xc6nc61xlFcaORhtiJTgrKxSKR0YaFvOrBmjrc4k4tS/6HQvzLcoj2wOstzR2BpVsTOU13/XK76ZyDNRO7H4CezVZxiEFVhNbfPbsuMoPdmLFQ1IpVcQ8va5/yvR2pHNLtDdwsdo8ovd5yM+484e6+zYjjvXH8gOX9cnqrHj4+3xnP2he7Is5800G5YW622dm0qBOc6kJFXyq2iZoHeLuMHBZZ5tvQFC+UZjckl+Qv8AJ7KFwAT8NAoNAvwY6abe/fYoOInr4BqXKQ1x5j3U6bbFJ0OPCVZAU7JiFVLRVuhymwv2VR83BHIM2pqTpGa7CdXnaJr+m8lcQ1a1B9pAjSSz66nQJhR0Q58brQa9gNVuH0ibuRd7LW/0/YizEAsHPEYW5sa1HFGOpRb9NWsmTPE8RPN6wiR0d6x+fJcFhpezSYi42DQ0+iODFMHA7I0KVTWY5KawxMpafn+l3ec9noAz8wF5zHp9CbYzlciLO4vp0KtEHJ/S51vtcWRzTkl+8qYXdb+CpHeexO3F33hrQ0MrWuVSUP8Hazc8nFRxgjZsqmjSZSm8mFmXCPcubP2w4SBH28ReO4qLYq7sctWZRGp2VQ+DUg9M= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8148 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000191.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a3467cda-2c15-4082-d6b7-08dc4a962c59 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6HMY3H/phpeNPqc6n5iScLyiH0HxXMehO+kvFgiSVPgFMupLotxu+5i2/yo5m4mnEjP1hJmaLOD3IiVik2ONmuO+14sLVs7roDTj2+Od1Qaf8MXSQzX39hiaPXHVKbLnUqIavY8XxVMAFqADKkc8BhdshBf1oDThWIreBW1rMo2qBNjzdf+JlmrvSYoCOGY0VB9mmEP6zKFfa/jd/gctmt7yIsSkd5LXJGjiepp3sQwyx5UUuvLEcYWX8gd8Ut9ijLbgGmGMAHj//fUyq04K6GYXw9oFx1oqCTx5JP3ai6iefOdgISoKeLT0ihTklg/aJrKg+LvlynLYUXhxWF0w2qxm46AoeOMmU/oAXX1a7Opi+7Oye7CUmxc/a5cNCOYvls/3Z9FDczPDCh4UtpBaa+UHtWJV6m46VpH8JBLI/uc2cCmwv3nQh7/H6WxKtjMWOp4stQ6u3Jb0hUtsVs0o6nkqP8X3PSUakFCkyJbPe+5SSgl/jFGKWMkwQhHgkjjOwqIpQvDgajrR22ufqL0CY7kaDtp8jEveDH2+s0CH7NLWWJca8qfqpOoO5aeyIcgF3EWpO6+5ZWGTFelLhIBsMn4ZYRecnDByt6LaeHoZFPfWgZjlVMFzU8rOJpgL5UU8PdKlSwgd4yPsTLlvSo8F2PGVH6JWPmb9E/lbUmKrgcpAC7/AonNH34LE1yMMGPmaZxNBeXqGizoDKw5E+NKeM6sUykjUhbCXnKytHD4HtfesByYR+GnHikPaBnhkMATV X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(1800799015)(36860700004)(376005)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 17:33:31.9691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3889df4-21b3-4c55-ae9b-08dc4a9631c2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000191.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9435 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/21/24 23:11, Thiago Jung Bauermann wrote: > The code and comment reference stat fields by made-up indexes. The > procfs(5) man page, which describes the /proc/PID/stat file, has a numbered > list of these fields so it's more convenient to use those numbers instead. > > This is currently an implementation detail inside the function so it's > not really relevant with the code as-is, but a future patch will do some > refactoring which will make the index more prominent. > > Therefore, make this change in a separate patch so that it's simpler to > review. > --- > gdb/nat/linux-osdata.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/nat/linux-osdata.c b/gdb/nat/linux-osdata.c > index c9192940f236..172fea5cea85 100644 > --- a/gdb/nat/linux-osdata.c > +++ b/gdb/nat/linux-osdata.c > @@ -75,10 +75,10 @@ linux_common_core_of_thread (ptid_t ptid) > if (pos == std::string::npos) > return -1; > > - /* If the first field after program name has index 0, then core number is > - the field with index 36 (so, the 37th). There's no constant for that > - anywhere. */ > - for (int i = 0; i < 37; ++i) > + /* If the first field after program name has index 3, then core number is > + the field with index 39. These are the indexes shown in the procfs(5) > + man page. */ > + for (int i = 3; i <= 39; ++i) > { > /* Find separator. */ > pos = content->find_first_of (' ', pos); Looks ok to me. See the comment about turning the numeric constants into named constants. Reviewed-By: Luis Machado